Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use keyboard_pre_init_kb(void) at keyboard level #19091

Merged
merged 1 commit into from
Nov 16, 2022
Merged

Use keyboard_pre_init_kb(void) at keyboard level #19091

merged 1 commit into from
Nov 16, 2022

Conversation

0xcharly
Copy link
Contributor

@0xcharly 0xcharly commented Nov 16, 2022 •
edited
Loading

Instead of the _user(void) variant that should be used at the keymap level.

Description

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

Use keyboard_pre_init_kb(void) at keyboard level
a8b8680 
Instead of  the `_user(void)` variant that should be used at the keymap
level.
@0xcharly 0xcharly mentioned this pull request Nov 16, 2022
Merged
14 tasks
@drashna drashna requested a review from a team November 16, 2022 03:01
@drashna drashna merged commit d86c0d3 into qmk:master Nov 16, 2022
@0xcharly 0xcharly deleted the 2022-11-16-keyboard_pre_init_kb branch November 17, 2022 04:39
dkruyt pushed a commit to dkruyt/qmk_firmware that referenced this pull request Nov 18, 2022
@0xcharly @dkruyt
Use keyboard_pre_init_kb(void) at keyboard level (qmk#19091)
74920ab
thystips pushed a commit to thystips/qmk_firmware that referenced this pull request Nov 24, 2022
@0xcharly @thystips
Use keyboard_pre_init_kb(void) at keyboard level (qmk#19091)
10e3512
ramonimbao pushed a commit to ramonimbao/qmk_firmware that referenced this pull request Nov 28, 2022
@0xcharly @ramonimbao
Use keyboard_pre_init_kb(void) at keyboard level (qmk#19091)
20474e3
elpekenin pushed a commit to elpekenin/qmk_firmware that referenced this pull request Dec 7, 2022
@0xcharly @elpekenin
Use keyboard_pre_init_kb(void) at keyboard level (qmk#19091)
ad647ee
crembz pushed a commit to crembz/qmk_firmware that referenced this pull request Dec 18, 2022
@0xcharly @crembz
Use keyboard_pre_init_kb(void) at keyboard level (qmk#19091)
141a96d
nolanseaton pushed a commit to nolanseaton/qmk_firmware that referenced this pull request Jan 23, 2023
@0xcharly @nolanseaton
Use keyboard_pre_init_kb(void) at keyboard level (qmk#19091)
f78691f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fauxpark fauxpark fauxpark approved these changes

@drashna drashna drashna approved these changes

Assignees
No one assigned
Labels
keyboard
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@0xcharly @drashna @fauxpark