Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Keychron Q8 #19126

Merged
merged 7 commits into from
Dec 4, 2022
Merged

Add Keychron Q8 #19126

merged 7 commits into from
Dec 4, 2022

Conversation

KeychronMacro
Copy link
Contributor

@KeychronMacro KeychronMacro commented Nov 21, 2022 •
edited
Loading

Add new keyboard q8 which contains four sub versions
Thanks

Description

  • Add ANSI and ISO versions, including encoder variants

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@github-actions github-actions bot added keyboard keymap via Adds via keymap and/or updates keyboard for via support labels Nov 21, 2022
@drashna drashna requested a review from a team November 30, 2022 22:19
@kazigk
Copy link

kazigk commented Dec 1, 2022

Readme for that keyboard states the following:
- Turn clockwise to increase volume and turn anti-clockwise to decrease volume.

Rotary encoder seems to be reversed. It's clockwise for volume down and counterclockwise for volume up, it should be the opposite.

I tested on ansi_encoder variant with keychron keymap.

@KeychronMacro
Copy link
Contributor Author

KeychronMacro commented Dec 1, 2022 •
edited
Loading

@kazigk Thanks, i also found that the pin define of encoder is reverse and i fixed it.

@drashna drashna merged commit d878edf into qmk:master Dec 4, 2022
This was referenced Dec 5, 2022
Merged
Merged
elpekenin pushed a commit to elpekenin/qmk_firmware that referenced this pull request Dec 7, 2022
@KeychronMacro @elpekenin
[Keyboard] Add Keychron Q8 (qmk#19126)
d6d7f82
@KeychronMacro KeychronMacro deleted the keychron-q8 branch December 12, 2022 03:04
crembz pushed a commit to crembz/qmk_firmware that referenced this pull request Dec 18, 2022
@KeychronMacro @crembz
[Keyboard] Add Keychron Q8 (qmk#19126)
8c2ca20
sbhal pushed a commit to sbhal/qmk_firmware that referenced this pull request Dec 30, 2022
@KeychronMacro
[Keyboard] Add Keychron Q8 (qmk#19126)
264d5be
ideas32 pushed a commit to ideas32/qmk_firmware that referenced this pull request Jan 25, 2023
@KeychronMacro @ideas32
[Keyboard] Add Keychron Q8 (qmk#19126)
65c0015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@coliss86 coliss86 coliss86 left review comments

@adophoxia adophoxia adophoxia left review comments

@drashna drashna drashna approved these changes

@fauxpark fauxpark fauxpark approved these changes

Assignees
No one assigned
Labels
keyboard keymap via Adds via keymap and/or updates keyboard for via support
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@KeychronMacro @kazigk @drashna @fauxpark @coliss86 @adophoxia @galican