Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Keyboard] Add Pica40 #19220

Merged
merged 17 commits into from
Dec 30, 2022
Merged

[Keyboard] Add Pica40 #19220

merged 17 commits into from
Dec 30, 2022

Conversation

zzeneg
Copy link
Contributor

@zzeneg zzeneg commented Dec 1, 2022

Description

Add new keyboard - Pica40. Supports two revisions with different hardware, see main repo for details.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

  • New keyboard Pica40.

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@zzeneg zzeneg changed the title Feature/pica40 [Keyboard] Add Pica40 Dec 1, 2022
@zzeneg zzeneg closed this Dec 1, 2022
@zzeneg zzeneg reopened this Dec 1, 2022
waffle87
waffle87 requested changes Dec 2, 2022
View reviewed changes
keyboards/pica40/config.h Outdated Show resolved Hide resolved
keyboards/pica40/keymaps/default/keymap.c Outdated Show resolved Hide resolved
keyboards/pica40/keymaps/default/rules.mk Outdated Show resolved Hide resolved
keyboards/pica40/readme.md Outdated Show resolved Hide resolved
keyboards/pica40/keymaps/default/keymap.c Outdated Show resolved Hide resolved
@zzeneg
Copy link
Contributor Author

zzeneg commented Dec 2, 2022

@waffle87 Updated according to comments, can you check once again please?

@zzeneg zzeneg requested a review from waffle87 December 2, 2022 21:21
drashna
drashna requested changes Dec 4, 2022
View reviewed changes
keyboards/pica40/keymaps/default/config.h Outdated Show resolved Hide resolved
keyboards/pica40/keymaps/default/keymap.c Outdated Show resolved Hide resolved
keyboards/pica40/keymaps/default/rules.mk Outdated Show resolved Hide resolved
keyboards/pica40/keymaps/zzeneg/keymap.c Outdated Show resolved Hide resolved
keyboards/pica40/keymaps/zzeneg/keymap.c Outdated Show resolved Hide resolved
@zzeneg zzeneg requested review from drashna and removed request for waffle87 December 5, 2022 00:07
@zzeneg
Copy link
Contributor Author

zzeneg commented Dec 8, 2022

@drashna can you re-review it please?

@zzeneg @drashna
Update keyboards/pica40/keymaps/default/keymap.c
a639178 
Co-authored-by: Drashna Jaelre <drashna@live.com>
@zzeneg zzeneg requested a review from drashna December 11, 2022 08:39
drashna
drashna requested changes Dec 11, 2022
View reviewed changes
keyboards/pica40/rev1/rev1.c Outdated Show resolved Hide resolved
keyboards/pica40/rev2/rev2.c Show resolved Hide resolved
keyboards/pica40/rev2/rev2.c Outdated Show resolved Hide resolved
@zzeneg @drashna
Update keyboards/pica40/rev1/rev1.c
1e93a23 
Co-authored-by: Drashna Jaelre <drashna@live.com>
@zzeneg @drashna
Update keyboards/pica40/rev2/rev2.c
b8ae5b7 
Co-authored-by: Drashna Jaelre <drashna@live.com>
@drashna drashna requested a review from a team December 12, 2022 22:08
tzarc
tzarc approved these changes Dec 30, 2022
View reviewed changes
Copy link
Member

@tzarc tzarc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not a fan of the duplicated encoder hackery, but we don't have an alternative right now.

@tzarc tzarc merged commit ced8142 into qmk:master Dec 30, 2022
sbhal pushed a commit to sbhal/qmk_firmware that referenced this pull request Dec 30, 2022
@zzeneg @drashna
[Keyboard] Add Pica40 (qmk#19220)
f502f1a 
Co-authored-by: Drashna Jaelre <drashna@live.com>
jasonisgraham pushed a commit to jasonisgraham/qmk_firmware that referenced this pull request Jan 2, 2023
@zzeneg @drashna @jasonisgraham
[Keyboard] Add Pica40 (qmk#19220)
ce5e37f 
Co-authored-by: Drashna Jaelre <drashna@live.com>
@zzeneg zzeneg deleted the feature/pica40 branch January 4, 2023 12:51
omikronik pushed a commit to omikronik/qmk_firmware that referenced this pull request Jan 22, 2023
@zzeneg @drashna @omikronik
[Keyboard] Add Pica40 (qmk#19220)
546cb27 
Co-authored-by: Drashna Jaelre <drashna@live.com>
ideas32 pushed a commit to ideas32/qmk_firmware that referenced this pull request Jan 25, 2023
@zzeneg @drashna @ideas32
[Keyboard] Add Pica40 (qmk#19220)
0c6a692 
Co-authored-by: Drashna Jaelre <drashna@live.com>
jasonisgraham pushed a commit to jasonisgraham/qmk_firmware that referenced this pull request Jun 12, 2023
@zzeneg @drashna @jasonisgraham
[Keyboard] Add Pica40 (qmk#19220)
de34049 
Co-authored-by: Drashna Jaelre <drashna@live.com>
jasonisgraham pushed a commit to jasonisgraham/qmk_firmware that referenced this pull request Jun 15, 2023
@zzeneg @drashna @jasonisgraham
[Keyboard] Add Pica40 (qmk#19220)
3970a11 
Co-authored-by: Drashna Jaelre <drashna@live.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@waffle87 waffle87 waffle87 requested changes

@tzarc tzarc tzarc approved these changes

@drashna drashna drashna approved these changes

Assignees
No one assigned
Labels
keyboard keymap
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@zzeneg @drashna @tzarc @waffle87