Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert WB32 ISO workaround #19224

Merged
merged 1 commit into from
Dec 2, 2022
Merged

Revert WB32 ISO workaround #19224

merged 1 commit into from
Dec 2, 2022

Conversation

zvecr
Copy link
Member

@zvecr zvecr commented Dec 2, 2022 •
edited
Loading

Description

No longer required now product strings are quoted.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@github-actions github-actions bot added the core label Dec 2, 2022
@zvecr zvecr requested a review from a team December 2, 2022 21:32
@tzarc tzarc merged commit 4540f52 into develop Dec 2, 2022
@tzarc tzarc deleted the zvecr-patch-1 branch December 2, 2022 22:07
elpekenin pushed a commit to elpekenin/qmk_firmware that referenced this pull request Dec 7, 2022
@zvecr @elpekenin
Revert WB32 ISO workaround (qmk#19224)
019a00e
omikronik pushed a commit to omikronik/qmk_firmware that referenced this pull request Jan 22, 2023
@zvecr @omikronik
Revert WB32 ISO workaround (qmk#19224)
61d7f49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fauxpark fauxpark fauxpark approved these changes

@tzarc tzarc tzarc approved these changes

Assignees
No one assigned
Labels
core
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zvecr @tzarc @fauxpark