-
-
Notifications
You must be signed in to change notification settings - Fork 39.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add *_RIGHT
configuration for PMW33XX driver
#19243
Conversation
Can confirm this works well ! |
This of course broke the multiple sensors support. When using
At which point
This will of course happen over and over again, as we don't seem to have test cases for this. What is the best place to add some bare bones test cases that make sure the various combinations at least compile? |
Description
This PR allows to define different CS pin(s) for each half when using PMW33XX, in a similar way that it is done for matrix or encoder pins.
This is just a monkeypatch to extend the flexibility slightly while a completely flexible solution isn't available.
@freznel10 asked for a QoL solution on Discord, to avoid recompiling each half changing pins manually. As far as he has tested, everything seems to work fine. (i dont have the hw so i cant make any test)
The changes reduce to splitting some data structures which were common before into one for each side, and some defines to replace the old variable name with the correct data structure on each side.
Code was made with backwards compatibility in mind, thus everything defaults to be the same as left side if no configuration was provided, this should mean that nothing breaks.
While editing the docs i also noticed they stated
cable select
instead ofchip select
, and the default values weren't really listed, so i changed that tooTypes of Changes
Issues Fixed or Closed by This PR
Checklist