-
-
Notifications
You must be signed in to change notification settings - Fork 39.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Keyboard] Add Quarkeys Z60, reorganized keyboard file directory #19404
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. Meaningless defines deleted in config.h 2. Dead codes deleted in both defatul and via keymap.c 3. "LT()" function is deleted in keymap
Co-authored-by: Joel Challis <git@zvecr.com>
Co-authored-by: Joel Challis <git@zvecr.com>
Nothing is changed except that the files been moved into 'solder' & 'hotswap' subfolders.
github-actions
bot
added
keyboard
keymap
via
Adds via keymap and/or updates keyboard for via support
labels
Dec 22, 2022
Please stop closing and opening new PRs with the same content. |
waffle87
requested changes
Dec 22, 2022
Co-authored-by: jack <0x6a73@protonmail.com>
Co-authored-by: jack <0x6a73@protonmail.com>
Co-authored-by: jack <0x6a73@protonmail.com>
drashna
requested changes
Dec 23, 2022
Image link deleted
[Keyboard] Add Quarkeys Z60 Hotswap
waffle87
requested changes
Dec 23, 2022
waffle87
requested changes
Dec 24, 2022
Hi I'm sorry to bother, just want to ask how do this pr work, seems everything is done according to requests, is there anything else I need to do? or just wait quietly. Normally, how long it takes to merge successfully? This is my first pr attempt, appreciate, TommyZ |
drashna
approved these changes
Dec 31, 2022
tzarc
approved these changes
Jan 1, 2023
jasonisgraham
pushed a commit
to jasonisgraham/qmk_firmware
that referenced
this pull request
Jan 2, 2023
…#19404) Co-authored-by: Joel Challis <git@zvecr.com> Co-authored-by: jack <0x6a73@protonmail.com>
omikronik
pushed a commit
to omikronik/qmk_firmware
that referenced
this pull request
Jan 22, 2023
…#19404) Co-authored-by: Joel Challis <git@zvecr.com> Co-authored-by: jack <0x6a73@protonmail.com>
ideas32
pushed a commit
to ideas32/qmk_firmware
that referenced
this pull request
Jan 25, 2023
…#19404) Co-authored-by: Joel Challis <git@zvecr.com> Co-authored-by: jack <0x6a73@protonmail.com>
barrettclark
added a commit
to barrettclark/qmk_firmware
that referenced
this pull request
Mar 6, 2023
* upstream/master: (1825 commits) A comma was missing (qmk#19507) Bump anothrNick/github-tag-action from 1.56.0 to 1.57.0 (qmk#19502) Add SapuSeven MacroPad12 (qmk#19466) feat(kprepublic/bm60hsrgb_poker): update carlosala keymap (qmk#19426) [Keyboard] Stop LED1 from flashing on layer change (qmk#19427) Allow for specifying the number of symbols to output. (qmk#19497) Add `qmk mass-compile`, which intends to supercede `qmk multibuild` whilst providing support for filtering as per data-driven definitions. (qmk#18971) Bump anothrNick/github-tag-action from 1.55.0 to 1.56.0 (qmk#19494) Fix github URL for the atreyu maintainer. (qmk#19476) adpenrose/akemipad fixes (qmk#19477) [Keymap] Add Neo2-based keymap for Planck keyboard (qmk#19173) [Keyboard] Add community layout support to Piantor (qmk#19455) Keyboard/fix work louder micro (qmk#18968) Add docs to cover recent LAYOUT_all lint checks (qmk#19393) WSL `qmk flash firmware.bin` workaround (qmk#19434) CLI flashers should allow files outside qmk_firmware folder (qmk#19454) [Keyboard] Add Quarkeys Z60, reorganized keyboard file directory (qmk#19404) Add KB30 keyboard (qmk#19395) Atreyu rev2 (qmk#19443) Fixes unicode_map declaration example (qmk#19450) ...
jasonisgraham
pushed a commit
to jasonisgraham/qmk_firmware
that referenced
this pull request
Jun 12, 2023
…#19404) Co-authored-by: Joel Challis <git@zvecr.com> Co-authored-by: jack <0x6a73@protonmail.com>
jasonisgraham
pushed a commit
to jasonisgraham/qmk_firmware
that referenced
this pull request
Jun 15, 2023
…#19404) Co-authored-by: Joel Challis <git@zvecr.com> Co-authored-by: jack <0x6a73@protonmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Types of Changes
Issues Fixed or Closed by This PR
Checklist