Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

De-obfuscate random8 functions #19416

Merged
merged 2 commits into from
Dec 27, 2022
Merged

De-obfuscate random8 functions #19416

merged 2 commits into from
Dec 27, 2022

Conversation

filterpaper
Copy link
Contributor

@filterpaper filterpaper commented Dec 24, 2022 •
edited
Loading

Description

De-obfuscate random8 functions for

  • Modulo of LED count
  • Limiting saturation between 127 and 255.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@github-actions github-actions bot added the core label Dec 24, 2022
@filterpaper filterpaper changed the title [Core] De-obfuscate saturation limit function [Core] De-obfuscate random8 functions Dec 24, 2022
@filterpaper filterpaper changed the title [Core] De-obfuscate random8 functions De-obfuscate random8 functions Dec 24, 2022
@drashna drashna merged commit 7f2ac4c into qmk:develop Dec 27, 2022
@filterpaper filterpaper deleted the random_saturation_refactor branch December 27, 2022 22:51
omikronik pushed a commit to omikronik/qmk_firmware that referenced this pull request Jan 22, 2023
@filterpaper @omikronik
De-obfuscate random8 functions in RGB matrix animations (qmk#19416)
7260041
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zvecr zvecr zvecr approved these changes

@drashna drashna drashna approved these changes

Assignees
No one assigned
Labels
core
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@filterpaper @drashna @zvecr