Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Report submodule status when not valid work-tree #19474

Merged
merged 1 commit into from
Jan 2, 2023

Conversation

zvecr
Copy link
Member

@zvecr zvecr commented Jan 2, 2023

Description

[zvecr@zvecr-zen qmk_firmware-master]$ qmk doctor
...
⚠ QMK home does not appear to be a Git repository! (no .git folder)
...
Ψ Submodules are up to date.
Ψ Submodule status:
Ψ QMK is ready to go, but minor problems were found

Slightly misleading saying everything is ready...

Now the output is,

[zvecr@zvecr-zen qmk_firmware-master]$ qmk doctor
...
⚠ QMK home does not appear to be a Git repository! (no .git folder)
...
Ψ Submodule status:
☒ - lib/chibios: <<< missing or unknown >>>
☒ - lib/chibios-contrib: <<< missing or unknown >>>
☒ - lib/googletest: <<< missing or unknown >>>
☒ - lib/lufa: <<< missing or unknown >>>
☒ - lib/vusb: <<< missing or unknown >>>
☒ - lib/printf: <<< missing or unknown >>>
☒ - lib/pico-sdk: <<< missing or unknown >>>
Ψ Major problems detected, please fix these problems before proceeding.
Ψ Check out the FAQ (https://docs.qmk.fm/#/faq_build) or join the QMK Discord (https://discord.gg/Uq7gcHh) for help.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@zvecr zvecr requested a review from a team January 2, 2023 04:28
@github-actions github-actions bot added cli qmk cli command python labels Jan 2, 2023
@tzarc tzarc merged commit 3a5a4c7 into qmk:develop Jan 2, 2023
omikronik pushed a commit to omikronik/qmk_firmware that referenced this pull request Jan 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants