Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Keychron S1 ANSI Layout Touch-Up #19556

Merged
merged 4 commits into from
Jan 10, 2023
Merged

Keychron S1 ANSI Layout Touch-Up #19556

merged 4 commits into from
Jan 10, 2023

Conversation

noroadsleft
Copy link
Member

Description

Renames the layout macros for both versions to LAYOUT_75_ansi and enables Community Layout support. First in a series.

cc @lalalademaxiya1 (keyboard maintainer)

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@noroadsleft noroadsleft requested a review from a team January 10, 2023 08:39
@github-actions github-actions bot added keyboard keymap via Adds via keymap and/or updates keyboard for via support labels Jan 10, 2023
@zvecr zvecr merged commit 5e5b19c into qmk:master Jan 10, 2023
@noroadsleft noroadsleft deleted the rf/keychron_s1_ansi branch January 10, 2023 17:08
sboysel pushed a commit to sboysel/qmk_firmware that referenced this pull request Jan 17, 2023
@noroadsleft @sboysel
Keychron S1 ANSI Layout Touch-Up (qmk#19556)
52396aa
omikronik pushed a commit to omikronik/qmk_firmware that referenced this pull request Jan 22, 2023
@noroadsleft @omikronik
Keychron S1 ANSI Layout Touch-Up (qmk#19556)
bc22bcd
ideas32 pushed a commit to ideas32/qmk_firmware that referenced this pull request Jan 25, 2023
@noroadsleft @ideas32
Keychron S1 ANSI Layout Touch-Up (qmk#19556)
277adec
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zvecr zvecr zvecr approved these changes

@fauxpark fauxpark fauxpark approved these changes

Assignees
No one assigned
Labels
keyboard keymap via Adds via keymap and/or updates keyboard for via support
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@noroadsleft @fauxpark @zvecr