[Bugfix] Check QGF's bpp against display's native_bits_per_pixel #19995
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tzarc
approved these changes
Mar 12, 2023
drashna
approved these changes
Mar 16, 2023
coquizen
pushed a commit
to coquizen/qmk_firmware
that referenced
this pull request
Apr 6, 2023
efjacobson
added a commit
to efjacobson/qmk_firmware
that referenced
this pull request
Apr 8, 2023
* [Bug] Fix compiliation issue for Key Overrides (qmk#19856) * Elaborate on keyboard level encoder functionality (qmk#19839) * Fix regen script for macOS (qmk#19857) * [Keyboard] Add Quarkeys Z40 keyboard (qmk#19741) Co-authored-by: Joel Challis <git@zvecr.com> Co-authored-by: jack <0x6a73@protonmail.com> Co-authored-by: Drashna Jaelre <drashna@live.com> Co-authored-by: Ryan <fauxpark@gmail.com> * Remove unused RGBLight defines from config.h (qmk#19859) * Move Bootmagic config to data driven (qmk#19860) * Move LED indicator config to data driven (qmk#19800) * Clean up remaining rules.mk `MCU`/`BOOTLOADER`s (qmk#19778) Co-authored-by: Nick Brassel <nick@tzarc.org> * [Keyboard] Add Ciel65 (qmk#19847) Co-authored-by: Sắn <59417802+MaiTheSan@users.noreply.github.com> * Fixup durgod/dgk6x (scroll lock mis-defined as num lock) (qmk#19864) * Remove matrix size defines (qmk#19581) * Move `SOFT_SERIAL_PIN` to data driven (qmk#19863) * Fix API generation (qmk#19866) * Added via keymap for bpiphany/pegasushoof (qmk#19653) Co-authored-by: Joel Challis <git@zvecr.com> Co-authored-by: Drashna Jaelre <drashna@live.com> Co-authored-by: jack <0x6a73@protonmail.com> * Fixup for_science (qmk#19867) * Fix more build failures (qmk#19869) * Fixup pegasushoof VIA keymap (qmk#19874) * [Keyboard] Brick (qmk#19851) Co-authored-by: Joel Challis <git@zvecr.com> Co-authored-by: Jason Chestnut <jason@Jasons-MacBook-Pro.local> * [Keyboard] Add Degenpad (qmk#19812) Co-authored-by: jack <0x6a73@protonmail.com> * Align sequencer keycodes (qmk#19875) * Add caps lock indicator capabilities to M75S (qmk#19552) * [Keyboard] Add LED startup sequence to Lumberjack (qmk#19841) * Add ac001 keyboard (qmk#19868) Co-authored-by: Joel Challis <git@zvecr.com> Co-authored-by: jack <0x6a73@protonmail.com> * Add mouse layer to Kprepublic BM40HSRGB Coffee layout (qmk#19878) Co-authored-by: Fae <faenkhauser@gmail.com> * Fix functions when `NO_ACTION_TAPPING` is defined (qmk#11528) * Add `mass-compile` ability to filter by key existence. (qmk#19885) * BM40 keymap for Skewwhiffy, revamp (qmk#19876) * [Keymap] Add encoder map to degenpad default keymap (qmk#19880) * Move layouts for direct_pins boards to data driven (qmk#19872) * Move `KC_MISSION_CONTROL`/`KC_LAUNCHPAD` keycodes to core (qmk#19884) * Add license headers to all default layout keymaps (qmk#19888) * Stub changelog * Fix date * Refactor more KC_MISSION_CONTROL/KC_LAUNCHPAD usages (qmk#19891) * New keymap for GMMK2 Compact (qmk#19430) Co-authored-by: Joel Challis <git@zvecr.com> * Move backlight config to data driven, part 1 (qmk#19887) * Add some missing `#pragma once`s (qmk#19902) * Remove default and unused `BACKLIGHT_LEVELS` (qmk#19898) * Remove magic bodges from via keymaps (qmk#19890) * Fixup cannonkeys/satisfaction75 (readd `backlight.breathing_period`) (qmk#19901) * [Bug] Fix compilation error when defining QUICK_TAP_TERM_PER_KEY (qmk#19893) * Align magic keycodes (qmk#19877) * VIA Protocol 12 + fixes (qmk#19916) Co-authored-by: Wilba <wilba@wilba.tech> Co-authored-by: zvecr <git@zvecr.com> * Move QMK LUFA bootloader config to data driven (qmk#19879) * Migrate some more layouts to data driven (qmk#19889) * Reallocate SAFE_RANGE (qmk#19909) * Reallocate user/kb keycode ranges (qmk#19907) * Open Use standard magic keycodes in yandrstudio keymaps (qmk#19919) * Remove VIA specific use of `MACRO0*` (qmk#19918) * [Keyboard] Update Reviung Vendor ID (qmk#19928) * Move backlight config to data driven (qmk#19910) * Move encoder config to data driven (qmk#19923) Co-authored-by: Nick Brassel <nick@tzarc.org> * `keebio/kbo5000`: fix encoder config (qmk#19941) * Hide hex output when building uf2 (qmk#19940) * Breaking Changes 2023q1 changelog. (qmk#19945) * Add changelog for Leader Key refactor (qmk#19953) * Flag "builddefs" as core changes (qmk#19950) * [Keymap] Drashna updates for 0.20.0 (qmk#19960) * [Keyboard] remove non-existent method from ploopy documentation (qmk#19957) * Bump tj-actions/changed-files from 34 to 35 (qmk#19971) Bumps [tj-actions/changed-files](https://github.com/tj-actions/changed-files) from 34 to 35. - [Release notes](https://github.com/tj-actions/changed-files/releases) - [Changelog](https://github.com/tj-actions/changed-files/blob/main/HISTORY.md) - [Commits](tj-actions/changed-files@v34...v35) --- updated-dependencies: - dependency-name: tj-actions/changed-files dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * [Keyboard] Add FRL84 PCB. (qmk#19942) Co-authored-by: jack <0x6a73@protonmail.com> * [Keymap] sofle/keymaps/michal: rewrite (qmk#19938) * [Keyboard] Add GPAD8-2R (gpad8_2r) Macro Pad (qmk#19914) Co-authored-by: jack <0x6a73@protonmail.com> * Disable safe.directory check (qmk#19970) * Remove `all` from list of animations in `info.json` (qmk#19978) * added Polly40 keyboard (qmk#19936) Co-authored-by: Ryan <fauxpark@gmail.com> Co-authored-by: jack <0x6a73@protonmail.com> * [Keymap] Add davidrambo lulu keymap (qmk#19448) Co-authored-by: Joel Challis <git@zvecr.com> * [Keyboard] Clean up contra & move to data-driven (qmk#19973) Co-authored-by: Joel Challis <git@zvecr.com> * Check all keys have matrix positions when parsing C LAYOUT macros (qmk#19781) * Update branch names to reflect configurator's new deployment. (qmk#19999) * Initial deprecation policy documentation. (qmk#19908) * Add new keymap for Preonic rev3 (qmk#19706) * Add Support for Lilly58 r2g (qmk#19862) * Add support for lilly58 r2g by Mechboards * Add Keychron Q12 (qmk#19844) Co-authored-by: Ryan <fauxpark@gmail.com> Co-authored-by: Drashna Jaelre <drashna@live.com> * Unbreak switchplate/southpaw_65 after qmk#16277 (qmk#20015) Apparently the changes done in qmk#16277 swapped the values read from the PCA9555 expanders by mistake, which resulted in mixed up matrix columns. Fix the chip and register addresses to match the original code. * Reject VIA keys within info.json (qmk#20026) * keyboards/anavi: Add ANAVI Knobs 3 (qmk#18624) * [Keyboard] Add gummykey (qmk#19695) Co-authored-by: Drashna Jaelre <drashna@live.com> Co-authored-by: jack <0x6a73@protonmail.com> * [Docs] Discuss layout macro (qmk#19803) Co-authored-by: jack <0x6a73@protonmail.com> Co-authored-by: Ryan <fauxpark@gmail.com> * [Keyboard] Sejin EAT-1010R2 keyboard (qmk#19809) Co-authored-by: Joel Challis <git@zvecr.com> Co-authored-by: Drashna Jaelre <drashna@live.com> Co-authored-by: jack <0x6a73@protonmail.com> * Add disable git safe directory check step (qmk#20040) * [Keyboard] Add Karn Keyboard (qmk#19846) Co-authored-by: jack <0x6a73@protonmail.com> Co-authored-by: Joel Challis <git@zvecr.com> Co-authored-by: Drashna Jaelre <drashna@live.com> * [Keymap] Smooted's BM80v2 keymap (qmk#19873) * implement rgb matrix for momokai keyboards (qmk#19904) Co-authored-by: jack <0x6a73@protonmail.com> * VIA keymap for djinn (qmk#19881) * Fix processing of recently added system keycodes (qmk#20058) * [Keyboard] Teahouse Ayleen TKL (qmk#19900) Co-authored-by: Drashna Jaelre <drashna@live.com> Co-authored-by: Joel Challis <git@zvecr.com> Co-authored-by: Ryan <fauxpark@gmail.com> Co-authored-by: jack <0x6a73@protonmail.com> Co-authored-by: CMM.Studio Freather <50167286+frankBTHID@users.noreply.github.com> * EC Pro 2 PCB (qmk#19917) * EC Pro 2 firmware by Cipulot * [Docs] Add mod-tap section header (qmk#20041) * [Doc] Update PR checklist (qmk#19988) * Adding firmware for New Proto[Typist] in-stock PCBs. (qmk#19958) Co-authored-by: Less/Rikki <86894501+lesshonor@users.noreply.github.com> Co-authored-by: Drashna Jaelre <drashna@live.com> Co-authored-by: Anjheos <Anjheos.Designs@gmail.com> * `qmk info`: add warning when layout is offset (qmk#20070) * Keebio/KBO-5000 Encoder Misconfiguration Fix for qmk#20073 (qmk#20074) * Add CI builds for default and via keymaps (qmk#20071) * [Keymap] Fix the secondary keyboard not updating WPM (qmk#20069) * [Keyboard] frobiac custom boards and layout (qmk#19883) * [Keymap] add crkbd/keymaps/markstos (qmk#19010) Co-authored-by: Drashna Jaelre <drashna@live.com> Co-authored-by: Ryan <fauxpark@gmail.com> * [Keyboard] update matrix pins for Polly40 (qmk#20002) * [Keyboard] Add tsubasa keyboard (qmk#19352) Co-authored-by: Drashna Jaelre <drashna@live.com> Co-authored-by: Ryan <fauxpark@gmail.com> Co-authored-by: jack <0x6a73@protonmail.com> * [Keyboard] Add Ortho48v2 Keyboard (qmk#18889) Co-authored-by: Drashna Jaelre <drashna@live.com> * Fix incorrect matrix positions for RGB LEDs (qmk#20082) * Move macro3 to data-driven (qmk#20046) * Zeno pcb V0.0.4 update via + fileformatting (qmk#20023) Co-authored-by: Drashna Jaelre <drashna@live.com> * Caerdroia Keyboard Firmware (qmk#20036) * [Keyboard] VIA support for Pierce keyboard (qmk#20045) * [Keyboard] Add Binpad BN009 R2 3x3 macropad (qmk#19992) Co-authored-by: Less/Rikki <86894501+lesshonor@users.noreply.github.com> Co-authored-by: Drashna Jaelre <drashna@live.com> * [Keyboard] Add Spleeb default and custom firmware (qmk#19481) Co-authored-by: jack <0x6a73@protonmail.com> * Yet another adventure in trying to fit things into a 32U4 (qmk#20091) * Teleport native bugfix (changed F411CC wear levelling) (qmk#20090) * workaround for flash size issue * enable mousekeys due to requests by some users * [Keyboard] Change pierce vendor ID (qmk#20088) * Ketch LGUI/LALT key transposed on Minivan layout (qmk#20025) * [Keyboard] Add k83 (qmk#19896) * Add Chimera65 Hotswap keyboard (qmk#20038) Co-authored-by: jack <0x6a73@protonmail.com> * Allow for CI builds to run for 23 hours, instead of 6. (qmk#20094) * Allow for CI builds to run for 23 hours, instead of 6. (part deux) (qmk#20095) * [keyboard] Prevent LED flicker when connecting AnnePro 2 (qmk#19709) * Move Ferris Sweep to data-driven (qmk#20111) * Document Autocorrect callback functions (qmk#20115) * RF R1 8-9Xu PCB (qmk#20048) Co-authored-by: Tom Barnes <barnestom@me.com> Co-authored-by: Drashna Jaelre <drashna@live.com> * Update newbs_getting_started to include instructions for apple silicon (qmk#19579) Co-authored-by: Joel Challis <git@zvecr.com> * [Keyboard] Add KP60 (qmk#20096) Co-authored-by: adophoxia <100170946+adophoxia@users.noreply.github.com> Co-authored-by: jack <0x6a73@protonmail.com> * Let's use workflows to parallelise the builds. (qmk#20120) * Let's use workflows to parallelise the builds. * Nofail if files aren't present. * Formatting. * [Keyboard] New Keyboard - Sugar Glider (qmk#19933) Co-authored-by: Drashna Jaelre <drashna@live.com> Co-authored-by: Less/Rikki <86894501+lesshonor@users.noreply.github.com> Co-authored-by: jack <0x6a73@protonmail.com> * add new board: splaytoraid (qmk#20052) Co-authored-by: Less/Rikki <86894501+lesshonor@users.noreply.github.com> * [Keyboard] Add hineybush/h87_g2 (qmk#20053) Co-authored-by: Joel Challis <git@zvecr.com> Co-authored-by: Drashna Jaelre <drashna@live.com> Co-authored-by: jack <0x6a73@protonmail.com> * add tiger80 iso layout support (qmk#19975) Co-authored-by: Joel Challis <git@zvecr.com> Co-authored-by: jack <0x6a73@protonmail.com> * [Keyboard] Add Atlantis PS17 (qmk#19952) * [Doc] Add example to keyboard housekeeping and some minor fixes (qmk#19968) Co-authored-by: jack <0x6a73@protonmail.com> * Update keycodes_0.0.1_basic.hjson (qmk#20129) * Update keychron_common.c (qmk#20055) * [Keymap] Sugarglider VIA keymap enhancement (qmk#20140) * [Keyboard] Add Blueberry (qmk#19915) Co-authored-by: jack <0x6a73@protonmail.com> Co-authored-by: Ryan <fauxpark@gmail.com> * Add `qmk find` command, reuse logic for `qmk mass-compile`. (qmk#20139) * [Keyboard] 1upkeyboards/pi40 update (qmk#20066) * [keyboard] Viktus Minne (qmk#19977) Co-authored-by: Drashna Jaelre <drashna@live.com> * [Keyboard] Fix typos in readme for Lily58 R2G (qmk#20149) * [Keyboard] Add yandrstudio/transition80 (qmk#19790) Co-authored-by: Drashna Jaelre <drashna@live.com> * De-parallelise CI (qmk#20171) * De-parallelise CI No speed increase. * Update .github/workflows/ci_builds.yml * [Keymap] crkbd toinux update (qmk#19673) * [Keyboard] Add Coban Pad 3A (qmk#19634) * Add Support for LPAD (qmk#19852) Co-authored-by: jack <0x6a73@protonmail.com> Co-authored-by: Drashna Jaelre <drashna@live.com> * Fixup kbdfans/tiger80 RGB animations (qmk#20164) * Format code according to conventions (qmk#20175) * Update lpad info.json (qmk#20184) Update incorrect row and col pins, now confirmed working via manual build in QMK MSYS * [Keyboard] Add Blu vimclutch (qmk#20060) Co-authored-by: jack <0x6a73@protonmail.com> Co-authored-by: Drashna Jaelre <drashna@live.com> * [Keymap] for sharkby7e (qmk#20121) Co-authored-by: Drashna Jaelre <drashna@live.com> Co-authored-by: jack <0x6a73@protonmail.com> * [Keyboard] Add Kuro65 keyboard (qmk#20122) Co-authored-by: jack <0x6a73@protonmail.com> Co-authored-by: Less/Rikki <86894501+lesshonor@users.noreply.github.com> * [Keyboard] Add CannonKeys Bakeneko60 ISO Hotswap PCB (qmk#20130) * [Keyboard] Add pteropus keyboard (qmk#20147) Co-authored-by: Less/Rikki <86894501+lesshonor@users.noreply.github.com> Co-authored-by: Chi-Han Yang <chyang@enrichtx.com> * [Keyboard] OSAv2 (qmk#20166) * [Keyboard] Olly Orion: Disable SWD and JTAG (qmk#20169) Co-authored-by: Joel Challis <git@zvecr.com> * [Keyboard] Add tiny board 16 rgb keyboard (qmk#20158) Co-authored-by: jack <0x6a73@protonmail.com> Co-authored-by: Drashna Jaelre <drashna@live.com> * [Keyboard] update creek70 change rgb num (qmk#20196) Co-authored-by: Drashna Jaelre <drashna@live.com> * Adding Bad Wings Support (qmk#20153) * fixup: correct filename (qmk#20212) * [Keyboard] Add via support for jotanck keyboard (qmk#20146) Co-authored-by: jack <0x6a73@protonmail.com> Co-authored-by: Drashna Jaelre <drashna@live.com> * [Keyboard] Add Geistmaschine Geist (qmk#20117) Co-authored-by: jack <0x6a73@protonmail.com> * [Keyboard] Ymd09 config updates (qmk#20124) Co-authored-by: jack <0x6a73@protonmail.com> Co-authored-by: Joel Challis <git@zvecr.com> Co-authored-by: Drashna Jaelre <drashna@live.com> * [Keyboard] Fix tata80 wkl layout (qmk#20195) * [jacky_studio/piggy60] warn about incompatible PCB rev (qmk#20232) * EC 60 PCB (qmk#20050) * Add EC 60 PCB firmware * Moved from data driven row/col def to config def * Implemented proper LAYOUT_ changes * Removed unnecessary `.h` includes * Added `DISCHARGE_TIME` Addition of a `DISCHARGE_TIME` time. This is to ensure that the ghost capacitor that is the row strobed for the ADC read, is fully drained and doesn't carry charges that deviates the readings. Tested on multiple hardware and confirmed working and improving the readings, both in terms of stability and consistency for baseline noise. * Update readme.md Added missing `cipulot/`in readme example commands * Update keyboards/cipulot/ec_60/readme.md Co-authored-by: Tom Barnes <barnestom@me.com> * Removal of `info.json` lines as suggested * Update to comply with `_kb` and `_user` separation * Update keyboards/cipulot/ec_60/rules.mk Co-authored-by: Drashna Jaelre <drashna@live.com> --------- Co-authored-by: Tom Barnes <barnestom@me.com> Co-authored-by: Drashna Jaelre <drashna@live.com> * EC 23U PCB (qmk#20049) * Add EC 23U PCB firmware * Moved from data driven row/col def to config def * Implemented proper LAYOUT_ changes * Removed unnecessary `.h` includes * Updated default thresholds * Added `DISCHARGE_TIME` Addition of a `DISCHARGE_TIME` time. This is to ensure that the ghost capacitor that is the row strobed for the ADC read, is fully drained and doesn't carry charges that deviates the readings. Tested on multiple hardware and confirmed working and improving the readings, both in terms of stability and consistency for baseline noise. * Update readme.md Added missing `cipulot/` in example commands. * Removal of `info.json` lines as suggested * Update to comply with `_kb` and `_user` separation * Update rules.mk * EC ProX PCB (qmk#20047) * Add EC Pro X Addition of EC Pro X PCB series. This series comprises 2 versions: - ANSI/ISO - JIS The PCBs are different and are compatible only with their respective cases. * Moved from data driven row/col def to config def * Added project url in info.json * Implemented proper `LAYOUT_` changes * Removen unnecessary `.h` includes * Removal of `"w": 1` * Added `DISCHARGE_TIME` Addition of a `DISCHARGE_TIME` time. This is to ensure that the ghost capacitor that is the row strobed for the ADC read, is fully drained and doesn't carry charges that deviates the readings. Tested on multiple hardware and confirmed working and improving the readings, both in terms of stability and consistency for baseline noise. * Fixed keymap error in ordering * Update keyboards/cipulot/ec_prox/jis/readme.md Co-authored-by: Tom Barnes <barnestom@me.com> * Update keyboards/cipulot/ec_prox/ansi_iso/readme.md Co-authored-by: Tom Barnes <barnestom@me.com> * Removal of `info.json` lines as suggested * Update to comply with `_kb` and `_user` separation * Update keyboards/cipulot/ec_prox/jis/rules.mk Co-authored-by: Drashna Jaelre <drashna@live.com> * Update rules.mk --------- Co-authored-by: Tom Barnes <barnestom@me.com> Co-authored-by: Drashna Jaelre <drashna@live.com> * [keyboard] Correcting info.JSON for Viktus Minne (qmk#20244) * [Keyboard]Viktus Minne - Topre variant (qmk#20044) * Adding the Viktus Minne topre pcb variant * Update keyboards/viktus/minne_topre/readme.md Co-authored-by: Drashna Jaelre <drashna@live.com> * Update rules.mk * Moving layouts from *.h to info.json * Removing minne_topre.h and updating others * fixing *.c's * Switch from int to void for ec_init * Update info.json * Update info.json --------- Co-authored-by: Drashna Jaelre <drashna@live.com> * Add CannonKeys Bakeneko65 Hotswap ISO PCB to QMK (qmk#20131) * Add CannonKeys Bakeneko65 Hotswap ISO PCB to QMK * Add 65_iso_blocker community layout support * Bump actions/stale from 7 to 8 (qmk#20246) Bumps [actions/stale](https://github.com/actions/stale) from 7 to 8. - [Release notes](https://github.com/actions/stale/releases) - [Changelog](https://github.com/actions/stale/blob/main/CHANGELOG.md) - [Commits](actions/stale@v7...v8) --- updated-dependencies: - dependency-name: actions/stale dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * [Documentation] Pointing device minor rewrite (qmk#19641) * Check for multiple matrix positions assigned to same key (qmk#20039) * [chore] keyboards/tzarc: Alignment with clang-format. (qmk#20265) * [keyboard] Correcting info.JSON for OSAv2 (qmk#20247) * Remove invalid characters (qmk#20277) * Add new keyboard Tightwriter (qmk#20136) Co-authored-by: Less/Rikki <86894501+lesshonor@users.noreply.github.com> * I have zero involvement with this keyboard... (qmk#20287) * CI Builds: master/develop, default/via, twice daily. (qmk#20283) * Fix some invalid layout macros (qmk#20256) * Add step summary output to CI builds, with failure logs. (qmk#20288) * Fixup CI command failures. (qmk#20291) * Add ability for `qmk mass-compile` to build specified targets (qmk#20294) * Minify content published to API (qmk#20285) * [Keyboard] Add alhenkb macropad (qmk#20123) * [Keyboard] Add Plaque80 (qmk#20240) Co-authored-by: Drashna Jaelre <drashna@live.com> Co-authored-by: Joel Challis <git@zvecr.com> * [Keyboard] Add Steezy60 Rev B (qmk#19688) Co-authored-by: Drashna Jaelre <drashna@live.com> Co-authored-by: jack <0x6a73@protonmail.com> Co-authored-by: Ryan <fauxpark@gmail.com> Co-authored-by: Joel Challis <git@zvecr.com> Co-authored-by: Nick Brassel <nick@tzarc.org> Co-authored-by: Sergey Vlasov <sigprof@gmail.com> Co-authored-by: Wolf Van Herreweghe <wolfvh@getupgamesofficial.com> Co-authored-by: yiancar <yiancar@gmail.com> Co-authored-by: Dasky <32983009+daskygit@users.noreply.github.com> Co-authored-by: adophoxia <100170946+adophoxia@users.noreply.github.com> Co-authored-by: Jue Liu <youturn@Jues-MacBook-Pro.local> Co-authored-by: James Young <18669334+noroadsleft@users.noreply.github.com> Co-authored-by: Shandon Anderson <shandon@shandon.codes> Co-authored-by: jack <0x6A73@pm.me> Co-authored-by: jason <jrucker2004@gmail.com> Co-authored-by: Less/Rikki <86894501+lesshonor@users.noreply.github.com> * [Keyboard] Add KeyDeck8 (qmk#20107) Co-authored-by: jack <0x6a73@protonmail.com> Co-authored-by: Drashna Jaelre <drashna@live.com> * Revert to hex output for kint41 (qmk#20295) * [Keyboard update] Fix json error (qmk#20299) * [QP] Fix up delta frame boundaries (qmk#20296) * [Keymap] Add md40 ckrbd keymap (qmk#19931) Co-authored-by: jack <0x6a73@protonmail.com> Co-authored-by: Drashna Jaelre <drashna@live.com> * [Keymap] Ferris - Add split USB detection directive (qmk#20213) * [Keyboard] Add GMMK Numpad (qmk#20067) Co-authored-by: Sergey Vlasov <sigprof@gmail.com> Co-authored-by: Drashna Jaelre <drashna@live.com> * [Keymap] update arkag keymap, add hitbox layout (qmk#20271) Co-authored-by: Alex Kagno <alex@turncommerce.com> * Add angle65 (qmk#19986) Co-authored-by: jack <0x6a73@protonmail.com> Co-authored-by: Ryan <fauxpark@gmail.com> * Enable encoder mapping in VIA for Keebio KBO-5000 (qmk#20272) * [Keyboard] Add Mechlovin9 rev.3 (qmk#20119) Co-authored-by: jack <0x6a73@protonmail.com> * [Keyboard] Add Royal Kludge RKG-68 (qmk#20138) * [Keyboard] Add pocketpad (qmk#20229) Co-authored-by: jack <0x6a73@protonmail.com> * [Keyboard] Add Erdnuss 65 (qmk#20202) Co-authored-by: jack <0x6a73@protonmail.com> * [Keymap] Add dancxjo hotdox76v2 keymap (qmk#20016) * Add support for Geistmaschine Macropod (qmk#20116) Co-authored-by: Pablo Martínez <58857054+elpekenin@users.noreply.github.com> * [Keyboard] Add nullbits SNAP keyboard (qmk#18916) Co-authored-by: Ryan <fauxpark@gmail.com> * Add user horrortroll in userspace (qmk#19769) * Add recommendations for VSCode intellisense (qmk#19402) * ISO-DE Keymap for Dactyl Manuform 6x7 (qmk#19441) * [Bugfix] Check QGF's bpp against display's native_bits_per_pixel (qmk#19995) * Adding my keymap (qmk#19964) * Update WT60-H1, WT60-H3 layouts (qmk#20114) * onekey: Fix console output on AVR (qmk#19930) * New layer added to giabalanai keyboard (qmk#20118) * Adding Unextended Standard PCB (qmk#20190) Co-authored-by: Drashna Jaelre <drashna@live.com> Co-authored-by: 4pplet <4pplet@protonmail.com> Co-authored-by: 4pplet <stefan.ess@gmail.com> * Refactor Galatea (qmk#20011) * Add an alternate layout definition for Keyboardio Model 01 (qmk#20245) * Suggest `qmk list-keyboards` when testing build environment (qmk#19471) Co-authored-by: Joel Challis <git@zvecr.com> * Data-driven updates to overnumpad controller keyboards (qmk#20259) * PR checklist: keyboard updates must go to `develop` (qmk#20323) * Modify default encoder mappings, change PID, enable mousekeys (qmk#20329) * Adding Oceanographer to QMK. (qmk#20324) * Personal keymaps for crkbd and kyria (qmk#20009) * Add Ripple TKL Hotswap Firmware (qmk#20302) Co-authored-by: Less/Rikki <86894501+lesshonor@users.noreply.github.com> * Add Ripple TKL Keyboard firmware (qmk#20301) * [keyboard] Adding OSAv2 numpad (qmk#20209) Co-authored-by: jack <0x6a73@protonmail.com> * Use table for debounce algorithm description (qmk#20322) * Manibus keyboard, update pinout (qmk#20309) * Add debounce time description (qmk#20333) * Resolve keyboard names for `qmk mass-compile`. (qmk#20335) * [Keyboard] Add Budgy and Crowboard Keyboards (qmk#19141) Co-authored-by: jack <0x6a73@protonmail.com> Co-authored-by: Ryan <fauxpark@gmail.com> Co-authored-by: Drashna Jaelre <drashna@live.com> * Add Junco Keyboard (qmk#19516) * [Keyboard] Add lxxt (qmk#19935) Co-authored-by: Neil Brian Ramirez <nightlykeyboards@gmail.com> Co-authored-by: Neil Brian Ramirez <nightlyboards@gmail.com> * Add Iron160 I160-S and I160-H PCBs support (qmk#20077) Co-authored-by: Ryan <fauxpark@gmail.com> Co-authored-by: jack <0x6a73@protonmail.com> * Add peterfalken userspace & keymaps (qmk#19897) Co-authored-by: Peter.Falken <luis.garcia@bitjester.com> * Bump peter-evans/create-pull-request from 4 to 5 (qmk#20346) Bumps [peter-evans/create-pull-request](https://github.com/peter-evans/create-pull-request) from 4 to 5. - [Release notes](https://github.com/peter-evans/create-pull-request/releases) - [Commits](peter-evans/create-pull-request@v4...v5) --- updated-dependencies: - dependency-name: peter-evans/create-pull-request dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * [Keyboard] Add Keychron Q11 (qmk#20125) Co-authored-by: Drashna Jaelre <drashna@live.com> Co-authored-by: adophoxia <100170946+adophoxia@users.noreply.github.com> Co-authored-by: Ryan <fauxpark@gmail.com> * Move a_dux to data-driven (qmk#20043) * Add Discord webhook at end of each CI run. (qmk#20355) * Fixup CI build variables. (qmk#20357) * Avoid generating empty ENCODER_RESOLUTION (qmk#20179) * Convertors documentation: Removed duplicate table entry (qmk#20360) * [Keyboard] Add audio support to Adafruit MacroPad RP2040 (qmk#20353) --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: Drashna Jaelre <drashna@live.com> Co-authored-by: jack <0x6A73@pm.me> Co-authored-by: QMK Bot <hello@qmk.fm> Co-authored-by: Joel Challis <git@zvecr.com> Co-authored-by: TommyZ <60314626+tommyamoszhao@users.noreply.github.com> Co-authored-by: jack <0x6a73@protonmail.com> Co-authored-by: Ryan <fauxpark@gmail.com> Co-authored-by: Nick Brassel <nick@tzarc.org> Co-authored-by: chickenman112 <76463635+chickenman112@users.noreply.github.com> Co-authored-by: Sắn <59417802+MaiTheSan@users.noreply.github.com> Co-authored-by: Emrik Östling <emrik.ostling@gmail.com> Co-authored-by: pauper <125139481+pauperboards@users.noreply.github.com> Co-authored-by: Jason Chestnut <jason@Jasons-MacBook-Pro.local> Co-authored-by: ThePanduuh <feojoe2@gmail.com> Co-authored-by: Álvaro A. Volpato <alvaro.augusto.volpato@gmail.com> Co-authored-by: Paul James <paul@peej.co.uk> Co-authored-by: jonylee@hfd <108282809+jonylee1986@users.noreply.github.com> Co-authored-by: CoffeeIsLife <36961653+CoffeeIsLife87@users.noreply.github.com> Co-authored-by: Fae <faenkhauser@gmail.com> Co-authored-by: Kenny Hung (he) <kennysubs+github@outlook.com> Co-authored-by: Eugenio Pastoral <46639608+achrovisual@users.noreply.github.com> Co-authored-by: precondition <57645186+precondition@users.noreply.github.com> Co-authored-by: Wilba <wilba@wilba.tech> Co-authored-by: azhizhinov <azhizhinov@mail.ru> Co-authored-by: Drashna Jaelre <drashna@drashna.net> Co-authored-by: Shawn Meier <shawn.meier@gmail.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: studiokestra <74369928+studiokestra@users.noreply.github.com> Co-authored-by: Michal S <mchal_@tuta.io> Co-authored-by: gkeyboard <giggox_man@hotmail.com> Co-authored-by: Paul Enrico N. Viola <pviola@gbox.adnu.edu.ph> Co-authored-by: David Rambo <davidrambo@mailfence.com> Co-authored-by: Albert Y <76888457+filterpaper@users.noreply.github.com> Co-authored-by: Guillermo Aguirre <guillermoaguirre1@gmail.com> Co-authored-by: Elliot Powell <32494740+e11i0t23@users.noreply.github.com> Co-authored-by: lalalademaxiya1 <66767061+lalalademaxiya1@users.noreply.github.com> Co-authored-by: Sergey Vlasov <sigprof@gmail.com> Co-authored-by: Leon Anavi <leon@anavi.org> Co-authored-by: gumorr <102767971+gumorr@users.noreply.github.com> Co-authored-by: souvlakeeb <109096368+souvlakeeb@users.noreply.github.com> Co-authored-by: Dmitry Nosachev <quartz64@gmail.com> Co-authored-by: Robert Mills <robcmills@gmail.com> Co-authored-by: Olivia <125531297+Smooted@users.noreply.github.com> Co-authored-by: peepeetee <43021794+peepeetee@users.noreply.github.com> Co-authored-by: Niles Tanner <nilestanner@users.noreply.github.com> Co-authored-by: Freather <72902384+CMMS-Freather@users.noreply.github.com> Co-authored-by: CMM.Studio Freather <50167286+frankBTHID@users.noreply.github.com> Co-authored-by: Cipulot <40441626+Cipulot@users.noreply.github.com> Co-authored-by: Anjheos <69339386+Anjheos@users.noreply.github.com> Co-authored-by: Less/Rikki <86894501+lesshonor@users.noreply.github.com> Co-authored-by: Anjheos <Anjheos.Designs@gmail.com> Co-authored-by: Flame Soulis <firecatdan@gmail.com> Co-authored-by: Budiman Jojo <budimanjojo@gmail.com> Co-authored-by: frobiac <frobiac@gmail.com> Co-authored-by: Mark Stosberg <mark@rideamigos.com> Co-authored-by: Kuribayashi Atsushi <kuribayashi.atsushi@g.sp.m.is.nagoya-u.ac.jp> Co-authored-by: Andrew Kannan <andrew.kannan@gmail.com> Co-authored-by: Danny <nooges@users.noreply.github.com> Co-authored-by: paulgali <paulgali@live.co.uk> Co-authored-by: Vino Rodrigues <366673+vinorodrigues@users.noreply.github.com> Co-authored-by: Christopher Hoage <iam@chrishoage.com> Co-authored-by: ebastler <moritz.plattner@gmx.net> Co-authored-by: Dan White <BlueTufa@users.noreply.github.com> Co-authored-by: Andrew Kannan <andrew.kannan@klaviyo.com> Co-authored-by: Darkhan <darkhanu@gmail.com> Co-authored-by: Tom Barnes <barnestom@me.com> Co-authored-by: Sophie Machen <87283102+sophonaroap@users.noreply.github.com> Co-authored-by: d-floe <31980883+d-floe@users.noreply.github.com> Co-authored-by: adophoxia <100170946+adophoxia@users.noreply.github.com> Co-authored-by: Kyle McCreery <mccreery.kyle@gmail.com> Co-authored-by: Conor Burns <mail@conor-burns.com> Co-authored-by: Josh Hinnebusch <joshhinnebusch@gmail.com> Co-authored-by: dztech <moyi4681@users.noreply.github.com> Co-authored-by: mjbogusz <mjbogusz@users.noreply.github.com> Co-authored-by: しぐれ <23041178+ForsakenRei@users.noreply.github.com> Co-authored-by: ToffeeStudio <116937564+ToffeeStudio@users.noreply.github.com> Co-authored-by: ziptyze <mwcordier@gmail.com> Co-authored-by: blindassassin111 <38090555+blindassassin111@users.noreply.github.com> Co-authored-by: Fabien <vaga@users.noreply.github.com> Co-authored-by: JX <572673807@qq.com> Co-authored-by: toinux <toinux@gmail.com> Co-authored-by: Dam Vu Duy <RyanDam@users.noreply.github.com> Co-authored-by: Laneware <68452738+Laneware@users.noreply.github.com> Co-authored-by: Agent Blu, 006 <blu006@ucr.edu> Co-authored-by: Sid Quinsaat <37809009+sharkby7e@users.noreply.github.com> Co-authored-by: Tobias Minn <tobias.minn@gmail.com> Co-authored-by: hulahermit <36484223+hulahermit@users.noreply.github.com> Co-authored-by: Chi-Han Yang <chyang@enrichtx.com> Co-authored-by: mechlovin <57231893+mechlovin@users.noreply.github.com> Co-authored-by: Ning <vipning@qq.com> Co-authored-by: spbgzh <72414103+spbgzh@users.noreply.github.com> Co-authored-by: Jason Hazel <me@jasonhazel.com> Co-authored-by: jotix <69703151+jotix@users.noreply.github.com> Co-authored-by: SHVD3x <103226441+SHVD3x@users.noreply.github.com> Co-authored-by: Pablo Martínez <58857054+elpekenin@users.noreply.github.com> Co-authored-by: takashicompany <t@kashi.company> Co-authored-by: Alejandro Chacón <alhenx@gmail.com> Co-authored-by: 4pplet <mail@4pplet.com> Co-authored-by: Wolf Van Herreweghe <wolfvh@getupgamesofficial.com> Co-authored-by: yiancar <yiancar@gmail.com> Co-authored-by: Dasky <32983009+daskygit@users.noreply.github.com> Co-authored-by: Jue Liu <youturn@Jues-MacBook-Pro.local> Co-authored-by: James Young <18669334+noroadsleft@users.noreply.github.com> Co-authored-by: Shandon Anderson <shandon@shandon.codes> Co-authored-by: jason <jrucker2004@gmail.com> Co-authored-by: Maverick0197 <123402474+Maverick0197@users.noreply.github.com> Co-authored-by: Shane Dowling <shane@shanedowling.com> Co-authored-by: Cameron Varley <cam.avarley@gmail.com> Co-authored-by: Alexander Kagno <ar@kagno.org> Co-authored-by: Alex Kagno <alex@turncommerce.com> Co-authored-by: Vertex-kb <102476474+Vertex-kb@users.noreply.github.com> Co-authored-by: Raphael Mangubat <16827478+raphkris@users.noreply.github.com> Co-authored-by: Thomaz Peres <58439854+Thomaz-Peres@users.noreply.github.com> Co-authored-by: butterkeebs <124812866+butterkeebs@users.noreply.github.com> Co-authored-by: cttt <57359810+ctt-t@users.noreply.github.com> Co-authored-by: Travis Reed <dancxjo@users.noreply.github.com> Co-authored-by: Jay Greco <jayv.greco@gmail.com> Co-authored-by: HorrorTroll <sonicvipduc@gmail.com> Co-authored-by: Woongbin Kang <wbk@outlook.com> Co-authored-by: andi4000 <3588439+andi4000@users.noreply.github.com> Co-authored-by: Torsten Schneider <83730717+to-schneider@users.noreply.github.com> Co-authored-by: 3araht <69518343+3araht@users.noreply.github.com> Co-authored-by: 4pplet <4pplet@protonmail.com> Co-authored-by: 4pplet <stefan.ess@gmail.com> Co-authored-by: Lisa Ugray <lisa.ugray@gmail.com> Co-authored-by: Julius Degesys <Julius.Degesys@gmail.com> Co-authored-by: Purdea Andrei <andrei@purdea.ro> Co-authored-by: Cameron Larsen <44081018+cameronjlarsen@users.noreply.github.com> Co-authored-by: Alex Paulescu <alex.paulescu@gmail.com> Co-authored-by: Alex Miller <39163867+doesntfazer@users.noreply.github.com> Co-authored-by: Dane Skalski <daneski13@gmail.com> Co-authored-by: DeskDaily <65656486+DeskDaily@users.noreply.github.com> Co-authored-by: Neil Brian Ramirez <nightlykeyboards@gmail.com> Co-authored-by: Neil Brian Ramirez <nightlyboards@gmail.com> Co-authored-by: Luis Garcia <luis@bitjester.com> Co-authored-by: Peter.Falken <luis.garcia@bitjester.com> Co-authored-by: Duncan Sutherland <75046609+dunk2k@users.noreply.github.com>
struckmb
pushed a commit
to struckmb/qmk_firmware
that referenced
this pull request
Apr 10, 2023
SjB
added a commit
to SjB/qmk_firmware
that referenced
this pull request
Apr 14, 2023
* master: (53 commits) Add debounce time description (qmk#20333) Manibus keyboard, update pinout (qmk#20309) Use table for debounce algorithm description (qmk#20322) [keyboard] Adding OSAv2 numpad (qmk#20209) Add Ripple TKL Keyboard firmware (qmk#20301) Add Ripple TKL Hotswap Firmware (qmk#20302) Personal keymaps for crkbd and kyria (qmk#20009) Adding Oceanographer to QMK. (qmk#20324) Modify default encoder mappings, change PID, enable mousekeys (qmk#20329) PR checklist: keyboard updates must go to `develop` (qmk#20323) Data-driven updates to overnumpad controller keyboards (qmk#20259) Suggest `qmk list-keyboards` when testing build environment (qmk#19471) Add an alternate layout definition for Keyboardio Model 01 (qmk#20245) Refactor Galatea (qmk#20011) Adding Unextended Standard PCB (qmk#20190) New layer added to giabalanai keyboard (qmk#20118) onekey: Fix console output on AVR (qmk#19930) Update WT60-H1, WT60-H3 layouts (qmk#20114) Adding my keymap (qmk#19964) [Bugfix] Check QGF's bpp against display's native_bits_per_pixel (qmk#19995) ...
rodrigob
pushed a commit
to rodrigob/qmk_firmware
that referenced
this pull request
Apr 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As already commented on 19994, there's an edge case
Scenario: Having a 16/24bpp QGF, and ofc, native color support enabled
Problem: On multi-device firmwares, you could also try and draw it on another display which doesn't use such format.
> Tested on ILI9163 and ILI9341 (RGB565) it indeed draws garbage with an RGB888 image
Thus i've added a small guard clause comparing the sizes before trying to draw. I guess the driver could store the ID of the data format (we can get bpp from it) for this kind of checks to be more useful.
Note: Im assuming the
<= 8bpp formats are being converted tohsv888by theqp_internal_decode_palettefunction (didn't understand its code much), and then thepalette_convertfunction on each driver can take care of converting into the format that each display wants. Support for such a conversion could also be added for these 2 new formats, to allow any target display to draw them instead of "locking" 16/24bpp to only be drawable on 16/24bpp displays.Note2: Perhaps we should store info about the format, not just bpp on the drivers (ie this code would still allow a RGB565 drawing any other format which is also 16bpp)
Types of Changes
Issues Fixed or Closed by This PR
Checklist