-
-
Notifications
You must be signed in to change notification settings - Fork 39.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Driver] 3-color e-Ink on Quantum Painter #20032
Draft
elpekenin
wants to merge
6
commits into
qmk:develop
Choose a base branch
from
elpekenin:feature/qp-eink
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Draft as it needs |
elpekenin
commented
Mar 6, 2023
elpekenin
commented
Mar 6, 2023
Comment on lines
+144
to
+147
if (!ret) { | ||
qp_dprintf("qp_eink_panel_pixdata: something went wrong, quitting\n"); | ||
return false; | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe the function shouldn't have this early stopping and just keep running anyway, and let return ret;
give the false
value 🤔
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Just a convenience wrapper around 2x 1bpp surfaces, since there are some yellow (and perhaps other colors) ones, the driver holds the HSV target color, so that
palette_convert
can map any input color to the closest of the three.About similar hardware:
So far tested with IL91874 #19437
Another Discord user is testing SSD1680 #19451 -- However, im unsure if this display could reduce its RAM usage and/or get better performance with a partial update driver, since it supports such feature.
⬆️ Both those PRs need updates. The docs +
painter/rules.mk
changes will be contained on themSince these displays can get damaged if drawn too often, code uses a flag to control whether we can do it:
false
upon flushing +defer_exec
to schedule getting it back totrue
false
at startup, preventing double-flushing if the keyboard is rebooted and it performs drawing at init (or soon enough) -- will happen as soon as Quantum Painter QoL enhancements -- auto-poweroff, auto-flush, buffer sizing #20013 landsTypes of Changes
Issues Fixed or Closed by This PR
Checklist