adding haven80 hotswap & haven65 pcbs firmware to qmk #20081

CMMS-Freather · 2023-03-10T09:58:38Z

adds following keyboard firmware to qmk repo
haven80 hotswap
haven65 solder
haven65 hotswap

updated fuji65 via keymap
updated teahouse/ayleen via keymap and config.h to achieve same indicator only control feature in via

Description

Types of Changes

Issues Fixed or Closed by This PR

Checklist

My code follows the code style of this project: C, Python
I have read the PR Checklist document and have made the appropriate changes.
My change requires a change to the documentation.
I have updated the documentation accordingly.
I have read the CONTRIBUTING document.
I have added tests to cover my changes.
I have tested the changes and verified that they work and don't break anything (as well as I can manage).

Co-authored-by: Drashna Jaelre <drashna@live.com>

defined specific rgb animations want to enable

Co-authored-by: Joel Challis <git@zvecr.com>

Co-authored-by: Ryan <fauxpark@gmail.com>

add support for fuji75 solder fuji75 hotswap and kp60 hotswap pcb

added config.h for firmware compilation

Co-authored-by: Drashna Jaelre <drashna@live.com>

waffle87

Not sure why the entire teahouse/ayleen directory is being added again, after #19900 was merged?

keyboards/ah/haven80_hotswap/config.h

keyboards/ah/haven80_hotswap/info.json

keyboards/ah/haven80_hotswap/keymaps/default/keymap.c

keyboards/ah/haven80_hotswap/keymaps/vial/rules.mk

keyboards/ah/haven80_hotswap/readme.md

Co-authored-by: jack <0x6a73@protonmail.com>

CMMS-Freather · 2023-03-11T00:59:05Z

Not sure why the entire teahouse/ayleen directory is being added again, after #19900 was merged?

i am not too sure why either. While making the pr, i only selected files that will be used in the havne80_hotswap.

adds haven65 pcbs to the repo includes haven65 solder haven65 hotswap

This reverts commit f75dd95.

This reverts commit 3921f96.

zvecr · 2023-03-15T15:29:36Z

i am not too sure why either. While making the pr, i only selected files that will be used in the havne80_hotswap.

Probably because you have workflow issues, most likely due to the reused the branch from a previous PR without fixing the history first.

This will have to be resolved your end before the PR can be accepted.

keyboards/ah/haven65_hotswap/config.h

@zvecr

as @zvecr suggested, changing all the config.h #define eeconfig_user_data_size 4 to #define eeconfig_kb_data_size 4 alongside, updating Ayleen corresponding file to allow the same indicator only control feature in via

CMMS-Freather · 2023-03-16T00:24:07Z

i am not too sure why either. While making the pr, i only selected files that will be used in the havne80_hotswap.

Probably because you have workflow issues, most likely due to the reused the branch from a previous PR without fixing the history first.

This will have to be resolved your end before the PR can be accepted.

this has been resolved as I had to update some new files for the ayleen to allow the same indicator only control in via. Newly commited files for ayleen will be included

zvecr

Use of EECONFIG_KB_DATA_SIZE at the keymap level is just as bad as eeconfig_update_kb_datablock at the keyboard level.
- My preference would be EECONFIG_USER_DATA_SIZE defined at a keymap level config.h and eeconfig_update_user_datablock calls
keyboards/teahouse/ayleen isnt a set of updates to existing files, as they exist already.
- The Files Changed tab needs to correctly reflect this and trying to re-add them is wrong

move eeconfig related code to keymap level as suggested

CMMS-Freather and others added 30 commits January 6, 2022 15:59

add fuji65 keyboard

4d04e40

Update keyboards/cmm_studio/fuji65/rules.mk

2f2637e

Co-authored-by: Drashna Jaelre <drashna@live.com>

Update keyboards/cmm_studio/fuji65/rules.mk

f3ee303

Co-authored-by: Drashna Jaelre <drashna@live.com>

Update keyboards/cmm_studio/fuji65/rules.mk

5df4e8e

Co-authored-by: Drashna Jaelre <drashna@live.com>

Update config.h

4c97dd1

defined specific rgb animations want to enable

Update keyboards/cmm_studio/fuji65/keymaps/via/rules.mk

561f4b6

Co-authored-by: Joel Challis <git@zvecr.com>

Update keyboards/cmm_studio/fuji65/readme.md

3a0f115

Co-authored-by: Ryan <fauxpark@gmail.com>

Update keyboards/cmm_studio/fuji65/rules.mk

89d7ee4

Co-authored-by: Ryan <fauxpark@gmail.com>

Update keyboards/cmm_studio/fuji65/config.h

654a13d

add support

4182367

add support for fuji75 solder fuji75 hotswap and kp60 hotswap pcb

Merge branch 'master' of https://github.com/CMMS-Freather/qmk_firmware-1

5e25609

Update readme.md

17558fc

Update info.json

b6ab831

Update readme.md

fd67b08

Update readme.md

a58b0c4

Create config.h

89a9545

added config.h for firmware compilation

Update keyboards/cmm_studio/fuji75_hotswap/readme.md

ab289f4

Co-authored-by: Drashna Jaelre <drashna@live.com>

Update keyboards/cmm_studio/fuji75_hotswap/config.h

8fa2ac3

Co-authored-by: Drashna Jaelre <drashna@live.com>

Update keyboards/keyspensory/kp60/config.h

a0192e4

Co-authored-by: Drashna Jaelre <drashna@live.com>

Update keyboards/cmm_studio/fuji75_solder/config.h

dbf095e

Co-authored-by: Drashna Jaelre <drashna@live.com>

Update fuji75_hotswap.h

84b5602

Update keymap.c

3e01486

Update fuji75_hotswap.h

67f2c6d

Update fuji75_solder.h

4ad22e7

Update keymap.c

bd33493

Update fuji75_solder.c

a81af5d

Update config.h

ea2621c

Update keymap.c

861889c

Update keymap.c

9613e43

Update keymap.c

3dbf5c6

github-actions bot added keymap via Adds via keymap and/or updates keyboard for via support labels Mar 10, 2023

waffle87 requested changes Mar 10, 2023

View reviewed changes

CMMS-Freather and others added 5 commits March 10, 2023 16:53

Update keyboards/ah/haven80_hotswap/readme.md

8e66be2

Co-authored-by: jack <0x6a73@protonmail.com>

Update keyboards/ah/haven80_hotswap/info.json

8f4dd3b

Co-authored-by: jack <0x6a73@protonmail.com>

Update keyboards/ah/haven80_hotswap/keymaps/default/keymap.c

fe88678

Co-authored-by: jack <0x6a73@protonmail.com>

Update keyboards/ah/haven80_hotswap/keymaps/vial/rules.mk

fd67cdb

Co-authored-by: jack <0x6a73@protonmail.com>

Update readme.md

15fa4d0

CMMS-Freather requested a review from waffle87 March 11, 2023 00:59

CMMS-Freather changed the title ~~adding haven80 hotswap pcb firmware to qmk~~ adding haven80 hotswap & haven65 pcbs firmware to qmk Mar 12, 2023

frankBTHID added 6 commits March 11, 2023 19:31

adds haven65 pcbs to the repo

f75dd95

adds haven65 pcbs to the repo includes haven65 solder haven65 hotswap

Revert "adds haven65 pcbs to the repo"

3921f96

This reverts commit f75dd95.

Revert "Revert "adds haven65 pcbs to the repo""

bbe11a1

This reverts commit 3921f96.

deleted vial keymaps and via_blink keymap

e74d8d3

updated keymap

cd042aa

udpated keymap

1a34e93

zvecr requested changes Mar 15, 2023

View reviewed changes

keyboards/ah/haven65_hotswap/config.h Outdated Show resolved Hide resolved

update config and corresponding section in keymap.c

5bc8523

as @zvecr suggested, changing all the config.h #define eeconfig_user_data_size 4 to #define eeconfig_kb_data_size 4 alongside, updating Ayleen corresponding file to allow the same indicator only control feature in via

Update keymap.c

f32ec07

CMMS-Freather requested review from zvecr and waffle87 and removed request for waffle87 and zvecr March 16, 2023 00:34

zvecr requested changes Mar 16, 2023

View reviewed changes

move changes to keymap level

683b168

move eeconfig related code to keymap level as suggested

CMMS-Freather marked this pull request as draft March 16, 2023 01:46

CMMS-Freather closed this Mar 16, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

adding haven80 hotswap & haven65 pcbs firmware to qmk #20081

adding haven80 hotswap & haven65 pcbs firmware to qmk #20081

CMMS-Freather commented Mar 10, 2023 •

edited

Loading

waffle87 left a comment

CMMS-Freather commented Mar 11, 2023

zvecr commented Mar 15, 2023

CMMS-Freather commented Mar 16, 2023

zvecr left a comment •

edited

Loading

adding haven80 hotswap & haven65 pcbs firmware to qmk #20081

adding haven80 hotswap & haven65 pcbs firmware to qmk #20081

Conversation

CMMS-Freather commented Mar 10, 2023 • edited Loading

Description

Types of Changes

Issues Fixed or Closed by This PR

Checklist

waffle87 left a comment

Choose a reason for hiding this comment

CMMS-Freather commented Mar 11, 2023

zvecr commented Mar 15, 2023

CMMS-Freather commented Mar 16, 2023

zvecr left a comment • edited Loading

Choose a reason for hiding this comment

CMMS-Freather commented Mar 10, 2023 •

edited

Loading

zvecr left a comment •

edited

Loading