Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Odin V2 product ID #20103

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Fix Odin V2 product ID #20103

wants to merge 1 commit into from

Conversation

wilba
Copy link
Contributor

@wilba wilba commented Mar 12, 2023

Kbdfans Odin V2 has the same product ID as Odin Soldered, changing it to something unique.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@wilba wilba mentioned this pull request Mar 12, 2023
7 tasks
@wilba
Copy link
Contributor Author

wilba commented Mar 13, 2023

@moyi4681 can you review this too please

@wilba
Copy link
Contributor Author

wilba commented Mar 14, 2023

the-via/keyboards#1755 relevant

@tzarc
Copy link
Member

tzarc commented Mar 14, 2023

After discussion on Discord, given that the "V2" board is identical to "RGB", the proposed way to handle this is:

@silvinor
Copy link
Contributor

I think that this PR should progress as posted. There is most certainly a third PCB on this. Electrically equivalent to the "soldered" variant, but hotswap in the V2 (and not per-key RGB) ... as per the vendors own webpage on this product:

image

That they ship this product with the f/w of the "soldered" firmware is less relevant since that causes confusion with users when they attempt to customise with QMK (or VIA for that matter).

This is a (mostly) community driven project .. so it would make sense that the users make their own experience easier ... that some individuals in the vendor are less informed on firmware should not impede us from leverage this great platform.

@tzarc
Copy link
Member

tzarc commented Apr 3, 2023

Putting this on hold until we get an indication of the situation from @moyi4681.

@tzarc tzarc added the on hold label Apr 3, 2023
@tzarc tzarc marked this pull request as draft April 3, 2023 05:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants