-
-
Notifications
You must be signed in to change notification settings - Fork 40.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Odin V2 product ID #20103
base: master
Are you sure you want to change the base?
Fix Odin V2 product ID #20103
Conversation
@moyi4681 can you review this too please |
the-via/keyboards#1755 relevant |
After discussion on Discord, given that the "V2" board is identical to "RGB", the proposed way to handle this is:
|
I think that this PR should progress as posted. There is most certainly a third PCB on this. Electrically equivalent to the "soldered" variant, but hotswap in the V2 (and not per-key RGB) ... as per the vendors own webpage on this product: That they ship this product with the f/w of the "soldered" firmware is less relevant since that causes confusion with users when they attempt to customise with QMK (or VIA for that matter). This is a (mostly) community driven project .. so it would make sense that the users make their own experience easier ... that some individuals in the vendor are less informed on firmware should not impede us from leverage this great platform. |
Putting this |
Kbdfans Odin V2 has the same product ID as Odin Soldered, changing it to something unique.
Types of Changes
Checklist