-
-
Notifications
You must be signed in to change notification settings - Fork 39.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Keymap] add userspace folder, adding and updating keymaps. #20437
Conversation
Opening and closing new PRs isn't going to help this one as fragmentation will occur if this goes on. I suggest you stick to your previous PR and work from there. |
Sorry, If I've done something wrong. I'm a lone amateur developer figuring things out as I go. I've deleted the branch the previous PR was based off of. This branch has my updated code with newer features. My thinking was to close the previous PR and delete the old branch since the code was outdated rather then to let it get merged and then come back and update it with this one. Perhaps, I should have merged this new feature branch with the old one on the old PR. |
35aa1b5
to
0ab73c5
Compare
Have added userspace folder. |
a1a3a78
to
9bc91d1
Compare
I previously had created separate branches for each keyboard I was working on with separate PRs to boot. I have now merged my branches (mkillewald_q1 and mkillewald_q1se) into this branch (mkillewald_q2_custom) for a single PR. |
…ER_COLOR to produce orange
…d with ansi keymap
@@ -0,0 +1,176 @@ | |||
// Copyright 2023 QMK |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You should move this to your userspace. It will still get picked up there, and you don't have to have 10 copies of it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@drashna I am using two different dictionary files, the 400 entry and the smaller 77 entry file. I've moved the 400 entry dictionary into my userspace folder because I would like this to be my default for in the future. Unfortunately, at this time, I have only one keymap (the q2) that utilizes the 400 entry dictionary. The Q1 keymaps (using the atmega32u4) are utilizing the smaller 77 entry file because they are near the firmware size limit. So I still have many copies of the same file. Perhaps there is a way to move both dictionary files to the userspace folder and specify which dictionary file to pull from?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you can still use the same file for both. Eg:
#if defined(__AVR__)
// avr friendly dictionary
#else
// arm dictionary
#endif
This would allow you to have one file for both configs. Either option is fine, though.
Will be adding a q1v2 keymap to this if/when #20416 is merged |
Thank you for your contribution! |
Unfortunately since this PRs creation, QMK has changed its stance on accepting user keymaps to the repository.
In the near future we will be providing a more user focused workflow for keymaps, but till then the suggestion is to keep changes in your own fork. While we appreciate the time that was taken on this PR, hopefully you understand we are closing it, so that QMK can improve in the long term. |
Description
Types of Changes
Issues Fixed or Closed by This PR
Checklist