Add extra configuration option for oled displays #20441
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
madwort
force-pushed
the
madwort/oled_config
branch
from
e84cc9d to
a78bba0
Compare
* keep the configuration values at their defaults * I have some displays that require different settings, this will allow me configure this in my keymap
madwort
force-pushed
the
madwort/oled_config
branch
from
a78bba0 to
1cc02ed
Compare
drashna
reviewed
Apr 14, 2023
madwort
changed the title
|
#20331 resolves this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The particular oled displays I have don't work well with the default config values that are hard-coded in the display driver. This change exposes these default values in the header file, so that I can better override them in my keymap
config.h.Types of Changes
Checklist