Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLI: Improve keymap folder resolution #20981

Merged
merged 1 commit into from
May 19, 2023

Conversation

fauxpark
Copy link
Member

Description

  • Renamed qmk.path.keymap() to keymaps() and changed return value to a list of all found keymaps/ directories for the given keyboard
  • keymap() now takes a keyboard name and keymap name, and returns the path if it exists

This fixes an issue with qmk new-keymap: for example, attempting to create a new keymap for a board such as crkbd/rev1 fails as there is no default keymap under rev1's keymaps/ directory. Now it should grab the keymap folder from parent level and copy it down.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@fauxpark fauxpark requested a review from a team May 18, 2023 03:00
@fauxpark fauxpark merged commit dc75c23 into qmk:develop May 19, 2023
@fauxpark fauxpark deleted the cli-fix-keymap-folder-resolution branch May 19, 2023 06:05
coquizen pushed a commit to coquizen/qmk_firmware that referenced this pull request Jun 22, 2023
autoferrit pushed a commit to SpaceRockMedia/bastardkb-qmk that referenced this pull request Dec 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants