preonic/rev3, preonic/rev3_drop: Fix layouts with 2u keys
#21114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Apparently layouts with 2u keys were not correctly converted into the `info.json` format (the old C layout macros used the arguments for such keys multiple times to cover all possible 1u locations; this is not supported in `info.json`, and the single matrix location for 2u keys was chosen incorrectly in some cases). Fix the layout definitions to match the real PCB wiring.
fauxpark
approved these changes
Jun 2, 2023
|
Ideally someone should test this on a real PCB (the reporter in Discord apparently tested only |
coquizen
pushed a commit
to coquizen/qmk_firmware
that referenced
this pull request
Jun 22, 2023
Apparently layouts with 2u keys were not correctly converted into the `info.json` format (the old C layout macros used the arguments for such keys multiple times to cover all possible 1u locations; this is not supported in `info.json`, and the single matrix location for 2u keys was chosen incorrectly in some cases). Fix the layout definitions to match the real PCB wiring.
jussaw
added a commit
to jussaw/qmk_firmware
that referenced
this pull request
Aug 18, 2023
* [Keyboard] add kibou/harbour (qmk#21131) * [Docs] Highlight keymap name entry (qmk#21138) * [Keyboard] Add ScottoStarter handwired keyboard (qmk#21101) * [Keyboard] Add Scotto40 handwired keyboard (qmk#21103) * [Keyboard] Add Scotto36 handwired keyboard (qmk#21104) Co-authored-by: Albert Y <76888457+filterpaper@users.noreply.github.com> * [Keyboard] Add egg58 (qmk#21021) * xelus/rs108: correct layout data (qmk#21146) * peej/tripel: correct layout data (qmk#21145) Corrects the layout data for all three versions of the Peej Tripel. * [Bugfix] LVGL bindings wrong offset math (qmk#21147) * poker87d: correct layout data (qmk#21159) * monoflex60: fix LAYOUT_60_iso_tsangan implementation (qmk#21158) * add kibou/wendy (qmk#21150) * Add NortonTech handwired keypad (NortonTechPad) (qmk#21148) * Add an emphasis on QMK MSYS terminal (qmk#21168) * Add an emphasis on QMK MSYS terminal Not using MSYS terminal is a frequent user error. This change adds an additional statement to guide users to run the first command in MSYS itself. Edited the same statement for consistency in the other OSes. * Update instructions for the other operating systems * Slightly refine `g_led_config` parsing (qmk#21170) * Adds Planck Rev 7 & Updates rev6_drop to Matrix Lite Implementation (qmk#21175) * adds planck/rev7 * Remove config.h include Co-authored-by: Drashna Jaelre <drashna@live.com> * convert planck matrices to lite implementation --------- Co-authored-by: Drashna Jaelre <drashna@live.com> * Fix typo (qmk#21189) * Remove some keymap-level info.jsons (qmk#21191) * [Keyboard] Add ScottoGame Keyboard (qmk#20940) * Typo Correction in planck/rev7 readme.md (qmk#21194) Corrected typo explaining encoder requirements. * Update newbs docs with some rp2040 stuff (qmk#21186) * Update newbs_building_firmware_configurator.md * Update docs/newbs_flashing.md Co-authored-by: Ryan <fauxpark@gmail.com> * EC Alveus (qmk#20840) Cipulot's EC Alveus PR * Up keymap (qmk#20769) flinguenheld keymap aurora sweep * [Keymap] thunderbird2086 layer status with RGB lighting/matrix (qmk#21063) * Atreyu: correct layout data (qmk#21197) * [Keyboard] Adding OSAv2 Topre PCB (qmk#21080) * [Keyboard] Add kibou/winter (qmk#21161) * [Keyboard] Add Scotto9 handwired macropad (qmk#21105) Co-authored-by: Albert Y <76888457+filterpaper@users.noreply.github.com> Co-authored-by: Drashna Jaelre <drashna@live.com> * [Keyboard] Add Scotto34 (PCB Edition) (qmk#21085) Co-authored-by: Albert Y <76888457+filterpaper@users.noreply.github.com> * [Keyboard] Add Flashquark Horizon Z (qmk#21055) Co-authored-by: jack <0x6a73@protonmail.com> * [Keyboard] Add ScottoSplit Keyboard (qmk#20945) Co-authored-by: Drashna Jaelre <drashna@live.com> * [Keyboard] Add orba keyboard (qmk#21132) * [Keyboard] Add ScottoFrog macropad (qmk#21209) * [Keyboard] Add ScottoNum macropad (qmk#21208) * [Keyboard] Add ErgoStrafer keyboard (qmk#21195) * [Keyboard] rainkeebs trailmix (qmk#20189) Co-authored-by: jack <0x6a73@protonmail.com> * [Keyboard] jaykeeb skyline (qmk#21219) * [Keyboard] Add mokey12x2 (qmk#20702) Co-authored-by: Ryan <fauxpark@gmail.com> Co-authored-by: Joel Challis <git@zvecr.com> * [Keyboard]add 5108 Keyboard. (qmk#21184) Co-authored-by: adophoxia <100170946+adophoxia@users.noreply.github.com> Co-authored-by: jack <0x6a73@protonmail.com> * Add Sinc Rev. 4 (qmk#21130) * Fork Rev. 3 to 4 * Update RGB LED positions * Adjust RGB positions * Enable more RGB modes * Update copyrights * Add license headers to keymaps * Use same type of license header Co-authored-by: Joel Challis <git@zvecr.com> * Fix I2C pins --------- Co-authored-by: Joel Challis <git@zvecr.com> * 4pplet Waffling60 Rev D ISO Layout Fix and Additions (qmk#21236) * correct layout data * add matrix diagram * rename LAYOUT to LAYOUT_all * add LAYOUT_60_iso_tsangan_split_bs_rshift * add LAYOUT_60_iso_tsangan_split_rshift * add LAYOUT_60_iso_wkl_split_bs_rshift * add LAYOUT_60_iso_wkl_split_rshift * [Keyboard] add pluto keyboard (qmk#21225) * Modernize M75H and M75S firmwares (qmk#21244) * [Keymap] Left Control is now ESC when tapped (qmk#21241) * [Keyboard] Add CannonKeys Leviatan PCB (qmk#21231) * [Keyboard] Adding OSAv2 Numpad Topre support (qmk#21224) * [Keyboard] add acr87 keyboard. (qmk#21200) * [Keyboard] add top40 keyboard. (qmk#21199) Co-authored-by: Less/Rikki <86894501+lesshonor@users.noreply.github.com> * [Keyboard] Add Artemis Paragon (qmk#20910) Co-authored-by: jack <0x6a73@protonmail.com> * DOIO KB30 Refactor (qmk#21250) * refactor keymaps - remove extra blank lines - convert tabs to spaces - use four-space indent - grid-align keycodes - use QMK-native keycode aliases * info.json: correct layout data * add readme.md * info.json: correct maintainer field Updates the value to reference the maintainer's GitHub username. * ButterKeebs PocketPad: correct layout data (qmk#21256) * Alas: ISO Layouts Fix and Matrix Diagram (qmk#21255) * DOIO KB38 Refactor (qmk#21268) * [refactor] keymap refactor - tidy-up box drawing - update keycode alignment for readability - use QMK-native keycode aliases * [refactor] correct layout data * [docs] add image to readme * Dymium65 Layout Touch-Up (qmk#21269) * [refactor] friendly-format info.json * [refactor] correct layout data * Fix up operator precedence in RGBLIGHT (qmk#21280) * preonic/rev3{,_drop}: Fix layouts with 2u keys (qmk#21114) Apparently layouts with 2u keys were not correctly converted into the `info.json` format (the old C layout macros used the arguments for such keys multiple times to cover all possible 1u locations; this is not supported in `info.json`, and the single matrix location for 2u keys was chosen incorrectly in some cases). Fix the layout definitions to match the real PCB wiring. * [refactor] correct layout data (qmk#21289) * Geistmaschine Geist Layout Refactor and Touch-Up (qmk#21288) * Swap G431 to transient EEPROM. Add G431 and G474 onekeys. (qmk#21282) * [Keyboard] Add support for Alveus MX PCB (qmk#21238) Co-authored-by: jack <0x6a73@protonmail.com> * HFDKB K83 Configurator Layout Fix (qmk#21297) * Tsubasa Handwired: correct layout data (qmk#21295) * dnworks SBL Community Layout Support and Touch-Up (qmk#21267) * [Docs] Add note about `ENABLE_COMPILE_KEYCODE` to docs (qmk#21290) Co-authored-by: Ryan <fauxpark@gmail.com> * [Keyboard] Add bigsmoothknob (qmk#21265) Co-authored-by: Joel Challis <git@zvecr.com> Co-authored-by: jack <0x6a73@protonmail.com> * [Keyboard] Add Alisaie (qmk#21266) * [Keyboard] Add Keychron C1 Pro (qmk#20700) Co-authored-by: adophoxia <100170946+adophoxia@users.noreply.github.com> Co-authored-by: Drashna Jaelre <drashna@live.com> Co-authored-by: jack <0x6a73@protonmail.com> * KJ-Modify RS40 Configurator Touch-Up (qmk#21311) * [refactor] friendly-format info.json * [enhancement] remove key overlap Fix a key overlap in the Configurator rendering between LCtrl and Fn2. * [enhancement] replace store links with product links Replace URLs that point to the vendor's shop with URLs to the vendor's product listing. * Kalakos Bahrnob65 Configurator Layout Touch-Up (qmk#21309) * [enhancement] add matrix diagram * [refactor] friendly-format info.json * [enhancement] remove key overlaps * Planck Matrix Fixes (qmk#21196) * fix non-default keymap compiling, initial matrix state, watchdog options * fix: allow planck/rev7 to be used with ENCODER_ENABLE = no * chore: update function name on all cases. * remove old midi tone option Co-authored-by: Ryan <fauxpark@gmail.com> * fixes abhixec's planck keymap * add audio enable condition to abhixec's planck keymap * add audio enable condition to all muse includes * Revert "add audio enable condition to all muse includes" This reverts commit 9779e90. * Revert "add audio enable condition to abhixec's planck keymap" This reverts commit 24c742a. * Revert "fixes abhixec's planck keymap" This reverts commit 4bb085d. --------- Co-authored-by: Peter.Falken <luis@bitjester.com> Co-authored-by: Ryan <fauxpark@gmail.com> * NovelKeys NK+: correct layout data (qmk#21317) * NovelKeys NK+: correct layout data Add key sizes to the layout data. * [refactor] rename LAYOUT to LAYOUT_65_xt_ansi_blocker_tsangan * [Docs] Code markdown amendment (qmk#21323) * [Keyboard] Add Monsgeek M5 (qmk#21182) Co-authored-by: adophoxia <100170946+adophoxia@users.noreply.github.com> Co-authored-by: jack <0x6a73@protonmail.com> * Add Keychron C2 Pro (qmk#20701) Co-authored-by: Drashna Jaelre <drashna@live.com> Co-authored-by: adophoxia <100170946+adophoxia@users.noreply.github.com> Co-authored-by: jack <0x6a73@protonmail.com> * Keebio Cepstrum Configurator Touch-Up (qmk#21310) * [enhancement] remove redundant layout data Remove the redundant layout data from the keyboard-level `info.json`. * [enhancement] correct JSON syntax in rev1/info.json * [enhancement] friendly-format rev1/info.json * [enhancement] correct layout data * Lucid Velvet Hotswap Layout Additions and Touch-Up (qmk#21312) * [refactor] refactor via keymap - grid-align keycodes - remove trailing whitespace * [refactor] refactor default keymap - grid-align keycodes - remove trailing whitespace * [bugfix] fix key sequence error in default keymap * [enhancement] fix key overlap in Configurator * [enhancement] add matrix diagram * [refactor] rename LAYOUT to LAYOUT_tkl_f13_ansi_split_bs_rshift * [enhancement] add LAYOUT_tkl_f13_ansi * [enhancement] add LAYOUT_tkl_f13_ansi_tsangan_split_bs_rshift * [enhancement] add LAYOUT_tkl_f13_ansi_tsangan * [enhancenment] enable Community Layout support * Lucid Velvet Solder Layout Additions and Touch-Up (qmk#21313) * [refactor] refactor via keymap - grid-align keycodes - remove trailing whitespace * [refactor] refactor default keymap - grid-align keycodes - remove trailing whitespace * [bugfix] fix key sequence error in default keymap * [enhancement] fix key overlaps in Configurator * [enhancement] add matrix diagram * [refactor] rename LAYOUT to LAYOUT_all * [enhancement] add LAYOUT_tkl_f13_ansi_split_space_split_bs_rshift * [enhancement] add LAYOUT_tkl_f13_ansi_split_bs_rshift * [enhancement] add LAYOUT_tkl_f13_ansi * [enhancement] add LAYOUT_tkl_f13_iso_split_space_split_bs_rshift * [enhancement] add LAYOUT_tkl_f13_iso_split_bs_rshift * [enhancement] add LAYOUT_tkl_f13_iso * [Keymap] Add lindgrenj6 planck layout (qmk#21155) * Laneware LW75: correct layout data (qmk#21314) [refactor] Fixes misleading Configurator implementations of the available layouts. * Pteropus: correct layout data (qmk#21326) * [style] friendly-format info.json * [chore] correct layout data Fix keys overlapping when rendered in QMK Configurator or CLI. * Quarkeys Z40 Community Layout Support and Touch-Up (qmk#21329) * [refactor] rename LAYOUT to LAYOUT_planck_mit * [style] friendly-format info.json * [style] refactor keymaps - grid-align keycodes - use four-space indent - remove trailing whitespace * [chore] tidy-up keyboard data in info.json - spell-check `manufacturer` value - use valid `url` - reference GitHub username for `maintainer` * [chore] tidy-up readme - link to maintainer's GitHub account - add Hardware Availability link - break-out Hardware Specs into its own section * [enhancement] enable Community Layout support * [chore] replace product image in readme Source repository for previous URL seems to have been deleted. * Igloo Configurator Touch-Up (qmk#21303) * [refactor] friendly-format info.json * [enhancement] add matrix diagram * [enhancement] remove key overlaps in layout data * Spleeb: correct layout data (qmk#21334) * [style] friendly-format info.json * [chore] correct layout data Fix a poor Configurator/CLI rendering. * Soda Pocket: correct layout data (qmk#21333) [chore] Correct the layout data for the keyboard. This commit fixes a misleading Configurator implementation. * Viktus OSAv2 Numpad Community Layout Support and Configurator Touch-Up (qmk#21342) * [style] sort JSON keys in layout objects * [chore] correct layout data * [refactor] rename LAYOUT_all_split to LAYOUT_ortho_5x4 * [refactor] rename LAYOUT_2u_plus_2u_enter_2u_zero to LAYOUT_numpad_5x4 * [enhancement] enable Community Layout support * Teahouse Ayleen Community Layout Support and Touch-Up (qmk#21341) * [chore] correct layout data * [refactor] rename LAYOUT to LAYOUT_tkl_f13_ansi_tsangan * [enhancement] enable Community Layout support * Wuque Creek70 Layout Additions and Touch-Up (qmk#21346) * [chore] correct layout data * [docs] add layout/matrix diagram * [refactor] rename LAYOUT to LAYOUT_all * [enhancement] add LAYOUT_ansi_split_space_split_bs_rshift * [enhancement] add LAYOUT_ansi_split_space * [enhancement] add LAYOUT_ansi_split_bs_rshift * [enhancement] add LAYOUT_ansi * [enhancement] add LAYOUT_ansi_tsangan_split_bs_rshift * [enhancement] add LAYOUT_ansi_tsangan * [style] refactor keymaps - use four-space indent - convert tabs to spaces - use QMK-native keycode aliases * Y&R Transition80 Layout Additions and Touch-Up (qmk#21347) * [chore] correct layout data * [chore] rename LAYOUT to LAYOUT_all * [docs] add layout/matrix diagram * [enhancement] add LAYOUT_tkl_ansi_split_bs * [enhancement] add LAYOUT_tkl_ansi * [enhancement] add LAYOUT_tkl_ansi_tsangan_split_bs * [enhancement] add LAYOUT_tkl_ansi_tsangan * [enhancement] enable Community Layout support * [chore] add reference keymaps * Akko Top40: correct layout data (qmk#21348) * Jaykeeb Orba Layout Addition and Touch-Up (qmk#21349) * [chore] correct layout data * [chore] rename LAYOUT to LAYOUT_625u_space * [style] friendly-format info.json * [enhancement] add LAYOUT_7u_space * Jaykeeb Skyline: correct layout data (qmk#21350) * Bump tj-actions/changed-files from 36 to 37 (qmk#21356) Bumps [tj-actions/changed-files](https://github.com/tj-actions/changed-files) from 36 to 37. - [Release notes](https://github.com/tj-actions/changed-files/releases) - [Changelog](https://github.com/tj-actions/changed-files/blob/main/HISTORY.md) - [Commits](tj-actions/changed-files@v36...v37) --- updated-dependencies: - dependency-name: tj-actions/changed-files dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Verify max one keyboard addition during CI. (qmk#21246) * Kibou Harbour Layout Addition and Touch-Up (qmk#21358) * [style] friendly-format info.json * [chore] correct layout data * [docs] add layout/matrix diagram * [refactor] rename LAYOUT to LAYOUT_65_ansi_blocker_tsangan_split_bs * [enhancement] add LAYOUT_65_ansi_blocker_wkl_split_bs * [chore] correct listed maintainer Reference the maintainer's GitHub username. * Update config.h (qmk#21361) * Kibou Winter: rename LAYOUT to LAYOUT_tkl_ansi_wkl (qmk#21372) * Mechlovin Zed65 rev1 Touch-Up (qmk#21373) * [docs] add layout/matrix diagram * [refactor] rename LAYOUT_65_ansi_tsangan to LAYOUT_65_ansi * Add riot auto-merge to `master` to trigger GH workflows. (qmk#21390) * Smith & Rune Iron160 Hotswap Touch-Up (qmk#21376) * [style] friendly-format info.json - sort JSON keys in layouts object - remove instances of `w: 1` * [chore] correct layout data * [refactor] rename LAYOUT to LAYOUT_60_tsangan_hhkb * [enhancement] add LAYOUT_60_ansi_tsangan_split_rshift * [enhancement] enable Community Layout support * [bugfix] write appropropriate keymaps Neither the `default` nor `via` keymaps were written appropriately for this keyboard. This commit modifies both keymaps to be appropriate for `60_tsangan_hhkb` layout. * Kibou Wendy Layout Additions and Touch-Up (qmk#21367) * [style] refactor keymaps - use four-space indent - grid-align keycodes - use QMK-native keycode aliases * [style] friendly-format info.json * [chore] remove key overlaps in layout data * [chore] correct key sequence * [chore] add key labels Add `label` keys to the JSON layout data to disambiguate which keys each object is meant to represent. Based on the original key sizes and positions as submitted by the maintainer. * [docs] add layout/matrix diagram * [refactor] rename LAYOUT to LAYOUT_all * [enhancement] add LAYOUT_tkl_ansi_split_bs_rshift * [enhancement] add LAYOUT_tkl_iso_split_bs_rshift * [enhancement] enable Community Layout support * [Keyboard] Sofle: fix LED count (qmk#21386) * correct `default_60_abnt2/keymap.c` ASCII diagram (qmk#21397) * sofle/rev1:devdev: Disable console (qmk#21401) * Add Iris Rev. 8 (qmk#21392) Co-authored-by: Duncan Sutherland <dunk2k_2000@hotmail.com> * [Keymap] Add peterfalken planck/rev7 keymap (qmk#21328) * [Keyboard] Add jaykeeb sebelas (qmk#21335) * [Keyboard] Add Varanidae (qmk#21340) * usbpd_stm32g4: Configure UCPD before disabling the dead battery mode (qmk#21430) * [Docs] Fix listed defaults in quantum painter docs (qmk#21429) * [Keyboard] Add Zed65 910 PCB (qmk#21415) Co-authored-by: Duncan Sutherland <dunk2k_2000@hotmail.com> Co-authored-by: Less/Rikki <86894501+lesshonor@users.noreply.github.com> Co-authored-by: Ryan <fauxpark@gmail.com> * [Keymap] Improve tap-hold configuration (qmk#21383) * [Keyboard] b_sides/rev41lp: add via keymap (qmk#21381) * [Keyboard] add `handwired/dactyl_maximus` keyboard (qmk#21338) * Smith & Rune Iron160 Soldered Touch-Up (qmk#21377) * [Keyboard] Add Plywrks ply8x (qmk#21263) Co-authored-by: Joel Challis <git@zvecr.com> Co-authored-by: jack <0x6a73@protonmail.com> Co-authored-by: Duncan Sutherland <dunk2k_2000@hotmail.com> Co-authored-by: Ryan <fauxpark@gmail.com> * Changed interverts to inverts (qmk#21270) * Changed interverts to inverts * fixed spacing issue Co-authored-by: Joel Challis <git@zvecr.com> --------- Co-authored-by: Joel Challis <git@zvecr.com> * [Keyboard] Add the Mine Keyboard (qmk#21211) * planck/rev7: Fix build without AUDIO_ENABLE (qmk#21408) * [Keyboard] Add MNK60 (qmk#21204) Co-authored-by: Drashna Jaelre <drashna@live.com> Co-authored-by: Ryan <fauxpark@gmail.com> Co-authored-by: jack <0x6a73@protonmail.com> * [Keyboard] Add XT87 (qmk#21201) Co-authored-by: Drashna Jaelre <drashna@live.com> Co-authored-by: Ryan <fauxpark@gmail.com> Co-authored-by: jack <0x6a73@protonmail.com> * [Keymap] Update andrebrait keymap for GMMK Pro (qmk#21133) * [Keyboard] Add ScottoCMD handwired keyboard (qmk#21102) Co-authored-by: jack <0x6a73@protonmail.com> * [Keyboard] Add Fidelity keyboard (qmk#20922) Co-authored-by: Drashna Jaelre <drashna@live.com> * [Keyboard] Add Baumkuchen (qmk#20766) Co-authored-by: Joel Challis <git@zvecr.com> Co-authored-by: Drashna Jaelre <drashna@live.com> * [Keyboard] Add dactyl_lightcycle (qmk#20709) Co-authored-by: Drashna Jaelre <drashna@live.com> Co-authored-by: Ryan <fauxpark@gmail.com> * [Keyboard] Adding Krado Industries keyboards (qmk#20372) Co-authored-by: Joel Challis <git@zvecr.com> Co-authored-by: jack <0x6a73@protonmail.com> * [Keyboard] Add Frost68 keyboard (qmk#20370) Co-authored-by: Pablo Martínez <58857054+elpekenin@users.noreply.github.com> Co-authored-by: Drashna Jaelre <drashna@live.com> Co-authored-by: Joel Challis <git@zvecr.com> Co-authored-by: jack <0x6a73@protonmail.com> * [Keyboard] Update 1upkeyboards pi60 config (qmk#21404) * [Keyboard] Add key-ripper (qmk#19598) * [keyboard] Add abko/ak84bt (qmk#21243) Co-authored-by: Drashna Jaelre <drashna@live.com> Co-authored-by: Ryan <fauxpark@gmail.com> Co-authored-by: syc <squall_sha@163.com> * [Keyboard] Add RM Fullsize (qmk#20925) Co-authored-by: Joel Challis <git@zvecr.com> Co-authored-by: Ryan <fauxpark@gmail.com> Co-authored-by: jason <jrucker2004@gmail.com> Co-authored-by: Snipeye <Snipeye@gmail.com> Co-authored-by: jack <0x6a73@protonmail.com> * 4pplet Eagle Viper Rev B: correct LAYOUT_all data (qmk#21458) Corrects the position of the Right Ctrl key. * [Keymap] small changes, game layer for mattly keymap (qmk#21375) Co-authored-by: Ryan <fauxpark@gmail.com> * [Keyboard] Add mazestudio jocker (qmk#21446) Co-authored-by: jack <0x6a73@protonmail.com> * [Keyboard] Add dp3000 macropad (qmk#21413) * [Keyboard] Add Nyquist Rev. 4 (qmk#21421) Co-authored-by: Drashna Jaelre <drashna@live.com> * [Keyboard] Add chosfox cf81 (qmk#21437) Co-authored-by: Duncan Sutherland <dunk2k_2000@hotmail.com> Co-authored-by: jack <0x6a73@protonmail.com> * [Keyboard] Keychron Q11 ISO Version (qmk#21438) * [Keyboard] Add dnworks frltkl (qmk#21457) * [Keymap] Add zigotica stenai keymap for XD75 keyboard (qmk#21412) Co-authored-by: Drashna Jaelre <drashna@live.com> * [Keyboard] Fix default keymap for RM_Fullsize (qmk#21461) Co-authored-by: jason <jrucker2004@gmail.com> * clarify what the heck pristine means for reasons (qmk#20950) * [Refactor] Python-ify QP's converter code (qmk#20102) * Adjust width requirement for big enter (qmk#21470) * Lights Out keymap for winry25t (qmk#20538) Co-authored-by: Drashna Jaelre <drashna@live.com> * [Keyboard] Add stront keyboard (qmk#21035) * Add ScottoAlp Keyboard (qmk#20937) * Pomodoro Timer in Lily58 (qmk#21215) * [Keyboard] add m6 Keyboard. (qmk#21183) * add `scotto` community layouts and userspace (qmk#21097) Co-authored-by: Joe Scotto <me@joescotto.com> Co-authored-by: Drashna Jaelre <drashna@live.com> Co-authored-by: Joe Scotto <contact@joescotto.com> * add ASCII diagrams to LAYOUT_64_* (qmk#21285) * Add EVO70 R2 Keyboard (qmk#21321) * Adding Custom Shift Key Implementation for BriianPowell's Gentleman65 Keymap (qmk#21315) * Add a turbo feature to coffee keymap (qmk#21291) Co-authored-by: Fae <faenkhauser@gmail.com> * [Keymap] Add slotThe keyboardio/atreus keymap (qmk#21274) * Add 'JIS' form factor layouts (qmk#21220) * bootmagic mods covering the case when swapped mods are pressed at the same time (qmk#21320) * [Keyboard] Adding Styrka Topre PCB (qmk#21276) * AMJKeyboard AMJ84 Touch-Up (qmk#21463) * Revert "bootmagic mods covering the case when swapped mods are pressed at the same time (qmk#21320)" (qmk#21471) * [Keyboard] update keyboard soda/mango, support rgb matrix (qmk#21385) Co-authored-by: Joel Challis <git@zvecr.com> Co-authored-by: Duncan Sutherland <dunk2k_2000@hotmail.com> * [Keyboard] Add Neely 65 (qmk#21027) Co-authored-by: Joel Challis <git@zvecr.com> Co-authored-by: Ryan <fauxpark@gmail.com> Co-authored-by: Wolf <contact@vwolf.be> * [Keyboard] Add Silhouette (qmk#21025) Co-authored-by: jack <0x6a73@protonmail.com> Co-authored-by: Joel Challis <git@zvecr.com> Co-authored-by: Ryan <fauxpark@gmail.com> Co-authored-by: Drashna Jaelre <drashna@live.com> Co-authored-by: Wolf <contact@vwolf.be> * [Keyboard] Add Ziggurat (qmk#21024) Co-authored-by: jack <0x6a73@protonmail.com> Co-authored-by: Joel Challis <git@zvecr.com> Co-authored-by: Ryan <fauxpark@gmail.com> Co-authored-by: Wolf <contact@vwolf.be> * Artemis Paragon Layout Additions (qmk#21479) * [docs] hotswap version: add layout/matrix diagram * [docs] soldered version: add layout/matrix diagram * [refactor] rename LAYOUT to LAYOUT_all * [enhancement] hotswap version: add LAYOUT_ansi_rwkl_split_bs * [enhancement] hotswap version: add LAYOUT_ansi_rwkl * [enhancement] hotswap version: add LAYOUT_ansi_wkl_split_bs * [enhancement] hotswap version: add LAYOUT_ansi_wkl * [enhancement] soldered version: add LAYOUT_iso_rwkl_split_space_split_bs * [enhancement] soldered version: add LAYOUT_iso_rwkl_split_space * [enhancement] soldered version: add LAYOUT_iso_rwkl_split_bs * [enhancement] soldered version: add LAYOUT_iso_rwkl * [enhancement] soldered version: add LAYOUT_ansi_rwkl_split_space_split_bs * [enhancement] soldered version: add LAYOUT_ansi_rwkl_split_space * [enhancement] soldered version: add LAYOUT_ansi_rwkl_split_bs * [enhancement] soldered version: add LAYOUT_ansi_rwkl * 1upocarina (qmk#21039) Co-authored-by: Joel Challis <git@zvecr.com> * [Docs] Squeeze AVR with simplified magic config functions (qmk#21477) * Userspace and keymap addition (qmk#20522) Co-authored-by: Drashna Jaelre <drashna@live.com> * [Keyboard] Add kibou/suisei (qmk#21487) Co-authored-by: Ryan <fauxpark@gmail.com> Co-authored-by: jack <0x6a73@protonmail.com> * [Keyboard] Add ah/haven{65,80} (qmk#20142) Co-authored-by: Drashna Jaelre <drashna@live.com> Co-authored-by: jack <0x6a73@protonmail.com> Co-authored-by: CMM.Studio Freather <50167286+frankBTHID@users.noreply.github.com> * AliceH66 Pianoforte Touch-Up (qmk#21504) * DTIsaac01 Layout Additions and Touch-Up (qmk#21505) * CMM.Studio Fuji65 Layout Additions (qmk#21501) * [Keyboard] Add Mode M256-WS and M256-WH (qmk#20502) Co-authored-by: Ryan <fauxpark@gmail.com> * [Keyboard] add itstleo9 (qmk#21460) Co-authored-by: jack <0x6a73@protonmail.com> * [Keyboard] Fix dactyl_lightcycle matrix positions (qmk#21503) * [Keyboard] Model H controller for IBM Model M (qmk#20625) Co-authored-by: Drashna Jaelre <drashna@live.com> Co-authored-by: Ryan <fauxpark@gmail.com> Co-authored-by: hcbille <32437363+hcbille@users.noreply.github.com> * [Keymap] Update Zweihander Ergodox keymap (qmk#21506) Swap volume direction, add Expand/Shrink Selection buttons * [Keyboard] Add QVEX Lynepad 2.0 (qmk#21070) * [Keyboard] Add nix_studio/lilith (qmk#20466) Co-authored-by: Less/Rikki <86894501+lesshonor@users.noreply.github.com> Co-authored-by: Drashna Jaelre <drashna@live.com> Co-authored-by: Sergey Vlasov <sigprof@gmail.com> * [Keyboard] Fix RS60's indicator LED (qmk#21509) * [Keymap] Dothtm/0.21/60 and 75 (qmk#21442) Co-authored-by: Ryan <fauxpark@gmail.com> * [Keyboard] add rocketkeyboards mercury65 (qmk#20811) Co-authored-by: jack <0x6a73@protonmail.com> * [Keyboard] Add new nemui65 (qmk#21304) Co-authored-by: Duncan Sutherland <dunk2k_2000@hotmail.com> Co-authored-by: jack <0x6a73@protonmail.com> * [Keyboard] Add minidivide (qmk#19870) Co-authored-by: jack <0x6a73@protonmail.com> Co-authored-by: Ryan <fauxpark@gmail.com> Co-authored-by: Joel Challis <git@zvecr.com> Co-authored-by: Drashna Jaelre <drashna@live.com> * Fix jaykeeb indicator state and pins (qmk#21466) * Bump JamesIves/github-pages-deploy-action from 4.4.2 to 4.4.3 (qmk#21518) Bumps [JamesIves/github-pages-deploy-action](https://github.com/jamesives/github-pages-deploy-action) from 4.4.2 to 4.4.3. - [Release notes](https://github.com/jamesives/github-pages-deploy-action/releases) - [Commits](JamesIves/github-pages-deploy-action@v4.4.2...v4.4.3) --- updated-dependencies: - dependency-name: JamesIves/github-pages-deploy-action dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * [Keyboard] add mothwing (qmk#19342) Co-authored-by: Ryan <fauxpark@gmail.com> Co-authored-by: jack <0x6a73@protonmail.com> * AliceH66 Pianoforte Hotswap Touch-Up (qmk#21542) * [refactor] rename LAYOUT_tkl_ansi to LAYOUT_tkl_f13_ansi * [enhancement] enable Community Layout support * [chore] correct layout data Correct the position of the spacebar. * GMMK2 65% ANSI Touch-Up (qmk#21544) * [chore] correct layout data * [chore] rename LAYOUT to LAYOUT_65_ansi_blocker Also adds a layout alias so as to not have to edit the user keymaps. * [enhancement] enable Community Layout support * Keychron V4 Touch-Up (qmk#21545) * Keychron V4 ANSI: rename LAYOUT_ansi_61 to LAYOUT_60_ansi * Keychron V4 ANSI: enable Community Layout support * Keychron V4 ISO: correct layout data Move position [3, 1] up by 0.25u. * Keychron V4 ISO: rename LAYOUT_iso_62 to LAYOUT_60_iso * Keychron V4 ISO: enable Community Layout support * Fix compilation of lily58 rgb_state_reader (qmk#21502) * HolySwitch Lightweight65 Community Layout Support (qmk#21550) * [chore] rename LAYOUT to LAYOUT_65_ansi_blocker * [enhancement] enable Community Layout support * Automata02 Alisaie Touch-Up (qmk#21552) * [style] friendly-format info.json * [chore] remove key labels from info.json * [chore] correct layout data Fix a misleading Configurator implementation, and incorrect key sizes and positioning on the bottom row. * [chore] re-add key labels to info.json * Move files to rev1 folder, add rev2 (qmk#21563) Co-authored-by: Duncan Sutherland <dunk2k_2000@hotmail.com> * Add Bastion75 PCB to QMK (qmk#21529) * Add Bastion75 to QMK * Remove blank layers * Apply suggestions from code review Co-authored-by: jack <0x6a73@protonmail.com> * Update keymaps --------- Co-authored-by: jack <0x6a73@protonmail.com> * Document the right location for indicator functions (qmk#21512) * [Keyboard] Add boardsource/unicorne (qmk#21510) Co-authored-by: Drashna Jaelre <drashna@live.com> Co-authored-by: Cole Smith <smithcole@protonmail.com> * [Keyboard] Add EC Theca (qmk#21233) Co-authored-by: jack <0x6a73@protonmail.com> * Fix VS code live share extension link (qmk#21585) * Add Nyquistpad (qmk#21578) Co-authored-by: jack <0x6a73@protonmail.com> Co-authored-by: Ryan <fauxpark@gmail.com> * Fix paragon keyboard encoder step (qmk#21582) * [Keyboard] Add linworks fave60a (qmk#20795) Co-authored-by: Drashna Jaelre <drashna@live.com> Co-authored-by: Ryan <fauxpark@gmail.com> Co-authored-by: jack <0x6a73@protonmail.com> * Add Caps Lock indicator for Kyechron S1 white backlight version (qmk#21559) * [Keyboard] Add nico (qmk#20686) Co-authored-by: jack <0x6a73@protonmail.com> Co-authored-by: Drashna Jaelre <drashna@live.com> Co-authored-by: Ryan <fauxpark@gmail.com> Co-authored-by: Joel Challis <git@zvecr.com> * Fix ik75 scroll lock and windows lock status LEDs (qmk#20380) * Add Bastion60 PCB to QMK (qmk#21527) Co-authored-by: jack <0x6a73@protonmail.com> Co-authored-by: Danny <nooges@users.noreply.github.com> * Add BastionTKL PCB to QMK (qmk#21530) Co-authored-by: jack <0x6a73@protonmail.com> Co-authored-by: Danny <nooges@users.noreply.github.com> * Add Bastion65 PCB to QMK (qmk#21528) Co-authored-by: jack <0x6a73@protonmail.com> * [Keyboard] boardsource/equals (qmk#21230) Co-authored-by: Drashna Jaelre <drashna@live.com> Co-authored-by: jack <0x6A73@pm.me> * [Keyboard] Add m1 keyboard (qmk#19799) Co-authored-by: adophoxia <100170946+adophoxia@users.noreply.github.com> Co-authored-by: Ryan <fauxpark@gmail.com> Co-authored-by: wb-joy <chang.li@westberrytech.com> Co-authored-by: Joy Lee <joylee.lc@foxmail.com> * [Keyboard] Phoenix Project No 1 support (qmk#21068) Co-authored-by: Ryan <fauxpark@gmail.com> Co-authored-by: Joel Challis <git@zvecr.com> Co-authored-by: Drashna Jaelre <drashna@live.com> * Revert "Equals keyboard" (qmk#21622) * [Keyboard] Add splitkb.com's Aurora Sofle v2 (qmk#21499) Co-authored-by: Drashna Jaelre <drashna@live.com> Co-authored-by: Ryan <fauxpark@gmail.com> Co-authored-by: Thomas Baart <mail@thomasbaart.nl> * Amend documented `RGBLIGHT_HUE_STEP` default value (qmk#21617) * helix/rev3_4rows, helix/rev3_5rows: Fix build with converters (qmk#21608) The code for Helix rev3 boards could not be built with, e.g., `CONVERT_TO=rp2040_ce` due to invalid `#include <stdio.h>` in the keyboard level `config.h` (apparently the AVR version of that file contains guards against usage in assembly code, which was hiding the bug). Move `#include <stdio.h>` to the C sources which need it. * [Keyboard] Add Divine keyboard (qmk#21593) * [Keyboard] add itstleo40 PCB (qmk#21536) Co-authored-by: jack <0x6a73@protonmail.com> Co-authored-by: Drashna Jaelre <drashna@live.com> * [Keymap] update colemad crkbd (corne) keyboard (qmk#21515) Co-authored-by: Álvaro Cortés Devesa <alvarocortesdevesa@Alvaros-MacBook-Pro.local> * [Keyboard] Add ANAVI Macro Pad 12 (qmk#21547) * Updated info.json of c2 pro (qmk#21581) * Correct "less than" to "up to" in squeezing_avr?id=layers (qmk#21639) * Keychron Q11 ISO: Fix left Shift breakage due to a wrong matrix mask (qmk#21655) Keychron Q11 uses `matrix_mask` to mask away the matrix location used for `SPLIT_HAND_MATRIX_GRID` (otherwise the keyboard will constantly generate a wakeup request whenever the host enters suspend). However, the value of `matrix_mask` is actually chosen to mask away all unused locations, but it was apparently generated for the ANSI board and therefore masks away the left Shift key on the ISO board, breaking the functionality of that key. Fix `matrix_mask` to make the masking work as intended: - Set the `[4, 1]` bit to 1; this is the matrix location for the ISO left Shift. - Set the `[2, 5]` bit to 0; this is actually the matrix location which corresponds to `#define SPLIT_HAND_MATRIX_GRID A2, A15` on the left side, which was intended to be masked; apparently the wakeup problem does not happen due to `SPLIT_HAND_MATRIX_GRID_LOW_IS_RIGHT`, so the left half actually has that matrix location open. On the right side `A2, A15` is `[9, 6]`, which was masked off correctly. * [Keyboard] Add Bento Box macropad (qmk#20521) * moondrop/dash75: fix keymap (qmk#21680) * Clarify custom keycode enum requirement for PRs (qmk#21648) * Add VIA layout for Dactyl Manuform 5x6 (qmk#21649) Co-authored-by: Duncan Sutherland <dunk2k_2000@hotmail.com> * Contributing docs: add note to make sure repo is up to date (qmk#21694) * Fix `binepad/bn009` and `durgod/dgk6x/hades_ansi` keymaps (qmk#21701) * [Keyboard] Update usb.* of `dactyl_lightcycle` (qmk#21462) * [Keyboard] add laneware `raindrop` keyboard (qmk#21277) Co-authored-by: Sergey Vlasov <sigprof@gmail.com> Co-authored-by: Ryan <fauxpark@gmail.com> * [Keyboard] Add Projectd/65/Projectd_65_ansi (qmk#21520) Co-authored-by: Ryan <fauxpark@gmail.com> Co-authored-by: gksygithub <106651989+gksygithub@users.noreply.github.com> * [Keymap] Add Via keymap for CXT Studio (qmk#21675) * [Keyboard] fix json for nemui65 (qmk#21629) * [Keyboard] Update USB settings for dactyl_maximus (qmk#21666) * [Keyboard] Add mk47 keyboard (qmk#19797) Co-authored-by: Drashna Jaelre <drashna@live.com> Co-authored-by: Ryan <fauxpark@gmail.com> Co-authored-by: jack <0x6a73@protonmail.com> Co-authored-by: Joel Challis <git@zvecr.com> Co-authored-by: Joy <chang.li@westberrytech.com> Co-authored-by: Joy Lee <joylee.lc@foxmail.com> * correct keymap file name for tkl_f13_jis layout (qmk#21631) * Fix `keyboard` field for some JSON keymaps (qmk#21752) * [Keyboard] Add Shostudio Arc (qmk#21733) * [Keymap] Update rpbaptist crkbd (qmk#21674) Co-authored-by: Drashna Jaelre <drashna@live.com> Co-authored-by: Richard Baptist <richard@remote.com> * [Keymap] Update andrebrait keymap for GMMK Pro (qmk#21668) * [Keymap] submitting janat-t planck keymap (qmk#21619) Co-authored-by: Janat Taerakul <jtaerakul@indeed.com> * [keyboard] Graystudio Think6.5 V3 Support Revised (qmk#21560) Co-authored-by: jack <0x6a73@protonmail.com> Co-authored-by: Duncan Sutherland <dunk2k_2000@hotmail.com> Co-authored-by: Ryan <fauxpark@gmail.com> * [Keyboard] Add Chouchou keyboard (qmk#21699) * Add ScottoErgo Keyboard (qmk#20944) Co-authored-by: Drashna Jaelre <drashna@live.com> Co-authored-by: Ryan <fauxpark@gmail.com> * Add Scotto34 Keyboard (qmk#20943) Co-authored-by: Albert Y <76888457+filterpaper@users.noreply.github.com> Co-authored-by: Drashna Jaelre <drashna@live.com> Co-authored-by: Ryan <fauxpark@gmail.com> * Add ScottoInvader Keyboard (qmk#20941) Co-authored-by: Ryan <fauxpark@gmail.com> * coarse/cordillera: fix backlight config (qmk#21761) * The PoweredByPorridge layout for the Keyboardio Atreus (qmk#21737) Co-authored-by: jack <0x6a73@protonmail.com> --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: FanXingStudio <133078117+FanXingStudio@users.noreply.github.com> Co-authored-by: Albert Y <76888457+filterpaper@users.noreply.github.com> Co-authored-by: Joe Scotto <contact@joescotto.com> Co-authored-by: Travis Mick <lq@le1.ca> Co-authored-by: James Young <18669334+noroadsleft@users.noreply.github.com> Co-authored-by: Pablo Martínez <58857054+elpekenin@users.noreply.github.com> Co-authored-by: biuboom-jun <65760331+biuboom-jun@users.noreply.github.com> Co-authored-by: NortonTech <haydentnorton@gmail.com> Co-authored-by: Ryan <fauxpark@gmail.com> Co-authored-by: Jack Humbert <jack.humb@gmail.com> Co-authored-by: Drashna Jaelre <drashna@live.com> Co-authored-by: Jared <jaredthebass@gmail.com> Co-authored-by: Tom Barnes <tom@mechboards.co.uk> Co-authored-by: Cipulot <40441626+Cipulot@users.noreply.github.com> Co-authored-by: Florent Linguenheld <f@linguenheld.fr> Co-authored-by: Allen Choi <37539914+Thunderbird2086@users.noreply.github.com> Co-authored-by: blindassassin111 <38090555+blindassassin111@users.noreply.github.com> Co-authored-by: flashquark <59234072+flashquark@users.noreply.github.com> Co-authored-by: jack <0x6a73@protonmail.com> Co-authored-by: Alabahuy <rezzaadio@gmail.com> Co-authored-by: David Hoelscher <infinityis@users.noreply.github.com> Co-authored-by: Alberto Pavano <38161192+ATron789@users.noreply.github.com> Co-authored-by: rhmokey <57172003+rhmokey@users.noreply.github.com> Co-authored-by: Joel Challis <git@zvecr.com> Co-authored-by: jonylee@hfd <108282809+jonylee1986@users.noreply.github.com> Co-authored-by: adophoxia <100170946+adophoxia@users.noreply.github.com> Co-authored-by: Danny <nooges@users.noreply.github.com> Co-authored-by: dztech <moyi4681@users.noreply.github.com> Co-authored-by: Álvaro A. Volpato <alvaro.augusto.volpato@gmail.com> Co-authored-by: Gastón Jorquera <email@gaston.life> Co-authored-by: Andrew Kannan <andrew.kannan@gmail.com> Co-authored-by: Less/Rikki <86894501+lesshonor@users.noreply.github.com> Co-authored-by: Sleepdealr <35879391+Sleepdealr@users.noreply.github.com> Co-authored-by: Nick Brassel <nick@tzarc.org> Co-authored-by: Sergey Vlasov <sigprof@gmail.com> Co-authored-by: mechlovin <57231893+mechlovin@users.noreply.github.com> Co-authored-by: Derek <dschmell91@gmail.com> Co-authored-by: Roberts Kursitis <53969619+Automata02@users.noreply.github.com> Co-authored-by: lalalademaxiya1 <66767061+lalalademaxiya1@users.noreply.github.com> Co-authored-by: Peter.Falken <luis@bitjester.com> Co-authored-by: lindgrenj6 <lindgrenj6@gmail.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Duncan Sutherland <dunk2k_2000@hotmail.com> Co-authored-by: Silc Lizard (Tokage) Renew <tokage.it.lab@gmail.com> Co-authored-by: Idan Kamara <i@idank.me> Co-authored-by: Ramon Imbao <ramonimbao@gmail.com> Co-authored-by: Tim Stewart <timothy.stewart@pearson.com> Co-authored-by: Arturo Avila <69410272+ADPenrose@users.noreply.github.com> Co-authored-by: kopibeng <52724926+kopibeng@users.noreply.github.com> Co-authored-by: Andre Brait <andrebrait@gmail.com> Co-authored-by: Callum Hart <mini-ninja-64@users.noreply.github.com> Co-authored-by: takashicompany <t@kashi.company> Co-authored-by: Feags <41646528+Feags@users.noreply.github.com> Co-authored-by: skeletonkbd <90203406+skeletonkbd@users.noreply.github.com> Co-authored-by: ziptyze <mwcordier@gmail.com> Co-authored-by: Brian Schwind <brianmschwind@gmail.com> Co-authored-by: temp4gh <temp4bbs@163.com> Co-authored-by: syc <squall_sha@163.com> Co-authored-by: Rucker Machine <98196480+RuckerMachine@users.noreply.github.com> Co-authored-by: jason <jrucker2004@gmail.com> Co-authored-by: Snipeye <Snipeye@gmail.com> Co-authored-by: Matthew Lyon <matthew@lyonheart.us> Co-authored-by: Han's <112836129+mazestd@users.noreply.github.com> Co-authored-by: depermana12 <deddiapermana97@gmail.com> Co-authored-by: leyew <102467346+itsme-zeix@users.noreply.github.com> Co-authored-by: Sergi Meseguer <zigotica@gmail.com> Co-authored-by: Tom Parker-Shemilt <palfrey@tevp.net> Co-authored-by: Evgenii Vilkov <zzeneg@gmail.com> Co-authored-by: Casey Borders <TheBeast.13@gmail.com> Co-authored-by: Joe Scotto <me@joescotto.com> Co-authored-by: Brian <brian@powell.place> Co-authored-by: CoffeeIsLife <36961653+CoffeeIsLife87@users.noreply.github.com> Co-authored-by: Fae <faenkhauser@gmail.com> Co-authored-by: Tony Zorman <soliditsallgood@mailbox.org> Co-authored-by: Nimish Gåtam <nimishg@gmail.com> Co-authored-by: Jeayo Keh <gezhaoyou@126.com> Co-authored-by: Wolf Van Herreweghe <wolfvanh@gmail.com> Co-authored-by: Wolf <contact@vwolf.be> Co-authored-by: miketronic <mikebarnoski@gmail.com> Co-authored-by: Freather <72902384+CMMS-Freather@users.noreply.github.com> Co-authored-by: CMM.Studio Freather <50167286+frankBTHID@users.noreply.github.com> Co-authored-by: Its TLeo <134472524+ItsTLeo@users.noreply.github.com> Co-authored-by: Jerome Berclaz <jerome@percipient.ai> Co-authored-by: hcbille <32437363+hcbille@users.noreply.github.com> Co-authored-by: adiabatic <adiabatic@users.noreply.github.com> Co-authored-by: seflm <marek.sefl@seznam.cz> Co-authored-by: arnstadm <45672752+arnstadm@users.noreply.github.com> Co-authored-by: Xelus22 <17491233+Xelus22@users.noreply.github.com> Co-authored-by: Mike Cramer <dotHTM@users.noreply.github.com> Co-authored-by: drewpyun <48503175+drewpyun@users.noreply.github.com> Co-authored-by: spbgzh <72414103+spbgzh@users.noreply.github.com> Co-authored-by: tan-t <22813443+tan-t@users.noreply.github.com> Co-authored-by: Alfredo Colas Gullon <57442104+LyricPants66133@users.noreply.github.com> Co-authored-by: jack <0x6A73@pm.me> Co-authored-by: Cole Smith <smithcole@protonmail.com> Co-authored-by: peepeetee <43021794+peepeetee@users.noreply.github.com> Co-authored-by: Yak <68242321+yakMM@users.noreply.github.com> Co-authored-by: DUILCHOI <48977039+duilchoi@users.noreply.github.com> Co-authored-by: Kumiko as a Service <Dreista@users.noreply.github.com> Co-authored-by: yulei <yuleiz@gmail.com> Co-authored-by: jestercore <33821148+jestercore@users.noreply.github.com> Co-authored-by: cole smith <38364556+daysgobye@users.noreply.github.com> Co-authored-by: wb-joy <chang.li@westberrytech.com> Co-authored-by: Joy Lee <joylee.lc@foxmail.com> Co-authored-by: Rico <95101980+mymakercorner@users.noreply.github.com> Co-authored-by: harveysch <126267034+harveysch@users.noreply.github.com> Co-authored-by: Thomas Baart <mail@thomasbaart.nl> Co-authored-by: era <73109780+eerraa@users.noreply.github.com> Co-authored-by: Álvaro Cortés <alvarocortesdevesa@gmail.com> Co-authored-by: Álvaro Cortés Devesa <alvarocortesdevesa@Alvaros-MacBook-Pro.local> Co-authored-by: Leon Anavi <leon@anavi.org> Co-authored-by: 3geek14 <nerd.of.pi@gmail.com> Co-authored-by: Synth and Keys <117340582+Synth-and-Keys@users.noreply.github.com> Co-authored-by: Hugh Rawlinson <hughrawlinson@users.noreply.github.com> Co-authored-by: gskygithub <106651989+gskygithub@users.noreply.github.com> Co-authored-by: gksygithub <106651989+gksygithub@users.noreply.github.com> Co-authored-by: Brian McKenna <brian@brianmckenna.org> Co-authored-by: Richard Baptist <rpbaptist@users.noreply.github.com> Co-authored-by: Richard Baptist <richard@remote.com> Co-authored-by: Janat Taerakul <janat.taerakul@gmail.com> Co-authored-by: Janat Taerakul <jtaerakul@indeed.com> Co-authored-by: Yizhen Liu <62583086+edwardslau@users.noreply.github.com> Co-authored-by: Dane Lipscombe <danelipscombe@gmail.com> Co-authored-by: Joe Scotto <8194147+joe-scotto@users.noreply.github.com> Co-authored-by: Powered by Porridge <11315349+PoweredByPorridge@users.noreply.github.com>
zaih-ge
pushed a commit
to zaih-ge/qmk_firmware
that referenced
this pull request
Aug 31, 2023
Apparently layouts with 2u keys were not correctly converted into the `info.json` format (the old C layout macros used the arguments for such keys multiple times to cover all possible 1u locations; this is not supported in `info.json`, and the single matrix location for 2u keys was chosen incorrectly in some cases). Fix the layout definitions to match the real PCB wiring.
autoferrit
pushed a commit
to SpaceRockMedia/bastardkb-qmk
that referenced
this pull request
Dec 8, 2023
Apparently layouts with 2u keys were not correctly converted into the `info.json` format (the old C layout macros used the arguments for such keys multiple times to cover all possible 1u locations; this is not supported in `info.json`, and the single matrix location for 2u keys was chosen incorrectly in some cases). Fix the layout definitions to match the real PCB wiring.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Apparently layouts with 2u keys were not correctly converted into the
info.jsonformat in #20183 (the old C layout macros used the arguments for such keys multiple times to cover all possible 1u locations; this is not supported ininfo.json(#20039), and the single matrix location for 2u keys was chosen incorrectly in some cases). Fix the layout definitions to match the real PCB wiring.The changes should match the VIA definition for Preonic rev3 (the USB IDs are the same for
preonic/rev3andpreonic/rev3_drop):Types of Changes
Issues Fixed or Closed by This PR
LAYOUT_preonic_2x2ubuilt at config.qmk fm did not work (the 2u keys were not mapped correctly): https://discord.com/channels/440868230475677696/473506116718952450/1114021917469462589Checklist