Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add Skyloong/GK61_V1 keyboard #21364

Merged
merged 52 commits into from
Oct 4, 2023
Merged

add Skyloong/GK61_V1 keyboard #21364

merged 52 commits into from
Oct 4, 2023

Conversation

JZ-Skyloong
Copy link
Contributor

Description

add skyloong/GK61_V1 keyboard

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

noroadsleft and others added 18 commits June 16, 2023 20:04
@noroadsleft @JZ-Skyloong
Alas: OK----ISO Layouts Fix and Matrix Diagram (qmk#21255)
901e7a7
@JZ-Skyloong
added templete files to GK61
03406e7
@JZ-Skyloong
OK-----create gk61 layout in info.json
eeb34e5
@JZ-Skyloong
create GK61 default keymap
1def7c7
@JZ-Skyloong
Pass key Function test
2aef0cf
@JZ-Skyloong
create via keymap for GK61
5f5c51d
@JZ-Skyloong
added RGB matrix function with IS31F3733 IC in GK61 firmware
b6ce698
@JZ-Skyloong
move RGB_matrix_EFFECTS setting from config.h to info.json
f886fd0
@JZ-Skyloong
move RGB matrix effects from config.h to info.json; move RGB matrix l…
62483e7 
…ayout from gk61.c to info.json.
@JZ-Skyloong
add LAYOUT_space_long / LAYOUT_space_split key layout in info.json
2a98a30
@JZ-Skyloong
edit readme.md -- add image to GK61
0e86582
@JZ-Skyloong
formatting for info.json of GK61
b65847c
@JZ-Skyloong
add encoder setting to info.json
8b0b27f
@JZ-Skyloong
set RGB matrix driver--CKLED2001 success.
eeb7aea
@JZ-Skyloong
add RGB matirx frame effects
7dc5148
@JZ-Skyloong
add typing heatmap and digital rain effects
1fe4c8c
@JZ-Skyloong
add v1 config
2aad287
@JZ-Skyloong
Merge branch 'master' into test2
ac36ab4
@github-actions github-actions bot added keyboard keymap via Adds via keymap and/or updates keyboard for via support labels Jun 24, 2023
zvecr
zvecr requested changes Jun 24, 2023
View reviewed changes
keyboards/skyloong/gk61/v1/rules.mk Outdated Show resolved Hide resolved
keyboards/skyloong/gk61/v1/v1.c Outdated Show resolved Hide resolved
keyboards/skyloong/gk61/v1/mcuconf.h Outdated Show resolved Hide resolved
keyboards/skyloong/gk61/v1/v1.c Outdated Show resolved Hide resolved
keyboards/skyloong/gk61/v1/mcuconf.h Outdated Show resolved Hide resolved
keyboards/skyloong/gk61/v1/info.json Outdated Show resolved Hide resolved
keyboards/skyloong/gk61/v1/halconf.h Outdated Show resolved Hide resolved
keyboards/skyloong/gk61/v1/mcuconf.h Outdated Show resolved Hide resolved
keyboards/skyloong/gk61/v1/config.h Outdated Show resolved Hide resolved
keyboards/skyloong/gk61/v1/config.h Outdated Show resolved Hide resolved
JZ-Skyloong and others added 8 commits June 26, 2023 10:20
@JZ-Skyloong @zvecr
Update keyboards/skyloong/gk61/v1/config.h
8ee13a8 
OK, Thank you for your suggestion.

Co-authored-by: Joel Challis <git@zvecr.com>
@JZ-Skyloong @zvecr
Update keyboards/skyloong/gk61/v1/mcuconf.h
26aa4db 
OK, Thank you for your suggestion.

Co-authored-by: Joel Challis <git@zvecr.com>
@JZ-Skyloong @zvecr
Update keyboards/skyloong/gk61/v1/rules.mk
65824ae 
OK, thanks.

Co-authored-by: Joel Challis <git@zvecr.com>
@JZ-Skyloong @zvecr
Update keyboards/skyloong/gk61/v1/v1.c
229f320 
OK, I agree with you. thank you.

Co-authored-by: Joel Challis <git@zvecr.com>
@JZ-Skyloong @zvecr
Update keyboards/skyloong/gk61/v1/mcuconf.h
41a710e 
OK, thank you for your suggestion.

Co-authored-by: Joel Challis <git@zvecr.com>
@JZ-Skyloong @zvecr
Update keyboards/skyloong/gk61/v1/v1.c
c175ba6 
OK, thank you.

Co-authored-by: Joel Challis <git@zvecr.com>
@JZ-Skyloong @zvecr
Update keyboards/skyloong/gk61/v1/mcuconf.h
7d5379c 
OK, thank you.

Co-authored-by: Joel Challis <git@zvecr.com>
@JZ-Skyloong @zvecr
Update keyboards/skyloong/gk61/v1/halconf.h
15dca61 
OK, thanks.

Co-authored-by: Joel Challis <git@zvecr.com>
drashna
drashna reviewed Aug 30, 2023
View reviewed changes
keyboards/skyloong/gk61/v1/info.json Outdated Show resolved Hide resolved
keyboards/skyloong/gk61/v1/v1.c Outdated Show resolved Hide resolved
zvecr
zvecr requested changes Sep 9, 2023
View reviewed changes
keyboards/skyloong/gk61/v1/v1.c Outdated Show resolved Hide resolved
@JZ-Skyloong @zvecr
Update keyboards/skyloong/gk61/v1/v1.c
4fb0db8 
OK,Thank you for your suggestion.

Co-authored-by: Joel Challis <git@zvecr.com>
dunk2k
dunk2k suggested changes Oct 1, 2023
View reviewed changes
keyboards/skyloong/gk61/v1/info.json Outdated Show resolved Hide resolved
keyboards/skyloong/gk61/v1/info.json Outdated Show resolved Hide resolved
keyboards/skyloong/gk61/v1/v1.c Outdated Show resolved Hide resolved
keyboards/skyloong/gk61/v1/v1.c Show resolved Hide resolved
JZ-Skyloong and others added 4 commits October 4, 2023 10:09
@JZ-Skyloong @dunk2k
Update keyboards/skyloong/gk61/v1/info.json
f58850e 
OK, Thanks.

Co-authored-by: Duncan Sutherland <dunk2k_2000@hotmail.com>
@JZ-Skyloong @dunk2k
Update keyboards/skyloong/gk61/v1/info.json
30da711 
OK, Thanks.

Co-authored-by: Duncan Sutherland <dunk2k_2000@hotmail.com>
@JZ-Skyloong @dunk2k
Update keyboards/skyloong/gk61/v1/v1.c
9f70418 
OK,Thanks.

Co-authored-by: Duncan Sutherland <dunk2k_2000@hotmail.com>
@JZ-Skyloong @dunk2k
Update keyboards/skyloong/gk61/v1/v1.c
9281eac 
OK,Thanks.

Co-authored-by: Duncan Sutherland <dunk2k_2000@hotmail.com>
@drashna
Copy link
Member

drashna commented Oct 4, 2023

CI failure is related to brandonschlack-ansi. Otherwise LGTM.

@drashna drashna merged commit 2ba0a75 into qmk:develop Oct 4, 2023
2 of 3 checks passed
@JZ-Skyloong JZ-Skyloong deleted the gk61_v1 branch October 5, 2023 07:15
mechlovin pushed a commit to mechlovin/qmk_firmware that referenced this pull request Oct 25, 2023
@JZ-Skyloong @mechlovin
add Skyloong/GK61_V1 keyboard (qmk#21364)
c39233c 
Co-authored-by: Joel Challis <git@zvecr.com>
Co-authored-by: Sergey Vlasov <sigprof@gmail.com>
Co-authored-by: Drashna Jaelre <drashna@live.com>
Co-authored-by: Duncan Sutherland <dunk2k_2000@hotmail.com>
Co-authored-by: James Young <18669334+noroadsleft@users.noreply.github.com>
Fix and Matrix Diagram (qmk#21255)
christrotter pushed a commit to christrotter/qmk_firmware that referenced this pull request Nov 28, 2023
@JZ-Skyloong @christrotter
add Skyloong/GK61_V1 keyboard (qmk#21364)
4ced0c5 
Co-authored-by: Joel Challis <git@zvecr.com>
Co-authored-by: Sergey Vlasov <sigprof@gmail.com>
Co-authored-by: Drashna Jaelre <drashna@live.com>
Co-authored-by: Duncan Sutherland <dunk2k_2000@hotmail.com>
Co-authored-by: James Young <18669334+noroadsleft@users.noreply.github.com>
Fix and Matrix Diagram (qmk#21255)
@JZ-Skyloong JZ-Skyloong mentioned this pull request Dec 2, 2023
Merged
7 tasks
zgagnon pushed a commit to zgagnon/qmk_firmware_waterfowl that referenced this pull request Dec 15, 2023
@JZ-Skyloong @zgagnon
add Skyloong/GK61_V1 keyboard (qmk#21364)
901d0f4 
Co-authored-by: Joel Challis <git@zvecr.com>
Co-authored-by: Sergey Vlasov <sigprof@gmail.com>
Co-authored-by: Drashna Jaelre <drashna@live.com>
Co-authored-by: Duncan Sutherland <dunk2k_2000@hotmail.com>
Co-authored-by: James Young <18669334+noroadsleft@users.noreply.github.com>
Fix and Matrix Diagram (qmk#21255)
future-figs pushed a commit to future-figs/qmk_firmware that referenced this pull request Dec 27, 2023
@JZ-Skyloong
add Skyloong/GK61_V1 keyboard (qmk#21364)
74fcc0c 
Co-authored-by: Joel Challis <git@zvecr.com>
Co-authored-by: Sergey Vlasov <sigprof@gmail.com>
Co-authored-by: Drashna Jaelre <drashna@live.com>
Co-authored-by: Duncan Sutherland <dunk2k_2000@hotmail.com>
Co-authored-by: James Young <18669334+noroadsleft@users.noreply.github.com>
Fix and Matrix Diagram (qmk#21255)
mute-civilian pushed a commit to mute-civilian/qmk_firmware that referenced this pull request Feb 17, 2024
@JZ-Skyloong
add Skyloong/GK61_V1 keyboard (qmk#21364)
6dad599 
Co-authored-by: Joel Challis <git@zvecr.com>
Co-authored-by: Sergey Vlasov <sigprof@gmail.com>
Co-authored-by: Drashna Jaelre <drashna@live.com>
Co-authored-by: Duncan Sutherland <dunk2k_2000@hotmail.com>
Co-authored-by: James Young <18669334+noroadsleft@users.noreply.github.com>
Fix and Matrix Diagram (qmk#21255)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dunk2k dunk2k dunk2k requested changes

@drashna drashna drashna approved these changes

@sigprof sigprof Awaiting requested review from sigprof

@zvecr zvecr Awaiting requested review from zvecr

Assignees
No one assigned
Labels
keyboard keymap via Adds via keymap and/or updates keyboard for via support
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@JZ-Skyloong @dunk2k @drashna @sigprof @zvecr @noroadsleft