Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow the user to select a single tone for the additive DAC #21591

Merged
merged 1 commit into from
Jul 23, 2023

Commits on Jul 23, 2023

  1. Allow the user to select one tone for the additive DAC

    Previously, if the user tried to use `#define AUDIO_MAX_SIMULTANEOUS_TONES 1` to conserve CPU time, their firmware would fail to build with this error:
    
    ```
    platforms/chibios/drivers/audio_dac_additive.c:91:73: error: excess elements in array initializer [-Werror]
       91 | static float   active_tones_snapshot[AUDIO_MAX_SIMULTANEOUS_TONES] = {0, 0};
          |                                                                          ^
    ```
    
    This also affected the preset `#define AUDIO_DAC_QUALITY_VERY_HIGH`, which called up only one simultaneous tone at 88200 Hz.
    Nebuleon committed Jul 23, 2023
    Configuration menu
    Copy the full SHA
    b45a902 View commit details
    Browse the repository at this point in the history