-
-
Notifications
You must be signed in to change notification settings - Fork 39.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change to development_board
#21695
Change to development_board
#21695
Conversation
Not a good idea to perform this conversion blindly. The very first PCB modified in this submission (Acheron Project Shark, alpha version) cannot use the Proton-C dev board pinout per its schematic. |
development_board
where matchingdevelopment_board
where matching
appreciate the heads up @lesshonor |
It sets up a bunch of stuff I'll admit I don't fully understand. It seems possible that this is a non-ideal-but-currently-needed value to use for this keyboard, the same way I couldn't get |
Switching the configuration to |
Past history and all, reverting the proton_c development_board change until research denotes which boards are actual proton_c |
Thank you for your contribution! |
Bump |
development_board
where matchingdevelopment_board
Conflict resolution aside, I think it would be a good idea to provide supporting evidence for these changes. For example: indicating where you found the information for each keyboard, or perhaps calculating SHAs which indicate the binaries are unchanged from the last commit you end up rebasing on. The benefit of switching to |
revert mechwild/bbs in favour of qmk#23373
This comment was marked as outdated.
This comment was marked as outdated.
I went through all of them and they all seemed fine to me. |
Description
changed keyboard to
development_board
, wherereadme.md
or public accessible material(s) identify.Development boards in scope:
Types of Changes
Issues Fixed or Closed by This PR
Checklist