Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change to development_board #21695

Merged
merged 31 commits into from
Apr 23, 2024
Merged

Change to development_board #21695

merged 31 commits into from
Apr 23, 2024

Conversation

dunk2k
Copy link
Contributor

@dunk2k dunk2k commented Aug 4, 2023

Description

changed keyboard to development_board, where readme.md or public accessible material(s) identify.
Development boards in scope:

  • blackpill_f401
  • blackpill_f411
  • bluepill
  • proton_c

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

  • n/a

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@lesshonor
Copy link
Contributor

Not a good idea to perform this conversion blindly. The very first PCB modified in this submission (Acheron Project Shark, alpha version) cannot use the Proton-C dev board pinout per its schematic.

@dunk2k dunk2k changed the title Migrate to development_board where matching Change to development_board where matching Aug 4, 2023
@dunk2k
Copy link
Contributor Author

dunk2k commented Aug 4, 2023

Not a good idea to perform this conversion blindly. The very first PCB modified in this submission (Acheron Project Shark, alpha version) cannot use the Proton-C dev board pinout per its schematic.

appreciate the heads up @lesshonor
On the subject of the acheron/shark/alpha - if it cannot use the Proton-C dev board, then to what purpose is "board": "QMK_PROTON_C" specified in info.json?

@lesshonor
Copy link
Contributor

appreciate the heads up @lesshonor On the subject of the acheron/shark/alpha - if it cannot use the Proton-C dev board, then to what purpose is "board": "QMK_PROTON_C" specified in info.json?

It sets up a bunch of stuff I'll admit I don't fully understand. It seems possible that this is a non-ideal-but-currently-needed value to use for this keyboard, the same way I couldn't get ymdk/id75 to compile without setting board to STM32_F103_STM32DUINO.

@dunk2k dunk2k marked this pull request as ready for review August 5, 2023 11:26
@sigprof
Copy link
Contributor

sigprof commented Aug 5, 2023

"board": "QMK_PROTON_C" in many STM32F303-based keyboards probably comes from #10976. Before that PR the default ChibiOS configuration for STM32F303 had most peripherals enabled by default; then #10976 introduced the QMK_PROTON_C board, which had most peripherals enabled, and switched the GENERIC_STM32_F303XC board to have all peripherals disabled; however, the same PR also added BOARD = QMK_PROTON_C to all previously existing STM32F303-based keyboards, so that the existing code would continue to work exactly as before. Because of that, there are lots of keyboards which use the Proton C configuration, even though the actual hardware does not use the Proton C controller.

Switching the configuration to "development_board": "proton_c" for boards which don't actually use the Proton C controller still looks wrong (although it won't actually permit nonsensical conversions just yet, because the current converter support cannot handle conversion from Proton C to anything else — only promicro and elite_c controllers are supported as conversion sources).

@dunk2k
Copy link
Contributor Author

dunk2k commented Aug 5, 2023

Past history and all, reverting the proton_c development_board change until research denotes which boards are actual proton_c

Copy link

github-actions bot commented Dec 2, 2023

Thank you for your contribution!
This pull request has been automatically marked as stale because it has not had activity in the last 45 days. It will be closed in 30 days if no further activity occurs. Please feel free to give a status update now, or re-open when it's ready.
For maintainers: Please label with bug, awaiting review, breaking_change, in progress, or on hold to prevent the issue from being re-flagged.

@github-actions github-actions bot added the stale Issues or pull requests that have become inactive without resolution. label Dec 2, 2023
@dunk2k
Copy link
Contributor Author

dunk2k commented Dec 2, 2023

Bump

@github-actions github-actions bot removed the stale Issues or pull requests that have become inactive without resolution. label Dec 4, 2023
@dunk2k dunk2k changed the title Change to development_board where matching Change to development_board Dec 5, 2023
@drashna drashna requested a review from a team January 14, 2024 22:05
keyboards/yanghu/unicorne/f411/info.json Outdated Show resolved Hide resolved
@dunk2k dunk2k requested a review from zvecr March 15, 2024 00:46
@lesshonor
Copy link
Contributor

lesshonor commented Mar 15, 2024

Conflict resolution aside, I think it would be a good idea to provide supporting evidence for these changes. For example: indicating where you found the information for each keyboard, or perhaps calculating SHAs which indicate the binaries are unchanged from the last commit you end up rebasing on.

The benefit of switching to development_board is currently small compared to the negative impact of getting things wrong. Sharing your research/findings would help others more easily verify their correctness.

@fauxpark fauxpark merged commit 32136af into qmk:develop Apr 23, 2024
1 of 3 checks passed
@dunk2k dunk2k deleted the dev_board branch April 23, 2024 09:53
@zvecr

This comment was marked as outdated.

@fauxpark
Copy link
Member

I went through all of them and they all seemed fine to me.

whoisjordangarcia pushed a commit to whoisjordangarcia/qmk_firmware that referenced this pull request Jun 8, 2024
nuess0r pushed a commit to nuess0r/qmk_firmware that referenced this pull request Sep 8, 2024
Ardakilic pushed a commit to Ardakilic/qmk_firmware that referenced this pull request Sep 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants