Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

1UpKeyboards Pi60 Layout Additions #21874

Merged
merged 14 commits into from
Sep 1, 2023
Merged

1UpKeyboards Pi60 Layout Additions #21874

merged 14 commits into from
Sep 1, 2023

Conversation

noroadsleft
Copy link
Member

Description

Standardizes the layout macros. Current LAYOUT_60_ansi isn't actually a standard 60% ANSI layout.

Renames one layout macro and adds eight more.

cc @ziptyze (keyboard maintainer)

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@noroadsleft noroadsleft added enhancement keyboard keymap via Adds via keymap and/or updates keyboard for via support labels Aug 31, 2023
@noroadsleft noroadsleft requested a review from a team August 31, 2023 09:09
@noroadsleft noroadsleft merged commit faa7c1a into qmk:develop Sep 1, 2023
2 of 3 checks passed
@noroadsleft noroadsleft deleted the rf/1upkeyboards_pi60 branch September 1, 2023 05:34
dunk2k pushed a commit to dunk2k/qmk_firmware that referenced this pull request Sep 5, 2023
@noroadsleft @dunk2k
1UpKeyboards Pi60 Layout Additions (qmk#21874)
b80f962 
* [refactor] rename LAYOUT_60_ansi to LAYOUT_all

* [enhancement] add LAYOUT_60_ansi

* [enhancement] add LAYOUT_60_ansi_split_bs_rshift

* [enhancement] add LAYOUT_60_ansi_tsangan

* [enhancement] add LAYOUT_60_tsangan_hhkb

* [enhancement] add LAYOUT_60_iso

* [enhancement] add LAYOUT_60_iso_split_bs_rshift

* [enhancement] add LAYOUT_60_iso_tsangan

* [enhancement] add LAYOUT_60_iso_tsangan_split_bs_rshift

* [enhancement] enable Community Layout support

* [enhancement] add LAYOUT_60_hhkb

* [enhancement] add LAYOUT_60_ansi_arrow

* [enhancement] add LAYOUT_60_iso_arrow

* [docs] add layout/matrix diagram
mechlovin pushed a commit to mechlovin/qmk_firmware that referenced this pull request Oct 25, 2023
@noroadsleft @mechlovin
1UpKeyboards Pi60 Layout Additions (qmk#21874)
b3704a0 
* [refactor] rename LAYOUT_60_ansi to LAYOUT_all

* [enhancement] add LAYOUT_60_ansi

* [enhancement] add LAYOUT_60_ansi_split_bs_rshift

* [enhancement] add LAYOUT_60_ansi_tsangan

* [enhancement] add LAYOUT_60_tsangan_hhkb

* [enhancement] add LAYOUT_60_iso

* [enhancement] add LAYOUT_60_iso_split_bs_rshift

* [enhancement] add LAYOUT_60_iso_tsangan

* [enhancement] add LAYOUT_60_iso_tsangan_split_bs_rshift

* [enhancement] enable Community Layout support

* [enhancement] add LAYOUT_60_hhkb

* [enhancement] add LAYOUT_60_ansi_arrow

* [enhancement] add LAYOUT_60_iso_arrow

* [docs] add layout/matrix diagram
zgagnon pushed a commit to zgagnon/qmk_firmware_waterfowl that referenced this pull request Dec 15, 2023
@noroadsleft @zgagnon
1UpKeyboards Pi60 Layout Additions (qmk#21874)
7db8d45 
* [refactor] rename LAYOUT_60_ansi to LAYOUT_all

* [enhancement] add LAYOUT_60_ansi

* [enhancement] add LAYOUT_60_ansi_split_bs_rshift

* [enhancement] add LAYOUT_60_ansi_tsangan

* [enhancement] add LAYOUT_60_tsangan_hhkb

* [enhancement] add LAYOUT_60_iso

* [enhancement] add LAYOUT_60_iso_split_bs_rshift

* [enhancement] add LAYOUT_60_iso_tsangan

* [enhancement] add LAYOUT_60_iso_tsangan_split_bs_rshift

* [enhancement] enable Community Layout support

* [enhancement] add LAYOUT_60_hhkb

* [enhancement] add LAYOUT_60_ansi_arrow

* [enhancement] add LAYOUT_60_iso_arrow

* [docs] add layout/matrix diagram
future-figs pushed a commit to future-figs/qmk_firmware that referenced this pull request Dec 27, 2023
@noroadsleft
1UpKeyboards Pi60 Layout Additions (qmk#21874)
935ed45 
* [refactor] rename LAYOUT_60_ansi to LAYOUT_all

* [enhancement] add LAYOUT_60_ansi

* [enhancement] add LAYOUT_60_ansi_split_bs_rshift

* [enhancement] add LAYOUT_60_ansi_tsangan

* [enhancement] add LAYOUT_60_tsangan_hhkb

* [enhancement] add LAYOUT_60_iso

* [enhancement] add LAYOUT_60_iso_split_bs_rshift

* [enhancement] add LAYOUT_60_iso_tsangan

* [enhancement] add LAYOUT_60_iso_tsangan_split_bs_rshift

* [enhancement] enable Community Layout support

* [enhancement] add LAYOUT_60_hhkb

* [enhancement] add LAYOUT_60_ansi_arrow

* [enhancement] add LAYOUT_60_iso_arrow

* [docs] add layout/matrix diagram
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drashna drashna drashna approved these changes

@fauxpark fauxpark fauxpark approved these changes

@dunk2k dunk2k dunk2k approved these changes

Assignees
No one assigned
Labels
enhancement keyboard keymap via Adds via keymap and/or updates keyboard for via support
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@noroadsleft @drashna @fauxpark @dunk2k