Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Keychron Q1v1 #21993

Merged
merged 19 commits into from
Oct 4, 2023
Merged

Update Keychron Q1v1 #21993

merged 19 commits into from
Oct 4, 2023

Conversation

adophoxia
Copy link
Contributor

Description

Superseeds #21406, but this will only cover one board from each series update of PRs. After this is made, 21406 will be closed to make things more simpler.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@github-actions github-actions bot added keyboard keymap via Adds via keymap and/or updates keyboard for via support labels Sep 13, 2023
drashna
drashna requested changes Sep 23, 2023
View reviewed changes
Copy link
Member

@drashna drashna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

needs an entry in /data/mapping/keyboard_aliases.hjson

keyboards/keychron/q1v1/q1.c Outdated Show resolved Hide resolved
@github-actions github-actions bot added the dd Data Driven Changes label Sep 25, 2023
@adophoxia adophoxia requested a review from drashna September 25, 2023 02:41
@drashna drashna requested a review from a team September 25, 2023 06:22
@adophoxia
Copy link
Contributor Author

Since the LED driver for this board uses is32fl3733, do I also need to have:

#define DRIVER_ADDR_1 IS31FL3733_I2C_ADDRESS_GND_GND
#define DRIVER_ADDR_2 IS31FL3733_I2C_ADDRESS_GND_VCC

as well?

@adophoxia adophoxia requested a review from drashna September 26, 2023 04:32
drashna
drashna reviewed Sep 29, 2023
View reviewed changes
Copy link
Member

@drashna drashna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you could, yeah?

@adophoxia
Copy link
Contributor Author

Added IS32FL3733_I2C_ADDRESS names in recent commit.

@adophoxia adophoxia requested a review from drashna September 30, 2023 02:06
@drashna drashna merged commit 38f89df into qmk:develop Oct 4, 2023
mechlovin pushed a commit to mechlovin/qmk_firmware that referenced this pull request Oct 25, 2023
@adophoxia @drashna @mechlovin
Update Keychron Q1v1 (qmk#21993)
e27045b 
Co-authored-by: Drashna Jaelre <drashna@live.com>
christrotter pushed a commit to christrotter/qmk_firmware that referenced this pull request Nov 28, 2023
@adophoxia @drashna @christrotter
Update Keychron Q1v1 (qmk#21993)
c856f36 
Co-authored-by: Drashna Jaelre <drashna@live.com>
zgagnon pushed a commit to zgagnon/qmk_firmware_waterfowl that referenced this pull request Dec 15, 2023
@adophoxia @drashna @zgagnon
Update Keychron Q1v1 (qmk#21993)
c7f06bb 
Co-authored-by: Drashna Jaelre <drashna@live.com>
future-figs pushed a commit to future-figs/qmk_firmware that referenced this pull request Dec 27, 2023
@adophoxia @drashna
Update Keychron Q1v1 (qmk#21993)
a23ecc4 
Co-authored-by: Drashna Jaelre <drashna@live.com>
@fauxpark fauxpark mentioned this pull request Jan 7, 2024
Merged
14 tasks
mute-civilian pushed a commit to mute-civilian/qmk_firmware that referenced this pull request Feb 17, 2024
@adophoxia @drashna
Update Keychron Q1v1 (qmk#21993)
60ee8a6 
Co-authored-by: Drashna Jaelre <drashna@live.com>
@adophoxia adophoxia deleted the keychron-q1v1-update branch June 27, 2024 01:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drashna drashna drashna approved these changes

Assignees
No one assigned
Labels
dd Data Driven Changes keyboard keymap via Adds via keymap and/or updates keyboard for via support
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@adophoxia @drashna