YMDK Melody96 Break-Up #22121
Merged
YMDK Melody96 Break-Up #22121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
keyboard
keymap
via
[enhancement]
Sort the existing keymaps into `hotswap` and `soldered` directories, as appropriate. [refactor]
Update the layout macro reference so the keymap compiles from the new location. [bugfix]
noroadsleft
force-pushed
the
dev/ymdk_melody96
branch
from
e49a47c
to
adb4a99
Compare
fauxpark
approved these changes
Sep 24, 2023
Map `ymdk/melody96` to `ymdk/melody96/soldered`. [enhancement]
dunk2k
approved these changes
Sep 24, 2023
drashna
approved these changes
Sep 25, 2023
|
CI failure is due to konstantine keymap, and lint errors are due to no licensing header in files not edited. |
mechlovin
pushed a commit
to mechlovin/qmk_firmware
that referenced
this pull request
Oct 25, 2023
christrotter
pushed a commit
to christrotter/qmk_firmware
that referenced
this pull request
Nov 28, 2023
zgagnon
pushed a commit
to zgagnon/qmk_firmware_waterfowl
that referenced
this pull request
Dec 15, 2023
future-figs
pushed a commit
to future-figs/qmk_firmware
that referenced
this pull request
Dec 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Splits support for Soldered and Hotswap Melody96s into separate directories.
zungerkeymap for Melody96 HotswapUpdate the layout macro reference so the keymap compiles from the new
location.
defaultandviakeymaps for Melody96 HotswapRequires #22113.
Types of Changes
Checklist