Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Diablo #22414
Add Diablo #22414
Changes from 11 commits
6822888
d77ff85
8cf4174
eb45a48
0520b06
698c797
2887fce
0422821
6437013
89b4ada
0e21661
f585a0a
a79e8e3
fb0f4ce
af1105f
c29a750
dc8cafa
8e16464
8dca3df
d143232
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looking at image provided in respective
readme.md
there appears to be support for more than one physical layout; image shows compatible60_ansi_wkl
Community Layout.Based on said image and current layout data, could the following Community Layouts (
layouts/default/
) be added?:There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Apparently the layout options available on the PCB are:
And providing the WKL versions of the corresponding layouts would make sense, because the only variant of the top case in the GB ended up being WKL.
So the list of layouts should probably be:
LAYOUT_60_ansi_wkl
LAYOUT_60_ansi_wkl_split_bs_rshift
LAYOUT_60_tsangan_hhkb
— aliased toLAYOUT_all
, includes all possible switch locations; buildable on the bare PCB, but won't fit into with the currently existing cases.There are no community WKL layouts which have only split Backspace or only split right Shift; the only example of a layout like that is
LAYOUT_60_ansi_wkl_split_rshift
inidb/idb_60
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@key10iq
Could Community Layout
60_ansi_tsangan
be added? (which is60_tsangan_hhkb
with 2u Backspace and 2.75u Right Shift)There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i don't think it's worth adding that many layouts at all, so no
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If the matrix co-ordinates for 2u Backspace and 2.75u Right Shift could be relayed/shared here, I'd be more than happy to code suggest the remaining supported layouts.