Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Align Dip Switch feature #22625

Merged
merged 1 commit into from
Dec 8, 2023
Merged

Align Dip Switch feature #22625

merged 1 commit into from
Dec 8, 2023

Conversation

zvecr
Copy link
Member

@zvecr zvecr commented Dec 8, 2023 •
edited
Loading

Description

Extracted from #22543.

  • Move dip switch count to header for later reuse
  • Rename from NUMBER_OF_ to NUM_ to align with encoder
  • Add _task()to match other features - also hiding the whole forced read concept from main loop

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@github-actions github-actions bot added core keyboard keymap documentation via Adds via keymap and/or updates keyboard for via support dependencies dd Data Driven Changes labels Dec 8, 2023
@zvecr zvecr changed the title Dip switch tidy Align Dip Switch feature Dec 8, 2023
@zvecr zvecr changed the base branch from master to develop December 8, 2023 00:12
@github-actions github-actions bot removed keyboard keymap documentation via Adds via keymap and/or updates keyboard for via support dependencies dd Data Driven Changes labels Dec 8, 2023
@zvecr zvecr merged commit 4224565 into develop Dec 8, 2023
4 checks passed
@zvecr zvecr deleted the dip_switch_tidy branch December 8, 2023 15:57
itsjonny96 pushed a commit to itsjonny96/qmk_firmware that referenced this pull request Jan 7, 2024
@zvecr @itsjonny96
Align Dip Switch feature (qmk#22625)
0429ca0
mechlovin pushed a commit to mechlovin/qmk_firmware that referenced this pull request Jan 17, 2024
@zvecr @mechlovin
Align Dip Switch feature (qmk#22625)
571f1bc
mechlovin pushed a commit to mechlovin/qmk_firmware that referenced this pull request Jan 19, 2024
@zvecr @mechlovin
Align Dip Switch feature (qmk#22625)
6fe7415
nuess0r pushed a commit to nuess0r/qmk_firmware that referenced this pull request Sep 8, 2024
@zvecr @nuess0r
Align Dip Switch feature (qmk#22625)
c395c9e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tzarc tzarc tzarc approved these changes

Assignees
No one assigned
Labels
core enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zvecr @tzarc