Noodlepad Additions and Updates #22701
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Modified this keyboard according to failed PR from the previous day with help from @sigprof
github-actions
bot
added
keyboard
keymap
via
This was referenced Dec 18, 2023
waffle87
requested changes
Dec 18, 2023
Co-authored-by: jack <0x6a73@protonmail.com>
Co-authored-by: jack <0x6a73@protonmail.com>
Co-authored-by: jack <0x6a73@protonmail.com>
Co-authored-by: jack <0x6a73@protonmail.com>
Nope, thats a hard blocker on the PR being mergable. |
What does that mean? What caused it? |
|
lib changes in fb05cce |
|
There is |
@adophoxia Well crap, can I do something about it??? |
|
@zvecr @adophoxia I reverted the commit. Should that fix it? |
This reverts commit 81dfa68.
@zvecr @adophoxia IT FIXED IT! We should be good now right? |
waffle87
reviewed
Dec 19, 2023
Co-authored-by: jack <0x6a73@protonmail.com>
waffle87
approved these changes
Dec 19, 2023
fauxpark
requested changes
Dec 20, 2023
Co-authored-by: Ryan <fauxpark@gmail.com>
Co-authored-by: Ryan <fauxpark@gmail.com>
Co-authored-by: Ryan <fauxpark@gmail.com>
Co-authored-by: Ryan <fauxpark@gmail.com>
Co-authored-by: Ryan <fauxpark@gmail.com>
14 tasks
drashna
approved these changes
Dec 23, 2023
fauxpark
approved these changes
Dec 23, 2023
itsjonny96
pushed a commit
to itsjonny96/qmk_firmware
that referenced
this pull request
Jan 7, 2024
Co-authored-by: jack <0x6a73@protonmail.com> Co-authored-by: Ryan <fauxpark@gmail.com>
mechlovin
pushed a commit
to mechlovin/qmk_firmware
that referenced
this pull request
Jan 17, 2024
Co-authored-by: jack <0x6a73@protonmail.com> Co-authored-by: Ryan <fauxpark@gmail.com>
mechlovin
pushed a commit
to mechlovin/qmk_firmware
that referenced
this pull request
Jan 19, 2024
Co-authored-by: jack <0x6a73@protonmail.com> Co-authored-by: Ryan <fauxpark@gmail.com>
nuess0r
pushed a commit
to nuess0r/qmk_firmware
that referenced
this pull request
Sep 8, 2024
Co-authored-by: jack <0x6a73@protonmail.com> Co-authored-by: Ryan <fauxpark@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modified this keyboard according to failed PR from the previous day with help from @sigprof
Description
Renaming
themadnoodle/noodlepadtothemadnoodle/noodlepad/v1and addedthemadnoodle/noodlepad/v2Updated the formatting to the current JSON QMK formatting to the best of my abilities.
Cleaned up keymaps and readmes
Got a HUGE amount of help from @sigprof via QMK Discord, so thank you so much!
I also have other PRs Open for:
Adding Keyboard The Mad Noodle Udon13 #22704
Added Keyboard Noodlepad_Micro #22703
Types of Changes
Issues Fixed or Closed by This PR
Checklist