Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added Skyloong/GK61 pro dual space keyboard. #22988

Open
wants to merge 36 commits into
base: develop
Choose a base branch
from
Open

Added Skyloong/GK61 pro dual space keyboard. #22988

wants to merge 36 commits into from
+543 −0

Conversation

NaturalZh
Copy link

GK61 pro double space keyboard

Description

The Skyloong GK61 PRO dual space key keyboard has two 3.125 split space bars. It can be replaced with a long space bar of 6.25.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@github-actions github-actions bot added keyboard keymap via Adds via keymap and/or updates keyboard for via support labels Jan 30, 2024
zvecr
zvecr requested changes Jan 30, 2024
View reviewed changes
NaturalZh and others added 4 commits January 31, 2024 14:17
@NaturalZh @zvecr
Update keyboards/skyloong/gk61/pro_ds/config.h
5f43527 
OK, Thank you.

Co-authored-by: Joel Challis <git@zvecr.com>
@NaturalZh @zvecr
Update keyboards/skyloong/gk61/pro_ds/pro_ds.c
d48b24b 
OK.

Co-authored-by: Joel Challis <git@zvecr.com>
@NaturalZh @zvecr
Update keyboards/skyloong/gk61/pro_ds/pro_ds.c
f438b2f 
OK.

Co-authored-by: Joel Challis <git@zvecr.com>
@NaturalZh
deleted keyboards/skyloong/gk61/pro_ds/keymaps/default/rules.mk.
a62a526
zvecr
zvecr requested changes Jan 31, 2024
View reviewed changes
@NaturalZh NaturalZh requested a review from zvecr March 4, 2024 03:27
@NaturalZh
Copy link
Author

What else can I do about merging PR?

@drashna drashna requested a review from a team March 29, 2024 01:34
fauxpark
fauxpark requested changes Mar 29, 2024
View reviewed changes
NaturalZh and others added 4 commits March 29, 2024 19:54
@NaturalZh @fauxpark
Update keyboards/skyloong/gk61/pro_ds/config.h
c654459 
OK. Thanks.

Co-authored-by: Ryan <fauxpark@gmail.com>
@NaturalZh @fauxpark
Update keyboards/skyloong/gk61/pro_ds/pro_ds.c
6d2b47b 
OK. Thanks.

Co-authored-by: Ryan <fauxpark@gmail.com>
@NaturalZh @fauxpark
Update keyboards/skyloong/gk61/pro_ds/pro_ds.c
0ef44f6 
OK, Thanks.

Co-authored-by: Ryan <fauxpark@gmail.com>
@NaturalZh
update skyloong/gk61/pro_ds/config.h
4f2e5d8
@NaturalZh
Copy link
Author

What can I do for this PR else ?

@qmk qmk deleted a comment from italovieira Apr 25, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 9, 2024

Thank you for your contribution!
This pull request has been automatically marked as stale because it has not had activity in the last 45 days. It will be closed in 30 days if no further activity occurs. Please feel free to give a status update now, or re-open when it's ready.
For maintainers: Please label with bug, awaiting review, breaking_change, in progress, or on hold to prevent the issue from being re-flagged.

@github-actions github-actions bot added the stale Issues or pull requests that have become inactive without resolution. label Jun 9, 2024
fauxpark
fauxpark requested changes Jun 11, 2024
View reviewed changes
@github-actions github-actions bot removed the stale Issues or pull requests that have become inactive without resolution. label Jun 12, 2024
@NaturalZh
Copy link
Author

Since we can't have keymaps called via anymore, can we rename via keymap to "expanded" or "feature"? I really liked the examples provided and don't want to lose them.
Is there a recommendation from the QMK team to have more full featured examples rather than just the default keymap which is bare bones?
@zvecr @fauxpark

I think maybe the via keymaps can be contributed in qmk_userspace_via repository . But it`s now read only.

You have to make the PR for the via keymap on the the-via/qmk_userspace_via repo actually as the one you linked to is used as an archive, @NaturalZh.

OK, I see. Thanks for informing us. It seem that it don`t accept PR at present. @adophoxia

@adophoxia
Copy link
Contributor

Since we can't have keymaps called via anymore, can we rename via keymap to "expanded" or "feature"? I really liked the examples provided and don't want to lose them.
Is there a recommendation from the QMK team to have more full featured examples rather than just the default keymap which is bare bones?
@zvecr @fauxpark

I think maybe the via keymaps can be contributed in qmk_userspace_via repository . But it`s now read only.

You have to make the PR for the via keymap on the the-via/qmk_userspace_via repo actually as the one you linked to is used as an archive, @NaturalZh.

OK, I see. Thanks for informing us. It seem that it don`t accept PR at present. @adophoxia

If we're still on the same page of https://github.com/the-via/qmk_userspace_via, then it does actually accept PRs.

@NaturalZh
Copy link
Author

Since we can't have keymaps called via anymore, can we rename via keymap to "expanded" or "feature"? I really liked the examples provided and don't want to lose them.
Is there a recommendation from the QMK team to have more full featured examples rather than just the default keymap which is bare bones?
@zvecr @fauxpark

I think maybe the via keymaps can be contributed in qmk_userspace_via repository . But it`s now read only.

You have to make the PR for the via keymap on the the-via/qmk_userspace_via repo actually as the one you linked to is used as an archive, @NaturalZh.

OK, I see. Thanks for informing us. It seem that it don`t accept PR at present. @adophoxia

If we're still on the same page of https://github.com/the-via/qmk_userspace_via, then it does actually accept PRs.

I submitted PR to try it out. Thank you. @adophoxia

@NaturalZh NaturalZh mentioned this pull request Aug 28, 2024
Open
@zvecr zvecr removed the via Adds via keymap and/or updates keyboard for via support label Aug 28, 2024
@NaturalZh @zvecr
Update keyboards/skyloong/gk61/pro_ds/config.h
3603918 
OK, thank you.

Co-authored-by: Joel Challis <git@zvecr.com>
@NaturalZh NaturalZh requested a review from zvecr August 30, 2024 00:09
@github-actions GitHub Actions
Copy link

Thank you for your contribution!
This pull request has been automatically marked as stale because it has not had activity in the last 45 days. It will be closed in 30 days if no further activity occurs. Please feel free to give a status update now, or re-open when it's ready.
For maintainers: Please label with bug, awaiting review, breaking_change, in progress, or on hold to prevent the issue from being re-flagged.

@github-actions github-actions bot added the stale Issues or pull requests that have become inactive without resolution. label Oct 14, 2024
@NaturalZh
Copy link
Author

Would you please review and merge this PR? Many thanks for your help @fauxpark @zvecr

@github-actions github-actions bot removed the stale Issues or pull requests that have become inactive without resolution. label Oct 15, 2024
@hitsmaxft

This comment was marked as off-topic.

Sign in to view
@NaturalZh
Copy link
Author

NaturalZh commented Oct 25, 2024 •
edited
Loading

is there any chance to add gk61x support for qmk， i need the pin information to do the rest job，compile qmk without ble support not a big issue

The GK61X keyboard was developed using chips other than QMk supported chipsets and may not currently support QMK firmware development. We have developed the GK61 QMK keyboard. You can find them in Skyloong QMK keyboard.

@NaturalZh
Copy link
Author

Who can merge this pull requese? Thank you.

fauxpark
fauxpark requested changes Nov 22, 2024
View reviewed changes
Copy link
Member

@fauxpark fauxpark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RGB_ -> RM_ keycodes after this round of breaking changes.

@NaturalZh NaturalZh requested a review from fauxpark November 28, 2024 02:50
@NaturalZh
Copy link
Author

Would you please merge this PR @fauxpark @zvecr

@github-actions GitHub Actions
Copy link

Thank you for your contribution!
This pull request has been automatically marked as stale because it has not had activity in the last 45 days. It will be closed in 30 days if no further activity occurs. Please feel free to give a status update now, or re-open when it's ready.
For maintainers: Please label with bug, awaiting review, breaking_change, in progress, or on hold to prevent the issue from being re-flagged.

@github-actions github-actions bot added the stale Issues or pull requests that have become inactive without resolution. label Jan 13, 2025
@NaturalZh
Copy link
Author

[ :-(
What a pity! What else can I do?

@github-actions github-actions bot removed the stale Issues or pull requests that have become inactive without resolution. label Jan 14, 2025
fauxpark
fauxpark requested changes Jan 14, 2025
View reviewed changes
drashna
drashna requested changes Jan 14, 2025
View reviewed changes
NaturalZh and others added 2 commits January 14, 2025 14:17
@NaturalZh @fauxpark
Update keyboards/skyloong/gk61/pro_ds/config.h
046e39d 
OK, thank you.

Co-authored-by: Ryan <fauxpark@gmail.com>
@NaturalZh @drashna
Update keyboards/skyloong/gk61/pro_ds/mcuconf.h
120c869 
I'm not sure if DMA will work either. Anyway, I accept your suggestion.

Co-authored-by: Drashna Jaelre <drashna@live.com>
@NaturalZh
Copy link
Author

What else can I do and who can merge it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iamdanielv iamdanielv iamdanielv left review comments

@drashna drashna drashna requested changes

@fauxpark fauxpark fauxpark requested changes

@zvecr zvecr Awaiting requested review from zvecr

Assignees
No one assigned
Labels
keyboard keymap
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@NaturalZh @iamdanielv @adophoxia @hitsmaxft @drashna @fauxpark @zvecr