-
-
Notifications
You must be signed in to change notification settings - Fork 39.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge ChibiOS and LUFA descriptor support #2362
Conversation
Lufa USB descriptors for ChibiOS
Use the default lufa header files
This is completely untested
It didn't work properly when both Midi and Virtual serial port was enabled.
This makes the initialization much more simple and eliminates a lot of the code duplication.
To include the usb data toggle synchronization fixes
Maybe I'm reading the diffs wrong, but it seems that this bit I added has been lost:
Comments explain why it should be kept. |
@Wilba6582, that part is still there, unchanged https://github.com/qmk/qmk_firmware/pull/2362/files#diff-66e939c937b5f0ef05ea673404726a34R138 The link didn't work, but it's collapsed by default, row 138 of the changed descriptor.h |
OK so I was reading diffs wrong. Nevermind. |
Awesome! Thanks :) |
This enables (at least) the following features on ChibiOS
It also fixes some keyboard descriptor fixes that were applied to LUFA, but not ChibiOS
Additionally the USB code now mostly uses a slightly patched CDC driver, so it's much more simple to follow and efficient.
The console output also uses that, which means that it's no longger dropping characters or even whole lines.
There's also some minor code cleanup and re-organization for the Midi support, so that the code can be shared.