Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add new keyboard Canary60RGB v2 #23916

Closed
wants to merge 1 commit into from
Closed

Add new keyboard Canary60RGB v2 #23916

wants to merge 1 commit into from

Conversation

AnthonyNguyen168
Copy link

@AnthonyNguyen168 AnthonyNguyen168 commented Jun 13, 2024 •
edited
Loading

Description

  • Add new version Canary60RGB v2 with new chipset RP2040.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

None

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@github-actions github-actions bot added keyboard keymap via Adds via keymap and/or updates keyboard for via support labels Jun 13, 2024
@zvecr zvecr changed the base branch from master to develop June 13, 2024 21:48
dunk2k
dunk2k suggested changes Jun 13, 2024
View reviewed changes
keyboards/canary/canary60rgb/v2/keyboard.json Outdated Show resolved Hide resolved
keyboards/canary/canary60rgb/v2/keyboard.json Outdated Show resolved Hide resolved
drashna
drashna requested changes Jun 14, 2024
View reviewed changes
keyboards/canary/canary60rgb/v2/config.h Outdated Show resolved Hide resolved
keyboards/canary/canary60rgb/v2/readme.md Outdated Show resolved Hide resolved
dunk2k
dunk2k suggested changes Jul 28, 2024
View reviewed changes
keyboards/canary/canary60rgb/v1/keyboard.json Show resolved Hide resolved
keyboards/canary/canary60rgb/v1/readme.md Outdated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image of this board (v1) would be helpful

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we will not include image of this board from now on. Because drashna recommend to rehost these images on Imgur or other hosting, which may not be as stable as github.

keyboards/canary/canary60rgb/v2/readme.md Show resolved Hide resolved
@dunk2k
Copy link
Contributor

dunk2k commented Jul 28, 2024

This PR's description to be corrected please 🙂

@AnthonyNguyen168
Copy link
Author

This PR's description to be corrected please 🙂

I corrected the description. Please check again. Thank you 🙂

@AnthonyNguyen168
Copy link
Author

Hi @drashna , @dunk2k ,
I corrected the description. Can you please check again?
Thanks a lot.

waffle87
waffle87 reviewed Aug 16, 2024
View reviewed changes
keyboards/canary/canary60rgb/v2/keyboard.json
"usb": {
"device_version": "0.0.2",
"vid": "0x4341",
"pid": "0x0622"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"pid": "0x0622"
"pid": "0x0622",
"suspend_wakeup_delay": 2000

keyboards/canary/canary60rgb/v2/config.h
Comment on lines +27 to +28

#define USB_SUSPEND_WAKEUP_DELAY 2000
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
#define USB_SUSPEND_WAKEUP_DELAY 2000

@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 1, 2024

Thank you for your contribution!
This pull request has been automatically marked as stale because it has not had activity in the last 45 days. It will be closed in 30 days if no further activity occurs. Please feel free to give a status update now, or re-open when it's ready.
For maintainers: Please label with bug, awaiting review, breaking_change, in progress, or on hold to prevent the issue from being re-flagged.

@github-actions github-actions bot added the stale Issues or pull requests that have become inactive without resolution. label Oct 1, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 1, 2024

Thank you for your contribution!
This pull request has been automatically closed because it has not had activity in the last 30 days. Please feel free to give a status update now, ping for review, or re-open when it's ready.
// [stale-action-closed]

@github-actions github-actions bot closed this Nov 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@waffle87 waffle87 waffle87 left review comments

@drashna drashna Awaiting requested review from drashna

@dunk2k dunk2k Awaiting requested review from dunk2k

Assignees
No one assigned
Labels
keyboard keymap stale Issues or pull requests that have become inactive without resolution. via Adds via keymap and/or updates keyboard for via support
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@AnthonyNguyen168 @dunk2k @drashna @waffle87