Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add new board km75 #23982

Open
wants to merge 69 commits into
base: master
Choose a base branch
from
Open

Add new board km75 #23982

wants to merge 69 commits into from

Conversation

Smartmmd
Copy link

Description

Add new board km17

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@github-actions github-actions bot added keyboard keymap via Adds via keymap and/or updates keyboard for via support labels Jun 22, 2024
@Smartmmd Smartmmd changed the title Ad Add new board km17 Jun 22, 2024
@JackyJia73
Copy link
Contributor

Also, your licence headers are all over the place and should really be consistent.
Sorry, I will modify.

@Smartmmd Smartmmd requested review from fauxpark and zvecr July 5, 2024 15:14
tzarc
tzarc reviewed Jul 10, 2024
View reviewed changes
keyboards/mmd/km75/readme.md Outdated
Comment on lines 7 to 8
* Hardware Supported: [MMD](https://github.com/Smartmmd)
* Hardware Availability: [MMD](https://github.com/Smartmmd)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's no hardware at this location. Please update the links.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated :-）

fauxpark
fauxpark requested changes Jul 12, 2024
View reviewed changes
keyboards/mmd/km75/keyboard.json Outdated
},
"driver": "ws2812",
"layout": [
{"matrix": [5, 5], "x": 93, "y": 6, "flags": 4},
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RGB Matrix layout is incorrect.
image

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated :）

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks better, although the placement still seems not quite right:
image
And I am not sure what's going on in the top right. Is the encoder button the key at 0,14?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes , there is button @ 0 ,14
BTW, how do youget the layout view? I can use to check before push/pull. Thanks

keyboards/mmd/km75/keyboard.json Outdated Show resolved Hide resolved
fauxpark
fauxpark reviewed Jul 12, 2024
View reviewed changes
keyboards/mmd/km75/readme.md
@@ -0,0 +1,22 @@
# MMD-KM75


Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

An image of the board would be useful here.

@JackyJia73 @zvecr
Update keyboards/mmd/km75/keyboard.json
f3e7a3d 
Co-authored-by: Joel Challis <git@zvecr.com>
@tzarc tzarc added the on hold label Jul 14, 2024
@tzarc
Copy link
Member

tzarc commented Jul 14, 2024 •
edited
Loading

On hold due to ambiguity with wireless, and definitive evidence of 2/3 wireless boards based on QMK with no sources. See #24085 for rationale -- if we're holding the others back, this one should too.

@tzarc tzarc marked this pull request as draft July 14, 2024 05:13
@JackyJia73
Copy link
Contributor

Wireless code added

@Smartmmd Smartmmd requested a review from zvecr July 30, 2024 08:56
@Smartmmd Smartmmd marked this pull request as ready for review July 30, 2024 08:57
@JackyJia73 JackyJia73 mentioned this pull request Aug 21, 2024
Open
@tzarc
Copy link
Member

tzarc commented Aug 26, 2024

As of August 26, 2024, qmk/qmk_firmware is no longer accepting VIA-enabled keymaps as these have now transitioned to a repository under the VIA team's control.

As you've submitted a PR containing via or VIA-enabled keymap(s), this is your notice that they should be removed from this PR. You should now submit a secondary PR to the VIA QMK Userspace repository with your associated via or VIA-enabled keymaps instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JackyJia73 JackyJia73 JackyJia73 left review comments

@fauxpark fauxpark fauxpark requested changes

@tzarc tzarc tzarc left review comments

@drashna drashna Awaiting requested review from drashna

@zvecr zvecr Awaiting requested review from zvecr

Assignees
No one assigned
Labels
keyboard keymap needs-wireless-code on hold via Adds via keymap and/or updates keyboard for via support
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@Smartmmd @drashna @JackyJia73 @tzarc @fauxpark @zvecr @waffle87