Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[keyboard] add redragon/k715 #24184

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Conversation

temp4gh
Copy link
Contributor

@temp4gh temp4gh commented Jul 23, 2024

Description

Add support for new keyboard redragon/k715.
Thanx!

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@github-actions github-actions bot added keyboard keymap via Adds via keymap and/or updates keyboard for via support labels Jul 23, 2024
@zvecr
Copy link
Member

zvecr commented Jul 23, 2024

On hold due to a lack of wireless code, see #24085.

image

@zvecr zvecr marked this pull request as draft July 23, 2024 13:25
@temp4gh
Copy link
Contributor Author

temp4gh commented Jul 29, 2024

On hold due to a lack of wireless code, see #24085.

image
Sorry for the wrong contents for the keyboard on the Web page, now the contents updated ,K715 should be a single mode keyboard rather than dual mode. Thanx!
k715

@tzarc
Copy link
Member

tzarc commented Jul 29, 2024

And you've got no plans for an equivalent wireless edition, much like a large number of other manufacturers seem to have done? Perhaps called the K715 Pro like your original documentation?

It's rather curious that the product URL still mentions "3 modes" and "connection":

https://www.redragonzone.com/products/redragon-k715-qmk-pro-ucal-qmk-pro-3-modes-connection-qmk-compatible-gasket-mounted-mechanical-keyboard

It would be quite unfortunate if Redragon were being deceptive and ultimately released such a wireless board based on QMK with no intent to release source code.

In the interests of transparency we'll leave this PR as-is for the time being -- with any luck Redragon has solidified its product offerings and we'll see if there is indeed a "pro wireless" variant.

@temp4gh
Copy link
Contributor Author

temp4gh commented Jul 31, 2024

And you've got no plans for an equivalent wireless edition, much like a large number of other manufacturers seem to have done? Perhaps called the K715 Pro like your original documentation?

It's rather curious that the product URL still mentions "3 modes" and "connection":

https://www.redragonzone.com/products/redragon-k715-qmk-pro-ucal-qmk-pro-3-modes-connection-qmk-compatible-gasket-mounted-mechanical-keyboard

It would be quite unfortunate if Redragon were being deceptive and ultimately released such a wireless board based on QMK with no intent to release source code.

In the interests of transparency we'll leave this PR as-is for the time being -- with any luck Redragon has solidified its product offerings and we'll see if there is indeed a "pro wireless" variant.

Sorry for misunderstanding!Here is the correct link:
https://www.redragonzone.com/collections/keyboard/products/redragon-k715-finke-qmk-compatible-gasket-mounted-mechanical-keyboard
It is a single mode keyboard. As for the 3 modes product in future, we will provide the related wireless code for PR to meet the requirement.Thanks!

@temp4gh temp4gh marked this pull request as ready for review August 3, 2024 12:57
@temp4gh
Copy link
Contributor Author

temp4gh commented Aug 9, 2024

Hello Repository Owner/Collaborators,
I added comments last week, but yet received any feedback.
I wanted to kindly inquire if there's anything more I should do to help move the process forward.
If there are any specific concerns, issues, or additional changes needed, please let me know. Your guidance would be greatly appreciated as I want to ensure my submission aligns with the QMK's standards and requirements.
Additionally, if there are any other steps I need to take or if there's an expected timeline for the review process, please feel free to share that information with me.
Many Thanx!

@drashna drashna requested review from a team August 30, 2024 03:15
Copy link

Thank you for your contribution!
This pull request has been automatically marked as stale because it has not had activity in the last 45 days. It will be closed in 30 days if no further activity occurs. Please feel free to give a status update now, or re-open when it's ready.
For maintainers: Please label with bug, awaiting review, breaking_change, in progress, or on hold to prevent the issue from being re-flagged.

@github-actions github-actions bot added the stale Issues or pull requests that have become inactive without resolution. label Oct 15, 2024
keyboards/redragon/k715/keymaps/via/keymap.c Outdated Show resolved Hide resolved
keyboards/redragon/k715/keymaps/default/keymap.c Outdated Show resolved Hide resolved
@github-actions github-actions bot removed the stale Issues or pull requests that have become inactive without resolution. label Oct 17, 2024
@temp4gh temp4gh requested a review from fauxpark October 22, 2024 08:40
@temp4gh
Copy link
Contributor Author

temp4gh commented Nov 26, 2024

Hello Repository Owner/Collaborators,
I modified the code according to review results last month, but yet received any feedback.
I wanted to kindly inquire if there's anything more I should do to help move the process forward.
If there are any specific concerns, issues, or additional changes needed, please let me know. Your guidance would be greatly appreciated as I want to ensure my submission aligns with the QMK's standards and requirements.
Additionally, if there are any other steps I need to take or if there's an expected timeline for the review process, please feel free to share that information with me.
Many Thanx!

Copy link
Member

@fauxpark fauxpark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RGB_ -> RM_ keycodes after this round of breaking changes.

keyboards/redragon/k715/keymaps/default/keymap.c Outdated Show resolved Hide resolved
keyboards/redragon/k715/keymaps/default/keymap.c Outdated Show resolved Hide resolved
temp4gh and others added 2 commits November 26, 2024 20:18
Co-authored-by: Ryan <fauxpark@gmail.com>
Co-authored-by: Ryan <fauxpark@gmail.com>
@temp4gh
Copy link
Contributor Author

temp4gh commented Nov 26, 2024

RGB_ -> RM_ keycodes after this round of breaking changes.

Thanx for reviewing!Committed according to the modification.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
keyboard keymap needs-wireless-code via Adds via keymap and/or updates keyboard for via support
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants