Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Addition to the Apple Globe key code to QMK #24661
base: develop
Are you sure you want to change the base?
Addition to the Apple Globe key code to QMK #24661
Changes from all commits
e1db7e4
084a28b
43ca630
df21f6d
2859d3d
b7422ca
e4541bf
1d5571e
02b20f0
74bef5b
20cc8b0
84d49f6
bcc0cf9
c769c2c
1fd2c0d
061bbb5
66c7638
179fda2
90204f7
0027d4b
ad15e33
559cd8c
9fed162
39ffd47
a80f527
fad7f83
3ca8651
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like this KC_GLOBE does exactly that, and only suitable for switching layouts, not really sending Globe codes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Strictly speaking, you are right, but in practice, on a Mac, it operates as a key.
Unfortunately, there are other cases where I have yet to have success. In particular, Globe+Arrow keys combinations, but I typically use 60% keyboards, so arrow keys are hard to test with those.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If the keycode works on Windows/Linux too (but as layout select), then it would be worth having appropriate aliases too.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't have a pure Windows or Linux machine, but I can investigate using a virtual machine. I'll see whether I have time tomorrow to try that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Windows does not seem to react to the
AC Next Keyboard Layout Select
usage, but I can see it coming in through Wireshark.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I tried this morning while at work on Windows 10, and nada, no reaction to the key. I'll try Linux later; I suspect I'll see the same thing.