Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Icebreaker keyboard #24723

Open
wants to merge 14 commits into
base: develop
Choose a base branch
from
Open

Add Icebreaker keyboard #24723

wants to merge 14 commits into from
+310 −0

Conversation

SmollChungus
Copy link
Contributor

Description

Addition of the Icebreaker, 65% PCB featuring encoder and per-key RGB.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

  • Added support for Icebreaker PCB

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@waffle87 waffle87 requested a review from a team December 16, 2024 18:29
fauxpark
fauxpark requested changes Dec 16, 2024
View reviewed changes
keyboards/icebreaker/readme.md Outdated Show resolved Hide resolved
@SmollChungus @fauxpark
Update keyboards/icebreaker/readme.md
1ee30b7 
Co-authored-by: Ryan <fauxpark@gmail.com>
drashna
drashna requested changes Dec 18, 2024
View reviewed changes
keyboards/icebreaker/hotswap/keyboard.json Outdated Show resolved Hide resolved
keyboards/icebreaker/hotswap/keyboard.json Outdated Show resolved Hide resolved
keyboards/icebreaker/hotswap/keyboard.json Outdated Show resolved Hide resolved
keyboards/icebreaker/hotswap/keymaps/default/keymap.c Outdated Show resolved Hide resolved
keyboards/icebreaker/hotswap/keymaps/default/keymap.c Outdated Show resolved Hide resolved
keyboards/icebreaker/hotswap/keymaps/default/rules.mk Outdated Show resolved Hide resolved
@dunk2k
Copy link
Contributor

dunk2k commented Jan 1, 2025

Thankfully this PR doesn't change existing code, I'd recommend changing the base (merge into) branch from develop to master 🙂

SmollChungus and others added 6 commits January 16, 2025 15:55
@SmollChungus @drashna
Update keyboards/icebreaker/hotswap/keyboard.json
4cdf83d 
Co-authored-by: Drashna Jaelre <drashna@live.com>
@SmollChungus @drashna
Update keyboards/icebreaker/hotswap/keyboard.json
5d6b020 
Co-authored-by: Drashna Jaelre <drashna@live.com>
@SmollChungus @drashna
Update keyboards/icebreaker/hotswap/keyboard.json
29b88d7 
Co-authored-by: Drashna Jaelre <drashna@live.com>
@SmollChungus @drashna
Update keyboards/icebreaker/hotswap/keymaps/default/keymap.c
e151707 
Co-authored-by: Drashna Jaelre <drashna@live.com>
@SmollChungus @drashna
Update keyboards/icebreaker/hotswap/keymaps/default/keymap.c
a5e2922 
Co-authored-by: Drashna Jaelre <drashna@live.com>
@SmollChungus @drashna
Update keyboards/icebreaker/hotswap/keymaps/default/rules.mk
20746d9 
Co-authored-by: Drashna Jaelre <drashna@live.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drashna drashna drashna requested changes

@waffle87 waffle87 waffle87 approved these changes

@fauxpark fauxpark fauxpark approved these changes

Assignees
No one assigned
Labels
keyboard keymap
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@SmollChungus @dunk2k @drashna @fauxpark @waffle87