Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

digitizer: set physical size #24759

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

digitizer: set physical size #24759

wants to merge 1 commit into from

Conversation

windo
Copy link

@windo windo commented Dec 29, 2024

Fix digitizer cursor movements on platforms that require a physical maximum value.

Description

At least on linux with X11, without a physical size set the cursor does not move. Setting the maximum phyiscal value to anything non-zero seems to work equally well, so setting it to 1024 which I think should imply a ~10 inch physical touchpad size.

I assume this works as-is on other OSs, so it would probably be wise to try to test this to make sure it does not cause a regression on some other platform. I've tested on a an Ubuntu laptop with X11 (broken before change, fixed after the change) and on a Windows laptop and a Chromebook (both working both before and after the change). I don't have an Apple laptop to test on.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

I haven't filed an issue, but happy to add one if you think one is needed.

Checklist

  • My code follows the code style of this project: C, Python
  • I have read the PR Checklist document and have made the appropriate changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

At least on linux with X11, without a physical size set the cursor does
not move. Setting the maximum phyiscal value to anything non-zero seems
to work equally well, so setting it to 1024 which I think should imply a
~10 inch physical touchpad size.
@github-actions github-actions bot added the core label Dec 29, 2024
@windo
Copy link
Author

windo commented Dec 29, 2024

@a-chol @fauxpark - as people who might have some expertise, does this look reasonable to you?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant