-
-
Notifications
You must be signed in to change notification settings - Fork 40.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add doio/kb03 #24815
base: master
Are you sure you want to change the base?
add doio/kb03 #24815
Conversation
thanks for the review drashna |
…b03.c Co-authored-by: Drashna Jaelre <drashna@live.com>
oh, force pushed a new commit message for clarity and wasn't thinking about the CI run sorry to take your resources guys |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@drashna I had a few thoughts after staring at this some more, see change requests.
Also, I was wondering if I should commit my latest revision to enable PWM for the RGB or just leave it as bitbang? I have been using the PWM on it for 10 days now with no signs of issues.
I was also curious if it would be acceptable to include 4 layers for the default keymap as there are so few keys.
"animation": "dual_beacon" | ||
}, | ||
"driver": "ws2812", | ||
"hue_step": 16, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
feels like unnecessary customization
"hue_step": 16, |
"default": { | ||
"animation": "dual_beacon" | ||
}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
feels like unnecessary customization
"default": { | |
"animation": "dual_beacon" | |
}, |
// SPDX-License-Identifier: GPL-2.0-or-later | ||
|
||
#include QMK_KEYBOARD_H | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
name layers in enum
enum my_layers { | |
_BASE, | |
_LAYER1 | |
}; | |
[0] = LAYOUT( | ||
TO(1), KC_1, KC_2, KC_3, KC_MUTE | ||
), | ||
[1] = LAYOUT( | ||
TO(0), RM_VALD, RM_NEXT, RM_VALU, RM_TOGG |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
layer names
[0] = LAYOUT( | |
TO(1), KC_1, KC_2, KC_3, KC_MUTE | |
), | |
[1] = LAYOUT( | |
TO(0), RM_VALD, RM_NEXT, RM_VALU, RM_TOGG | |
[_BASE] = LAYOUT( | |
TO(_LAYER1), KC_1, KC_2, KC_3, KC_MUTE | |
), | |
[_LAYER1] = LAYOUT( | |
TO(_BASE), RM_VALD, RM_NEXT, RM_VALU, RM_TOGG |
[0] = { ENCODER_CCW_CW(MS_WHLU, MS_WHLD), ENCODER_CCW_CW(KC_VOLD, KC_VOLU) }, | ||
[1] = { ENCODER_CCW_CW(RM_SATD, RM_SATU), ENCODER_CCW_CW(RM_HUED, RM_HUEU) } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
layer names
[0] = { ENCODER_CCW_CW(MS_WHLU, MS_WHLD), ENCODER_CCW_CW(KC_VOLD, KC_VOLU) }, | |
[1] = { ENCODER_CCW_CW(RM_SATD, RM_SATU), ENCODER_CCW_CW(RM_HUED, RM_HUEU) } | |
[_BASE] = { ENCODER_CCW_CW(MS_WHLU, MS_WHLD), ENCODER_CCW_CW(KC_VOLD, KC_VOLU) }, | |
[_LAYER1] = { ENCODER_CCW_CW(RM_SATD, RM_SATU), ENCODER_CCW_CW(RM_HUED, RM_HUEU) } |
A little backstory: |
Description
add QMK support for the DOIO KB03-01 dual layer knob megalodon pad
Types of Changes
Issues Fixed or Closed by This PR
Checklist