Add dragscroll combo option for Ploopy devices. #24876
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds an option for Ploopy devices with the
DRAG_SCROLL
key to allow it to be both held or toggled (combining both momentary and toggled scroll).The way it can be used is by tapping the key for toggling drag scroll or holding it for momentary drag scroll.
This can be enabled by setting
#define PLOOPY_DRAGSCROLL_COMBO
(defaults to not defined), the threshold can be customized by setting#define PLOOPY_DRAGSCROLL_COMBO_THRESHOLD <float value>
(defaults to0.5
ifPLOOPY_DRAGSCROLL_COMBO
is defined).It works by checking if the user has exceeded the threshold while the key is being held:
I have also included a short description of
PLOOPY_DRAGSCROLL_COMBO
inkeyboards/ploopyco/readme.md
following the style of the existing documentation.I have worked on and tested this with my Ploopy Adept/Madromys, it seems to work well for my needs. I was directly inspired by this repo, but that was unmergeable so I chose to reimplement it on the latest
master
branch.Types of Changes
Checklist