[Keyboard] Adding support S6xty rev2 and re-organize s6xty keyboard #24881
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Duncan Sutherland <dunk2k_2000@hotmail.com>
waffle87
reviewed
Jan 29, 2025
Co-authored-by: jack <jack@pngu.org>
waffle87
approved these changes
Jan 30, 2025
zvecr
requested changes
Feb 4, 2025
| @@ -0,0 +1,4 @@ | |||
| { | |||
| "processor": "STM32F072", | |||
| "bootloader": "stm32-dfu", | |||
There was a problem hiding this comment.
Suggested change
| "bootloader": "stm32-dfu", | |
| "bootloader": "stm32-dfu" |
| @@ -0,0 +1,4 @@ | |||
| { | |||
| "processor": "STM32F103", | |||
| "bootloader": "uf2boot", | |||
There was a problem hiding this comment.
Suggested change
| "bootloader": "uf2boot", | |
| "bootloader": "uf2boot" |
| @@ -0,0 +1,4 @@ | |||
| { | |||
| "processor": "STM32F072", | |||
| "bootloader": "stm32-dfu", | |||
There was a problem hiding this comment.
Suggested change
| "bootloader": "stm32-dfu", | |
| "bootloader": "stm32-dfu" |
| @@ -0,0 +1,4 @@ | |||
| { | |||
| "processor": "STM32F103", | |||
| "bootloader": "uf2boot", | |||
There was a problem hiding this comment.
Suggested change
| "bootloader": "uf2boot", | |
| "bootloader": "uf2boot" |
keyboards/trnthsn/s6xty/readme.md
Outdated
| @@ -10,11 +10,11 @@ A 60% keyboard PCB compatible with various keyboard cases. Supports a left USB T | |||
|
|
|||
| Make example for this keyboard (after setting up your build environment): | |||
|
|
|||
| make trnthsn/s6xty:default | |||
| make trnthsn/s6xty/rev1/stm32f103:default | |||
There was a problem hiding this comment.
With the previous default being for f072, these changes dont make much sense?
Also, why is there now a stm32f103 rev1 variant being introduced?
There was a problem hiding this comment.
the rev1 also support f103 just by adding resonator on smd process. so i has push a new pr to support that one
There was a problem hiding this comment.
i had changed back to f072
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Types of Changes
Issues Fixed or Closed by This PR
Checklist