Backlight Breathing #313
Closed
Backlight Breathing #313
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refactored the LUTs. Abstracted some of the registers out of audio to use more functional names. Split audio into audio and audio_pwm. WIP
…ev_atomic_1 # Conflicts: # keyboard/atomic/keymaps/pvc/config.h # keyboard/atomic/keymaps/pvc/keymap.c # keyboard/planck/keymaps/pvc/makefile.mk # quantum/audio/audio.c # quantum/quantum.mk
| SRC += $(QUANTUM_DIR)/audio/voices.c | ||
| SRC += $(QUANTUM_DIR)/audio/luts.c | ||
| SRC += $(QUANTUM_DIR)/audio/audio.c $(QUANTUM_DIR)/audio/voices.c | ||
| SRC += $(QUANTUM_DIR)/audio/audio.c $(QUANTUM_DIR)/audio/luts.c |
There was a problem hiding this comment.
We changed this in a previous commit - is there a reason audio.c needs to be on both lines?
There was a problem hiding this comment.
Accidental merge artifacts. Fixed
|
This is awesome - moving to #314 with Planck additions! |
BlueTufa
pushed a commit
to BlueTufa/qmk_firmware
that referenced
this pull request
Aug 6, 2021
- thinko accidentally forgot to provide a getter and state for setter
daltona
pushed a commit
to daltona/qmk_firmware
that referenced
this pull request
Jan 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I borrowed the code used for the sleep led option and repurposed it for the atomic backlight. My keyboard backlight now pulses off when I hit the raise or lower shift and cycles while I am in the function layer.