Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

quantum: Add a tap dance feature #449

Closed
wants to merge 1 commit into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -80,6 +80,7 @@ endif
SRC += $(KEYBOARD_FILE) \
$(KEYMAP_FILE) \
$(QUANTUM_DIR)/quantum.c \
$(QUANTUM_DIR)/tap_dance.c \
$(QUANTUM_DIR)/keymap.c \
$(QUANTUM_DIR)/keycode_config.c

Expand All @@ -99,6 +100,10 @@ ifeq ($(strip $(RGBLIGHT_ENABLE)), yes)
OPT_DEFS += -DRGBLIGHT_ENABLE
endif

ifeq ($(strip $(TAP_DANCE_ENABLE)), yes)
OPT_DEFS += -DTAP_DANCE_ENABLE
endif

# Optimize size but this may cause error "relocation truncated to fit"
#EXTRALDFLAGS = -Wl,--relax

Expand Down
2 changes: 2 additions & 0 deletions keyboards/alps64/matrix.c
Original file line number Diff line number Diff line change
Expand Up @@ -100,6 +100,8 @@ uint8_t matrix_scan(void)
}
}

matrix_scan_tap_dance();

return 1;
}

Expand Down
2 changes: 1 addition & 1 deletion keyboards/ergodox_ez/matrix.c
Original file line number Diff line number Diff line change
Expand Up @@ -187,7 +187,7 @@ uint8_t matrix_scan(void)
}
}


matrix_scan_tap_dance();
matrix_scan_kb();

return 1;
Expand Down
3 changes: 3 additions & 0 deletions keyboards/hhkb/matrix.c
Original file line number Diff line number Diff line change
Expand Up @@ -150,6 +150,9 @@ uint8_t matrix_scan(void)
KEY_POWER_OFF();
suspend_power_down();
}

matrix_scan_tap_dance();

return 1;
}

Expand Down
1 change: 1 addition & 0 deletions keyboards/sixkeyboard/matrix.c
Original file line number Diff line number Diff line change
Expand Up @@ -87,6 +87,7 @@ uint8_t matrix_scan(void)
matrix[0] = (PINC&(1<<7) ? 0 : (1<<0)) | (PINB&(1<<7) ? 0 : (1<<1)) | (PINB&(1<<5) ? 0 : (1<<2));
matrix[1] = (PIND&(1<<6) ? 0 : (1<<0)) | (PIND&(1<<1) ? 0 : (1<<1)) | (PIND&(1<<4) ? 0 : (1<<2));

matrix_scan_tap_dance();
matrix_scan_kb();

return 1;
Expand Down
2 changes: 2 additions & 0 deletions quantum/keymap.h
Original file line number Diff line number Diff line change
Expand Up @@ -77,6 +77,8 @@ enum quantum_keycodes {
#endif
QK_MOD_TAP = 0x6000,
QK_MOD_TAP_MAX = 0x6FFF,
QK_TAP_DANCE = 0x7100,
QK_TAP_DANCE_MAX = 0x71FF,
#ifdef UNICODE_ENABLE
QK_UNICODE = 0x8000,
QK_UNICODE_MAX = 0xFFFF,
Expand Down
4 changes: 4 additions & 0 deletions quantum/quantum.c
Original file line number Diff line number Diff line change
Expand Up @@ -136,6 +136,9 @@ bool process_record_quantum(keyrecord_t *record) {
keycode = keymap_key_to_keycode(layer_switch_get_layer(key), key);
#endif

if (!process_tap_dance(keycode, record))
return false;

if (!process_record_kb(keycode, record))
return false;

Expand Down Expand Up @@ -668,6 +671,7 @@ void matrix_scan_quantum() {

#endif

matrix_scan_tap_dance();
matrix_scan_kb();
}

Expand Down
1 change: 1 addition & 0 deletions quantum/quantum.h
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@
#ifdef UNICODE_ENABLE
#include "unicode.h"
#endif
#include "tap_dance.h"

#include "action_layer.h"
#include "eeconfig.h"
Expand Down
104 changes: 104 additions & 0 deletions quantum/tap_dance.c
Original file line number Diff line number Diff line change
@@ -0,0 +1,104 @@
#include "quantum.h"

#if TAP_DANCE_ENABLE

static qk_tap_dance_state_t qk_tap_dance_state;

static void _process_tap_dance_action_pair (qk_tap_dance_state_t *state,
uint16_t kc1, uint16_t kc2) {
uint16_t kc;

if (state->count == 0)
return;

kc = (state->count == 1) ? kc1 : kc2;

register_code (kc);
unregister_code (kc);

if (state->count >= 2) {
reset_tap_dance (state);
}
}

static void _process_tap_dance_action_fn (qk_tap_dance_state_t *state,
qk_tap_dance_user_fn_t fn)
{
fn(state);
}

void process_tap_dance_action (uint16_t keycode, keyrecord_t *record)
{
uint16_t idx = keycode - QK_TAP_DANCE;
qk_tap_dance_action_t action;

action = tap_dance_actions[idx];

switch (action.type) {
case QK_TAP_DANCE_TYPE_PAIR:
_process_tap_dance_action_pair (&qk_tap_dance_state,
action.pair.kc1, action.pair.kc2);
break;
case QK_TAP_DANCE_TYPE_FN:
_process_tap_dance_action_fn (&qk_tap_dance_state, action.fn);
break;

default:
break;
}
}

bool process_tap_dance(uint16_t keycode, keyrecord_t *record) {
bool r = true;

switch(keycode) {
case QK_TAP_DANCE ... QK_TAP_DANCE_MAX:
if (qk_tap_dance_state.keycode && qk_tap_dance_state.keycode != keycode) {
process_tap_dance_action (keycode, record);
} else {
r = false;
}

if (record->event.pressed) {
qk_tap_dance_state.keycode = keycode;
qk_tap_dance_state.timer = timer_read ();
qk_tap_dance_state.count++;
}
break;

default:
if (qk_tap_dance_state.keycode) {
process_tap_dance_action (qk_tap_dance_state.keycode, NULL);

reset_tap_dance (&qk_tap_dance_state);
}
break;
}

return r;
}

void matrix_scan_tap_dance () {
if (qk_tap_dance_state.keycode && timer_elapsed (qk_tap_dance_state.timer) > TAPPING_TERM) {
process_tap_dance_action (qk_tap_dance_state.keycode, NULL);

reset_tap_dance (&qk_tap_dance_state);
}
}

void reset_tap_dance (qk_tap_dance_state_t *state) {
state->keycode = 0;
state->count = 0;
}

#else
void matrix_scan_tap_dance () {
}

bool process_tap_dance(uint16_t keycode, keyrecord_t *record) {
return true;
}

void reset_tap_dance (qk_tap_dance_state_t *state) {
}
#endif
56 changes: 56 additions & 0 deletions quantum/tap_dance.h
Original file line number Diff line number Diff line change
@@ -0,0 +1,56 @@
#ifndef TAP_DANCE_H
#define TAP_DANCE_H

#include <stdbool.h>
#include <inttypes.h>

typedef struct
{
uint8_t count;
uint16_t keycode;
uint16_t timer;
} qk_tap_dance_state_t;

#define TD(n) (QK_TAP_DANCE + n)

typedef enum
{
QK_TAP_DANCE_TYPE_PAIR,
QK_TAP_DANCE_TYPE_FN,
} qk_tap_dance_type_t;

typedef void (*qk_tap_dance_user_fn_t) (qk_tap_dance_state_t *state);

typedef struct
{
qk_tap_dance_type_t type;
union {
struct {
uint16_t kc1;
uint16_t kc2;
} pair;
qk_tap_dance_user_fn_t fn;
};
} qk_tap_dance_action_t;

#define ACTION_TAP_DANCE_DOUBLE(kc1, kc2) { \
.type = QK_TAP_DANCE_TYPE_PAIR, \
.pair = { kc1, kc2 } \
}

#define ACTION_TAP_DANCE_FN(user_fn) { \
.type = QK_TAP_DANCE_TYPE_FN, \
.fn = user_fn \
}

#if TAP_DANCE_ENABLE
extern const qk_tap_dance_action_t tap_dance_actions[];
#endif

/* To be used internally */

bool process_tap_dance(uint16_t keycode, keyrecord_t *record);
void matrix_scan_tap_dance (void);
void reset_tap_dance (qk_tap_dance_state_t *state);

#endif