Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bugfix] Delete duplicate readme in unigo66 #5117

Closed
wants to merge 1 commit into from
Closed

[Bugfix] Delete duplicate readme in unigo66 #5117

wants to merge 1 commit into from

Conversation

distransient
Copy link

Triggers case sensitivity issues on windows.

Types of changes

  • Bugfix

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document. (https://docs.qmk.fm/#/contributing)
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@distransient
Delete duplicate readme in unigo66
251373b 
Triggers case sensitivity issues on windows.
@mechmerlin mechmerlin added the bug label Feb 13, 2019
mechmerlin
mechmerlin requested changes Feb 13, 2019
View reviewed changes
Copy link
Contributor

@mechmerlin mechmerlin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We actually use the all lower case readme.md as part of our templates. Can you remove the all caps README.md instead?

@noroadsleft
Copy link
Member

There's actually a commit in #5108 that takes care of the duplicate readme (by removing the file with the uppercase name).

@dededecline dededecline mentioned this pull request Feb 13, 2019
Merged
13 tasks
@drashna
Copy link
Member

drashna commented Feb 13, 2019

And merged. But thank you for opening this!

@distransient
Copy link
Author

Resolved before I had a chance to update the PR! Bless. ^^

@drashna
Copy link
Member

drashna commented Feb 14, 2019

Yup. Though the author for the unigo66 had a PR open already, and we flagged them there. Since they were already messing with the files ...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mechmerlin mechmerlin mechmerlin requested changes

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@distransient @noroadsleft @drashna @mechmerlin