Adding ortho_4x12 & planck_mit layouts for KBD4X. #5729
Conversation
There was a problem hiding this comment.
Travis CI error is because bakingpy's (@nooges) ortho_4x12 keymap uses LAYOUT_kc_ortho_4x12 for its macro, which isn't supported here.
I don't think he owns a KBD4x, so I'm going to call this good.
| { k30, k31, k32, k33, k34, k35, k36, k37, k38, k39, k3a, k3b } \ | ||
| } | ||
|
|
||
| #define LAYOUT_kc_ortho_4x12( \ |
There was a problem hiding this comment.
I believe the use of layout macros which automatically prepend KC_ is discouraged - it makes it difficult to use keycodes like MO() etc.
There was a problem hiding this comment.
I like it though, so it should probably stay.
There was a problem hiding this comment.
I like it though, so it should probably stay.
:(
|
I added the macro and now the firmware is too large haha... So, there are couple things I usually do. On my personal keymaps, I usually add the following to the And add Also, but the KBD4x also doesn't come w/ backlight. So, turning that off would save a lot of space. I can do that if you guys are ok with it. |
|
Yeah, good idea to turn backlight off in rules.mk then. |
|
I'd actually prefer if Backlight stayed on. Switching |
* upstream/master: (779 commits) [Keyboard] Signum3.0 remove sortedcontainers (qmk#5679) Simple extended space cadet (qmk#5277) Removed forced in lining for lib8tion functions (qmk#5670) Change lib8tion library to be usable in user keymaps (qmk#5598) [Keyboard] Fixing drag-and-drop (qmk#5728) [Keyboard] Adding ortho_4x12 & planck_mit layouts for KBD4X (qmk#5729) [Keyboard] Minor fixes for Baguette (qmk#5737) Updated rgb_led struct field modifier to flags (qmk#5619) RGB Matrix: Custom effects on a kb/user level (qmk#5338) Fix Planck and Preonic builds (qmk#5658) [Keymap] dz60 keymap w/ hhkb-esque default layer (qmk#5708) [Keymap] Added compatibility for Planck rev6 (qmk#5706) [Keyboard] Satisfaction75 i2c fix and VIA layout (qmk#5726) A better new_project.sh (qmk#5191) Fix sendstring "#" producing "£" instead (qmk#5724) [Keyboard] Added WT69-A PCB (qmk#5721) [Keymap] Fix typo and function layer image for Quefrency (qmk#5719) [Keymap] Initial keyboard layout for KBD67 (qmk#5720) [Keymap] New keymap for Quefrency 65% with split backspace, RGB, media keys, mouse keys (qmk#5717) [Keyboard] Update Gergo to use newer Ergodox Matrix code (qmk#5703) ...
* Adding ortho_4x12 & planck_mit layouts for KBD4X. * Adding LAYOUT_kc_ortho_4x12 macro to KBD4x. * Turn off console for KBD4X so firmware size falls within limit.
* Adding ortho_4x12 & planck_mit layouts for KBD4X. * Adding LAYOUT_kc_ortho_4x12 macro to KBD4x. * Turn off console for KBD4X so firmware size falls within limit.
* Adding ortho_4x12 & planck_mit layouts for KBD4X. * Adding LAYOUT_kc_ortho_4x12 macro to KBD4x. * Turn off console for KBD4X so firmware size falls within limit.
* Adding ortho_4x12 & planck_mit layouts for KBD4X. * Adding LAYOUT_kc_ortho_4x12 macro to KBD4x. * Turn off console for KBD4X so firmware size falls within limit.
Enabling ortho_4x12 & planck_mit layouts for KBD4X.