Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configurable VIA layout options default value #8707

Merged
merged 1 commit into from
Apr 6, 2020

Conversation

wilba
Copy link
Contributor

@wilba wilba commented Apr 6, 2020

Description

Allow override of the layout options default value. This requires advanced knowledge of how VIA stores layout options and is only really useful for setting a boolean layout option state to true by default.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@nooges
Copy link
Member

nooges commented Apr 6, 2020

Related to the-via/releases#14

@zvecr zvecr added the core label Apr 6, 2020
@zvecr zvecr merged commit 9bfa713 into qmk:master Apr 6, 2020
@zvecr
Copy link
Member

zvecr commented Apr 6, 2020

Thanks!

HokieGeek pushed a commit to HokieGeek/qmk_firmware that referenced this pull request Apr 10, 2020
mrlinuxfish pushed a commit to mrlinuxfish/qmk_firmware that referenced this pull request Apr 12, 2020
Quarren42 pushed a commit to Quarren42/qmk_firmware that referenced this pull request Apr 15, 2020
kylekuj pushed a commit to kylekuj/qmk_firmware that referenced this pull request Apr 21, 2020
bitherder pushed a commit to bitherder/qmk_firmware that referenced this pull request May 15, 2020
sowbug pushed a commit to sowbug/qmk_firmware that referenced this pull request May 24, 2020
turky pushed a commit to turky/qmk_firmware that referenced this pull request Jun 13, 2020
jakobaa pushed a commit to jakobaa/qmk_firmware that referenced this pull request Jul 7, 2020
thorstenweber83 pushed a commit to thorstenweber83/qmk_firmware that referenced this pull request Sep 2, 2020
@wilba wilba deleted the via_layout_options_fix branch March 23, 2021 23:10
BorisTestov pushed a commit to BorisTestov/qmk_firmware that referenced this pull request May 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants