Clean up ATSAM ifdefs #8808
Merged
Clean up ATSAM ifdefs #8808
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/sigh I know it's needed, but I would really love to see the massive PR from massdrop merged before this is, ... mostly so we can just get it in. |
drashna
approved these changes
Apr 19, 2020
|
Well, the only changes to the EDIT: Just grepped through the PR and there are exactly 0 instances of these old defines in the diff, so this should be OK to merge first. |
|
Thanks! |
kylekuj
pushed a commit
to kylekuj/qmk_firmware
that referenced
this pull request
Apr 21, 2020
rockwarrior
added a commit
to rockwarrior/qmk_firmware
that referenced
this pull request
Apr 23, 2020
* upstream: (1037 commits) [Keyboard] Add wasdat code controller (qmk#8858) fix sample code indent in feature_encoders.md (qmk#8883) [Keymap] Clean up my ergo keymaps and userspace (qmk#8857) idb 60 Bugfixes / Preparations for Open Source Hardware (qmk#8866) Rebound: add rev2 and thus rev1 as well (qmk#8630) Update vitamins included default keymap, enable NKRO, rev2 rgbsplit (qmk#8871) Update to xealousbrown. (qmk#8215) [Keyboard] DMQ Design SPIN (qmk#8820) Wheatfield Blocked65: Update RGBLED num (qmk#8725) Add VIA support to ID80 (qmk#8791) CFTKB Mysterium & Discipad VIA support (qmk#8794) Clean up ATSAM ifdefs (qmk#8808) [Docs] Japanese translation of docs/feature_encoders.md (qmk#8843) Add naked60 layout, clean up my userspace files and rules.mk. (qmk#8848) Fixing DecadePad Numlock LED Bug (qmk#8831) [Docs] Japanese translation of docs/feature_command.md (qmk#8672) Add support for YMD75 rev 2 (qmk#8853) Remove no-longer-necessary LTO checks from keyboards' config.h files (qmk#8773) Fix ta-65 tsangan layouts (qmk#8855) Fix Plain60 layout (qmk#8854) ...
violet-fish
pushed a commit
to violet-fish/qmk_firmware
that referenced
this pull request
May 3, 2020
bitherder
pushed a commit
to bitherder/qmk_firmware
that referenced
this pull request
May 15, 2020
drashna
pushed a commit
to zsa/qmk_firmware
that referenced
this pull request
May 24, 2020
sowbug
pushed a commit
to sowbug/qmk_firmware
that referenced
this pull request
May 24, 2020
fdidron
pushed a commit
to zsa/qmk_firmware
that referenced
this pull request
Jun 12, 2020
turky
pushed a commit
to turky/qmk_firmware
that referenced
this pull request
Jun 13, 2020
jakobaa
pushed a commit
to jakobaa/qmk_firmware
that referenced
this pull request
Jul 7, 2020
sjmacneil
pushed a commit
to sjmacneil/qmk_firmware
that referenced
this pull request
Feb 19, 2021
BorisTestov
pushed a commit
to BorisTestov/qmk_firmware
that referenced
this pull request
May 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
For some reason the ATSAM code uses these three-letter defines for NKRO/mousekeys/extrakeys/console/raw/virtser/etc, when it really doesn't need to. I also reformatted the descriptors to be more readable.
Types of Changes
Issues Fixed or Closed by This PR
Checklist