Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change analogRead calls to analogReadPin #9023

Merged
merged 4 commits into from
Jul 2, 2020
Merged

Change analogRead calls to analogReadPin #9023

merged 4 commits into from
Jul 2, 2020

Conversation

fauxpark
Copy link
Member

@fauxpark fauxpark commented May 5, 2020 •
edited
Loading

Description

Might as well get this done now. analogRead() will be removed later.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@fauxpark fauxpark added enhancement core keyboard breaking_change Changes that need to wait for a version increment labels May 5, 2020
@fauxpark fauxpark requested a review from a team May 5, 2020 14:11
noroadsleft
noroadsleft approved these changes May 7, 2020
View reviewed changes
Copy link
Member

@noroadsleft noroadsleft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

__attribute__ ((weak)) ✔️

@noroadsleft noroadsleft requested a review from a team May 7, 2020 09:46
@drashna drashna requested a review from a team May 19, 2020 10:21
@noroadsleft noroadsleft changed the base branch from future to develop May 30, 2020 23:12
@drashna drashna merged commit 59cd6ca into qmk:develop Jul 2, 2020
@fauxpark fauxpark deleted the ble-analogreadpin branch July 2, 2020 03:27
noroadsleft pushed a commit that referenced this pull request Jul 10, 2020
@fauxpark @noroadsleft
Change analogRead calls to analogReadPin (#9023)
d35faa5 
* Change analogRead calls to analogReadPin

* Add ChangeLog

* Update docs, remove mention of `analogRead()`

* Retarget changelog for next round
noroadsleft pushed a commit that referenced this pull request Jul 18, 2020
@fauxpark @noroadsleft
Change analogRead calls to analogReadPin (#9023)
9452b78 
* Change analogRead calls to analogReadPin

* Add ChangeLog

* Update docs, remove mention of `analogRead()`

* Retarget changelog for next round
noroadsleft pushed a commit that referenced this pull request Jul 26, 2020
@fauxpark @noroadsleft
Change analogRead calls to analogReadPin (#9023)
9ad2e04 
* Change analogRead calls to analogReadPin

* Add ChangeLog

* Update docs, remove mention of `analogRead()`

* Retarget changelog for next round
noroadsleft pushed a commit that referenced this pull request Jul 31, 2020
@fauxpark @noroadsleft
Change analogRead calls to analogReadPin (#9023)
398a241 
* Change analogRead calls to analogReadPin

* Add ChangeLog

* Update docs, remove mention of `analogRead()`

* Retarget changelog for next round
noroadsleft pushed a commit that referenced this pull request Aug 11, 2020
@fauxpark @noroadsleft
Change analogRead calls to analogReadPin (#9023)
563728e 
* Change analogRead calls to analogReadPin

* Add ChangeLog

* Update docs, remove mention of `analogRead()`

* Retarget changelog for next round
noroadsleft pushed a commit that referenced this pull request Aug 27, 2020
@fauxpark @noroadsleft
Change analogRead calls to analogReadPin (#9023)
fa6345d 
* Change analogRead calls to analogReadPin

* Add ChangeLog

* Update docs, remove mention of `analogRead()`

* Retarget changelog for next round
noroadsleft pushed a commit that referenced this pull request Aug 29, 2020
@fauxpark @noroadsleft
Change analogRead calls to analogReadPin (#9023)
8a4a0c2 
* Change analogRead calls to analogReadPin

* Add ChangeLog

* Update docs, remove mention of `analogRead()`

* Retarget changelog for next round
nicocesar pushed a commit to nicocesar/qmk_firmware that referenced this pull request Sep 6, 2020
@fauxpark @nicocesar
Change analogRead calls to analogReadPin (qmk#9023)
d21eb15 
* Change analogRead calls to analogReadPin

* Add ChangeLog

* Update docs, remove mention of `analogRead()`

* Retarget changelog for next round
drashna pushed a commit to zsa/qmk_firmware that referenced this pull request Sep 30, 2020
@fauxpark @drashna
Change analogRead calls to analogReadPin (qmk#9023)
8c38482 
* Change analogRead calls to analogReadPin

* Add ChangeLog

* Update docs, remove mention of `analogRead()`

* Retarget changelog for next round
kjganz pushed a commit to kjganz/qmk_firmware that referenced this pull request Oct 28, 2020
@fauxpark @noroadsleft
Change analogRead calls to analogReadPin (qmk#9023)
d33402a 
* Change analogRead calls to analogReadPin

* Add ChangeLog

* Update docs, remove mention of `analogRead()`

* Retarget changelog for next round
BorisTestov pushed a commit to BorisTestov/qmk_firmware that referenced this pull request May 23, 2024
@fauxpark @noroadsleft
Change analogRead calls to analogReadPin (qmk#9023)
6fbaa60 
* Change analogRead calls to analogReadPin

* Add ChangeLog

* Update docs, remove mention of `analogRead()`

* Retarget changelog for next round
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@noroadsleft noroadsleft noroadsleft approved these changes

@drashna drashna drashna approved these changes

Assignees
No one assigned
Labels
breaking_change Changes that need to wait for a version increment core documentation enhancement keyboard
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fauxpark @drashna @noroadsleft