Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert CONSUMER2BLUEFRUIT() and CONSUMER2RN42() macros to static inline functions #9055

Merged
merged 1 commit into from
Jun 7, 2020

Conversation

fauxpark
Copy link
Member

@fauxpark fauxpark commented May 9, 2020

Description

A la #8101.
AL Keyboard Layout apparently toggles the virtual keyboard on iOS, and only iOS. Nothing seems to happen on Windows, Android or macOS, though I didn't have a touch-capable Windows device nor an iPhone/iPad to test.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@fauxpark fauxpark requested a review from a team May 9, 2020 07:57
@drashna drashna requested review from mtei and a team May 19, 2020 10:35
Copy link
Contributor

@mtei mtei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

However, I don't have a keyboard that can verify the behavior of this change, so weak approval.

@mtei mtei requested a review from a team May 21, 2020 18:53
@fauxpark fauxpark changed the base branch from master to develop June 5, 2020 10:56
@fauxpark fauxpark force-pushed the bluefruit-rn42-consumer-functions branch from a57382c to b9980ae Compare June 5, 2020 10:56
@fauxpark fauxpark merged commit 8d90cb1 into qmk:develop Jun 7, 2020
@fauxpark fauxpark deleted the bluefruit-rn42-consumer-functions branch June 7, 2020 05:01
noroadsleft pushed a commit that referenced this pull request Jun 20, 2020
noroadsleft pushed a commit that referenced this pull request Jul 10, 2020
noroadsleft pushed a commit that referenced this pull request Jul 18, 2020
noroadsleft pushed a commit that referenced this pull request Jul 26, 2020
noroadsleft pushed a commit that referenced this pull request Jul 31, 2020
noroadsleft pushed a commit that referenced this pull request Aug 11, 2020
noroadsleft pushed a commit that referenced this pull request Aug 27, 2020
noroadsleft pushed a commit that referenced this pull request Aug 29, 2020
nicocesar pushed a commit to nicocesar/qmk_firmware that referenced this pull request Sep 6, 2020
drashna pushed a commit to zsa/qmk_firmware that referenced this pull request Sep 30, 2020
kjganz pushed a commit to kjganz/qmk_firmware that referenced this pull request Oct 28, 2020
BorisTestov pushed a commit to BorisTestov/qmk_firmware that referenced this pull request May 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants