Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gcc 10 compatibility for Drop alt #9485

Merged
merged 2 commits into from
Dec 6, 2020
Merged

gcc 10 compatibility for Drop alt #9485

merged 2 commits into from
Dec 6, 2020

Commits on Jun 20, 2020

  1. Split dmac_desc declaration and definition 

    According to the official documentation[1] gcc 10 is more strict about
correct extern usage.

I've had to move the definition of dmac_desc and dmac_desc_wb from
i2c_master.h to the corresponding .c file. This could be an issue if
anyone includes the i2c_master.h file without liking with the object
file.

[1]: https://gcc.gnu.org/gcc-10/porting_to.html
    Jesper Jensen committed Jun 20, 2020
    Configuration menu
    Copy the full SHA
    7507a2b View commit details
    Browse the repository at this point in the history

  2. Remove the keymap_config definition from keymaps 

    The keymap_config def was conflicting with the one found in
tmk_core/common/magic.c. Declaring it extern in magic.c breaks a bunch
of keyboard that rely on that declaration (like the ergodox). Instead
I've removed the one found in the keymap.c of the massdrop alt.

The same change will have to be made to other keyboards.
    Jesper Jensen committed Jun 20, 2020
    Configuration menu
    Copy the full SHA
    1470aaa View commit details
    Browse the repository at this point in the history