Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Coupe and Sedan keyboards #9539

Merged
merged 40 commits into from
Jun 29, 2020
Merged

Coupe and Sedan keyboards #9539

merged 40 commits into from
Jun 29, 2020

Conversation

AlisGraveNil
Copy link
Contributor

@AlisGraveNil AlisGraveNil commented Jun 24, 2020

A 60% keyboard and a 68% keyboard. Originally I had PR#9474 but somehow I managed to close/delete that. This should be the same files updated the comments from the contributors.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@AlisGraveNil AlisGraveNil changed the title Initial upload - sedan and coupe keyboards Coupe and Sedan keyboards Jun 24, 2020
keyboards/clawsome/coupe/info.json Outdated Show resolved Hide resolved
keyboards/clawsome/coupe/readme.md Outdated Show resolved Hide resolved
keyboards/clawsome/sedan/info.json Outdated Show resolved Hide resolved
keyboards/clawsome/sedan/readme.md Outdated Show resolved Hide resolved
keyboards/clawsome/sedan/readme.md Outdated Show resolved Hide resolved
keyboards/clawsome/coupe/config.h Outdated Show resolved Hide resolved
keyboards/clawsome/sedan/config.h Outdated Show resolved Hide resolved
keyboards/clawsome/sedan/config.h Outdated Show resolved Hide resolved
@fauxpark fauxpark requested a review from a team June 25, 2020 06:25
keyboards/clawsome/coupe/readme.md Outdated Show resolved Hide resolved
Copy link
Member

@noroadsleft noroadsleft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd also be interested to know whether the keymap.c and sedan.h files for the Sedan came out of my KBFirmware-to-QMK code generator as they are, because if so it seems there's a bug there.

GitHub tip: You can apply multiple suggestions in one commit by applying them using the Files changed tab.

keyboards/clawsome/coupe/coupe.h Outdated Show resolved Hide resolved
keyboards/clawsome/coupe/info.json Outdated Show resolved Hide resolved
keyboards/clawsome/coupe/info.json Outdated Show resolved Hide resolved
keyboards/clawsome/coupe/keymaps/default/keymap.c Outdated Show resolved Hide resolved
keyboards/clawsome/coupe/rules.mk Show resolved Hide resolved
keyboards/clawsome/sedan/keymap/default/keymap.c Outdated Show resolved Hide resolved
keyboards/clawsome/sedan/keymap/default/keymap.c Outdated Show resolved Hide resolved
keyboards/clawsome/sedan/rules.mk Show resolved Hide resolved
keyboards/clawsome/sedan/sedan.h Outdated Show resolved Hide resolved
keyboards/clawsome/sedan/sedan.h Outdated Show resolved Hide resolved
AlisGraveNil and others added 19 commits June 25, 2020 17:50
Co-authored-by: Ryan <fauxpark@gmail.com>
Co-authored-by: Ryan <fauxpark@gmail.com>
Co-authored-by: Ryan <fauxpark@gmail.com>
Co-authored-by: Ryan <fauxpark@gmail.com>
Co-authored-by: Ryan <fauxpark@gmail.com>
Co-authored-by: Ryan <fauxpark@gmail.com>
Co-authored-by: Ryan <fauxpark@gmail.com>
Co-authored-by: Ryan <fauxpark@gmail.com>
Co-authored-by: Ryan <fauxpark@gmail.com>
Co-authored-by: James Young <18669334+noroadsleft@users.noreply.github.com>
Co-authored-by: James Young <18669334+noroadsleft@users.noreply.github.com>
Co-authored-by: James Young <18669334+noroadsleft@users.noreply.github.com>
Co-authored-by: James Young <18669334+noroadsleft@users.noreply.github.com>
Co-authored-by: James Young <18669334+noroadsleft@users.noreply.github.com>
Co-authored-by: James Young <18669334+noroadsleft@users.noreply.github.com>
Co-authored-by: James Young <18669334+noroadsleft@users.noreply.github.com>
Co-authored-by: James Young <18669334+noroadsleft@users.noreply.github.com>
Co-authored-by: James Young <18669334+noroadsleft@users.noreply.github.com>
Co-authored-by: James Young <18669334+noroadsleft@users.noreply.github.com>
@AlisGraveNil
Copy link
Contributor Author

It didn't even occur to me that you were referring to a second layer. I have macropads on my desktop for the F-keys and arrow keys and I didn't even think about that for other users.

Apologies if I seemed incredibly obtuse...

Copy link
Member

@Erovia Erovia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just added a few comments for you to consider.
Let me know if you'd rather get this PR merged as is.

keyboards/clawsome/coupe/readme.md Show resolved Hide resolved
keyboards/clawsome/sedan/readme.md Show resolved Hide resolved
keyboards/clawsome/coupe/config.h Outdated Show resolved Hide resolved
keyboards/clawsome/sedan/config.h Outdated Show resolved Hide resolved
@Erovia Erovia requested review from fauxpark, noroadsleft and a team June 28, 2020 20:22
keyboards/clawsome/coupe/readme.md Outdated Show resolved Hide resolved
keyboards/clawsome/sedan/readme.md Outdated Show resolved Hide resolved
AlisGraveNil and others added 2 commits June 28, 2020 18:46
Co-authored-by: James Young <18669334+noroadsleft@users.noreply.github.com>
Co-authored-by: James Young <18669334+noroadsleft@users.noreply.github.com>
@zvecr zvecr requested a review from noroadsleft June 28, 2020 23:03
@noroadsleft noroadsleft merged commit 2c0201e into qmk:master Jun 29, 2020
@noroadsleft
Copy link
Member

Thanks!

jakobaa pushed a commit to jakobaa/qmk_firmware that referenced this pull request Jul 7, 2020
* Initial upload - sedan and coupe keyboards

* Update coupe.h

* Update coupe.h

* Update coupe.h

* Update sedan.h

* Update keyboards/clawsome/coupe/readme.md

* Update keyboards/clawsome/sedan/config.h

* Update keyboards/clawsome/sedan/config.h

* Update keyboards/clawsome/coupe/config.h

* Update keyboards/clawsome/sedan/readme.md

* Update keyboards/clawsome/sedan/info.json

* Update keyboards/clawsome/sedan/readme.md

* Update keyboards/clawsome/coupe/readme.md

* Update keyboards/clawsome/coupe/info.json

* Update keyboards/clawsome/coupe/coupe.h

* Update keyboards/clawsome/coupe/info.json

* Update keyboards/clawsome/coupe/info.json

* Update keyboards/clawsome/coupe/keymaps/default/keymap.c

* Update keyboards/clawsome/sedan/info.json

* Update keyboards/clawsome/sedan/sedan.h

* Update keyboards/clawsome/sedan/rules.mk

* Update keyboards/clawsome/sedan/sedan.h

* Update keyboards/clawsome/sedan/keymap/default/keymap.c

* Update keyboards/clawsome/sedan/keymap/default/keymap.c

* Update keyboards/clawsome/coupe/rules.mk

* Update keyboards/clawsome/sedan/info.json

* Update keyboards/clawsome/sedan/info.json

* Rename keymap.c to keymaps.c

* Rename keymap.c to keymaps.c

* folder name updated

* updated keymaps

* remove erroneously added files

* extend keymap functionality

* Update config.h

* Update config.h

* added URL on line qmk#3 for image of Coupe

* Added URL to line qmk#3

* Update keyboards/clawsome/sedan/readme.md

* Update keyboards/clawsome/coupe/readme.md
*
*/
#define MATRIX_ROW_PINS { B0, B1, B2, B3, B4 }
#define MATRIX_COL_PINS { B5, B6, B7, C0, C1, C2, C3, C4, C5, C6, C7, D0, D1, D2, D3 }

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AlisGraveNil Is this accurate to an elite-C? I'm debugging a fully built board that has an issue with multiple key-downs and I've never seen a pinout diagram of an elite C look like this (no F pins, C0?).

Can open a separate issue if this is truly off, but I'm trying to figure out if I'm just going crazy or not.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To clarify, based on The Sedan v1.2 that's available

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have no idea where it's getting 'C0' from - that's not at all the pinout I created last year.

Do you have a Sedan on hand that's bugging out?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do! Happy to assist.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

email me (alex@clawboards.xyx) and I'll send you a working firmware that I've had archived, and I'll look at doing a fork for fixes in a bit

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants