Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

relocating boards by flehrad to flehrad/ folder #9635

Merged
merged 1 commit into from
Jul 30, 2020

Conversation

flehrad
Copy link
Contributor

@flehrad flehrad commented Jul 3, 2020

Description

Requesting relocation of a number of pcbs/boards I have created to be moved into a folder to easier manage and track which boards have qmk completions in configurator.
This also improves identification of pcb maker.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Issues Fixed or Closed by This PR

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@zvecr zvecr added breaking_change Changes that need to wait for a version increment keyboard labels Jul 3, 2020
@zvecr
Copy link
Member

zvecr commented Jul 3, 2020

This PR should target the develop branch instead of master as it is considered a breaking change.

@flehrad
Copy link
Contributor Author

flehrad commented Jul 3, 2020

This PR should target the develop branch instead of master as it is considered a breaking change.

:( Sorry, I'm very novice to a lot of this still, is there something I need to do to make this workable, or should I not look to move these, and just only request to add newer boards into a folder going forwards?

@flehrad
Copy link
Contributor Author

flehrad commented Jul 5, 2020

Closing to raise new PR to develop.

@flehrad flehrad closed this Jul 5, 2020
@fauxpark
Copy link
Member

fauxpark commented Jul 5, 2020

You can retarget this PR by clicking the edit button, and then rebasing.

@flehrad flehrad reopened this Jul 5, 2020
@flehrad flehrad changed the base branch from master to develop July 5, 2020 00:35
@flehrad
Copy link
Contributor Author

flehrad commented Jul 5, 2020

Changed to Develop. Thank you Ryan.

@drashna drashna requested a review from a team July 24, 2020 03:37
@drashna drashna requested a review from a team July 25, 2020 09:04
@drashna drashna merged commit 550bb6a into qmk:develop Jul 30, 2020
noroadsleft pushed a commit that referenced this pull request Jul 31, 2020
Co-authored-by: flehrad <flehrad@users.noreply.github.com>
noroadsleft pushed a commit that referenced this pull request Aug 11, 2020
Co-authored-by: flehrad <flehrad@users.noreply.github.com>
noroadsleft pushed a commit that referenced this pull request Aug 27, 2020
Co-authored-by: flehrad <flehrad@users.noreply.github.com>
noroadsleft pushed a commit that referenced this pull request Aug 29, 2020
Co-authored-by: flehrad <flehrad@users.noreply.github.com>
nicocesar pushed a commit to nicocesar/qmk_firmware that referenced this pull request Sep 6, 2020
Co-authored-by: flehrad <flehrad@users.noreply.github.com>
kjganz pushed a commit to kjganz/qmk_firmware that referenced this pull request Oct 28, 2020
Co-authored-by: flehrad <flehrad@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking_change Changes that need to wait for a version increment keyboard
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants