Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Docs] Update Japanese translation of feature_backlight.md. #9803

Merged
merged 3 commits into from
Jul 31, 2020
Merged

[Docs] Update Japanese translation of feature_backlight.md. #9803

merged 3 commits into from
Jul 31, 2020
+124 −153

Conversation

shelaf
Copy link
Contributor

@shelaf shelaf commented Jul 24, 2020

Description

Japanese documentation update.

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Keyboard (addition or update)
  • Keymap/layout/userspace (addition or update)
  • Documentation

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

tag: @mtei

Sorry, something went wrong.

@shelaf shelaf changed the title [Docs] Update Japanese translation of feature_backligt.md. [Docs] Update Japanese translation of feature_backlight.md. Jul 24, 2020
@shelaf shelaf force-pushed the ja_feature_backlight branch from c54cb51 to 93e7db3 Compare July 24, 2020 03:08
@mtei
Copy link
Contributor

mtei commented Jul 24, 2020

@umi-umi @s-show @hsgw @satt99 @takashiski @yoshihara よかったらレビューお願いします。

@shelaf
fix original document version.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
5eb179f
mtei
mtei reviewed Jul 29, 2020
View reviewed changes
@mtei mtei requested a review from a team July 29, 2020 17:30
@mtei mtei requested a review from a team July 30, 2020 08:22
@mtei
Copy link
Contributor

mtei commented Jul 30, 2020

I think this is ready to merge.

noroadsleft
noroadsleft approved these changes Jul 31, 2020
View reviewed changes
Copy link
Member

@noroadsleft noroadsleft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@noroadsleft noroadsleft merged commit 0f3e933 into qmk:master Jul 31, 2020
@noroadsleft
Copy link
Member

ありがとうございました！

@shelaf shelaf deleted the ja_feature_backlight branch August 1, 2020 00:14
nicocesar pushed a commit to nicocesar/qmk_firmware that referenced this pull request Aug 12, 2020
@shelaf @nicocesar
[Docs] Update Japanese translation of feature_backlight.md. (qmk#9803)
0a63b65 
* Update Japanese translation of feature_backlight.md.

* fix original document version.

* Apply suggestions from code review
BorisTestov pushed a commit to BorisTestov/qmk_firmware that referenced this pull request May 23, 2024
@shelaf
[Docs] Update Japanese translation of feature_backlight.md. (qmk#9803)
f09c9da 
* Update Japanese translation of feature_backlight.md.

* fix original document version.

* Apply suggestions from code review
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mtei mtei

@noroadsleft noroadsleft

@s-show s-show

Assignees
No one assigned
Labels
documentation translation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@shelaf @mtei @noroadsleft @s-show