Skip to content

Navigation Menu

Explore
By company size
By use case
By industry
View all solutions
Topics
- AI
- DevOps
- Security
- Software Development
- View all
Explore
- GitHub Sponsors
  Fund open source developers
- The ReadME Project
  GitHub community articles
Repositories
- Enterprise platform
  AI-powered developer platform
Available add-ons
Pricing

Search code, repositories, users, issues, pull requests...

Search

Clear

Search syntax tips

Provide feedback

We read every piece of feedback, and take your input very seriously.

Include my email address so I can be contacted

Saved searches

Use saved searches to filter your results more quickly

Name

Query

To see all available qualifiers, see our documentation.

You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session. You switched accounts on another tab or window. Reload to refresh your session.

Dismiss alert

qmk / qmk_firmware Public

Notifications You must be signed in to change notification settings
Fork 40.5k
Star 18.7k

Code
Issues 313
Pull requests 247
Actions
Projects 1
Security
Insights

Additional navigation options

Code
Issues
Pull requests
Actions
Projects
Security
Insights

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue 9942: Add LSA, RSA, RCS, LSA_T, RSA_T, and RCS_T #9943

Merged

noroadsleft merged 7 commits into qmk:master from nopunin10did:add-mod-combo-shortcuts-9942

Aug 17, 2020

Merged

Issue 9942: Add LSA, RSA, RCS, LSA_T, RSA_T, and RCS_T #9943

noroadsleft merged 7 commits into qmk:master from nopunin10did:add-mod-combo-shortcuts-9942

Aug 17, 2020

Conversation 19 Commits 7 Checks 0 Files changed

Conversation

Copy link

Contributor

nopunin10did commented Aug 5, 2020 •

edited by fauxpark

Loading

Add codes to quantum_keycodes for LSA, RSA, RCS, and their corresponding _T macros

Description

Per feature request 9942, added macro defines for common modifier combos.

LSA(kc) & LSA_T(kc) - Left Shift + Left Alt
RSA(kc) & RSA_T(kc) - Right Shift + Right Alt (Alt Gr)
RCS(kc) & RCS_T(kc) - Right Ctrl + Right Shift

Types of Changes

Core
Bugfix
New feature
Enhancement/optimization
Keyboard (addition or update)
Keymap/layout/userspace (addition or update)
Documentation

Issues Fixed or Closed by This PR

Fixes [Feature Request] Add mod key shortcuts and "_T" functions for multiple modifier combinations #9942

Checklist

My code follows the code style of this project.
My change requires a change to the documentation.
I have updated the documentation accordingly.
I have read the CONTRIBUTING document.
I have added tests to cover my changes.
I have tested the changes and verified that they work and don't break anything (as well as I can manage).

Sorry, something went wrong.

All reactions

nopunin10did added 2 commits

August 5, 2020 12:34


          Issue 9942: Add Quantum defines

dd6303b

Add codes to quantum_keycodes for LSA, RSA, RCS, and their corresponding _T macros


          9942: Add documentation for new defines

9ff5077

Add documentation for new defines in feature request 9942. Also define SAGR and SAGR_T as aliases for RSA and RSA_T.

nopunin10did commented

View reviewed changes

docs/keycodes.md Outdated Show resolved Hide resolved

nopunin10did commented

View reviewed changes

docs/keycodes.md Show resolved Hide resolved

nopunin10did commented

View reviewed changes

docs/keycodes.md Show resolved Hide resolved

nopunin10did commented

View reviewed changes

docs/keycodes.md Show resolved Hide resolved

nopunin10did commented

View reviewed changes

docs/keycodes.md Outdated Show resolved Hide resolved

nopunin10did changed the title ~~Issue 9942: Add Quantum defines~~ Issue 9942: Add defines for LSA, RSA, RCS, LSA_T, RSA_T, and RCS_T with two aliases

nopunin10did changed the title ~~Issue 9942: Add defines for LSA, RSA, RCS, LSA_T, RSA_T, and RCS_T with two aliases~~ Issue 9942: Add LSA, RSA, RCS, LSA_T, RSA_T, and RCS_T

nopunin10did marked this pull request as ready for review

August 5, 2020 17:47

drashna approved these changes

View reviewed changes

fauxpark requested changes

View reviewed changes

quantum/quantum_keycodes.h Outdated Show resolved Hide resolved

docs/keycodes.md Outdated Show resolved Hide resolved

docs/keycodes.md Outdated Show resolved Hide resolved

docs/keycodes.md Outdated Show resolved Hide resolved

docs/keycodes.md Outdated Show resolved Hide resolved

fauxpark requested a review from a team

August 12, 2020 14:15

fauxpark added core documentation enhancement labels

nopunin10did and others added 5 commits

August 12, 2020 11:35


          Update quantum/quantum_keycodes.h

Co-authored-by: Ryan <fauxpark@gmail.com>


          Update docs/keycodes.md

489cf30

Co-authored-by: Ryan <fauxpark@gmail.com>


          Update docs/keycodes.md

ed7b8ee

Co-authored-by: Ryan <fauxpark@gmail.com>


          Update docs/keycodes.md

3844ac8

Co-authored-by: Ryan <fauxpark@gmail.com>


          Update docs/keycodes.md

134757d

Co-authored-by: Ryan <fauxpark@gmail.com>

noroadsleft approved these changes

View reviewed changes

noroadsleft merged commit b4ae7ba into qmk:master

Copy link

Member

noroadsleft commented Aug 17, 2020

Thanks!

All reactions

Sorry, something went wrong.

nicocesar pushed a commit to nicocesar/qmk_firmware that referenced this pull request


          Issue 9942: Add LSA, RSA, RCS, LSA_T, RSA_T, and RCS_T (qmk#9943)

414ebbf

* Issue 9942: Add Quantum defines

Add codes to quantum_keycodes for LSA, RSA, RCS, and their corresponding _T macros

* 9942: Add documentation for new defines

Add documentation for new defines in feature request 9942. Also define SAGR and SAGR_T as aliases for RSA and RSA_T.

* Update quantum/quantum_keycodes.h

* Update docs/keycodes.md

* Update docs/keycodes.md

* Update docs/keycodes.md

* Update docs/keycodes.md

nopunin10did mentioned this pull request

Add The Railroad keyboard and documentation follow-up (9942) #10412

Closed

14 tasks

nopunin10did mentioned this pull request

Doc followup 9942 #10473

Merged

14 tasks

drashna pushed a commit to zsa/qmk_firmware that referenced this pull request


          Issue 9942: Add LSA, RSA, RCS, LSA_T, RSA_T, and RCS_T (qmk#9943)

fae09e2

* Issue 9942: Add Quantum defines

Add codes to quantum_keycodes for LSA, RSA, RCS, and their corresponding _T macros

* 9942: Add documentation for new defines

Add documentation for new defines in feature request 9942. Also define SAGR and SAGR_T as aliases for RSA and RSA_T.

* Update quantum/quantum_keycodes.h

* Update docs/keycodes.md

* Update docs/keycodes.md

* Update docs/keycodes.md

* Update docs/keycodes.md

nopunin10did deleted the add-mod-combo-shortcuts-9942 branch

November 10, 2022 14:44

BorisTestov pushed a commit to BorisTestov/qmk_firmware that referenced this pull request


          Issue 9942: Add LSA, RSA, RCS, LSA_T, RSA_T, and RCS_T (qmk#9943)

a6b57a2

* Issue 9942: Add Quantum defines

Add codes to quantum_keycodes for LSA, RSA, RCS, and their corresponding _T macros

* 9942: Add documentation for new defines

Add documentation for new defines in feature request 9942. Also define SAGR and SAGR_T as aliases for RSA and RSA_T.

* Update quantum/quantum_keycodes.h

* Update docs/keycodes.md

* Update docs/keycodes.md

* Update docs/keycodes.md

* Update docs/keycodes.md

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

fauxpark fauxpark requested changes

drashna drashna approved these changes

noroadsleft noroadsleft approved these changes

Assignees

No one assigned

Labels

core documentation enhancement

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Feature Request] Add mod key shortcuts and "_T" functions for multiple modifier combinations

4 participants

Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.

Footer

© 2025 GitHub, Inc.

Footer navigation

Terms
Privacy
Security
Status
Docs
Contact

You can’t perform that action at this time.